test: make test logs clear #1242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes test log levels across the test suite to reduce noise and improve test output clarity. The changes introduce a configurable logLevel parameter to the test helper functions and update various test files to use consistent logging practices.
- Adds
logLevelparameter tobuildAndGetResultsfunction with 'warn' as default - Updates import statements to use consistent patterns from
@rstest/core - Modifies specific tests to use appropriate log levels for their testing needs
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/scripts/shared.ts | Adds logLevel configuration to test helper functions |
| tests/integration/entry/index.test.ts | Sets info log level for duplicate entry test |
| tests/integration/cli/mf/mf.test.ts | Consolidates imports from @rstest/core |
| tests/integration/cli/log-level/index.test.ts | Consolidates imports from @rstest/core |
| tests/integration/cli/inspect/inspect.test.ts | Consolidates imports from @rstest/core |
| tests/integration/cli/build-watch/build.test.ts | Updates imports and changes stdio to pipe for cleaner output |
| packages/core/tests/config.test.ts | Adds silent log level to test configuration |
| packages/core/tests/snapshots/config.test.ts.snap | Updates snapshot with silent log level |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fi3ework
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set
logLevelto'warn'when running tests to make test logs clear.Tests related to log messages should call
proxyConsolewhen writing tests.Related Links
Checklist