fix: do not modify mf’s output config #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fi3ework
force-pushed
the
mf-hahs
branch
2 times, most recently
from
3a6afaf to
40b6558
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables content hash in filenames for Module Federation (MF) format outputs to support better caching and prevent cache staleness issues.
- Removes the global
filenameHash: falsesetting that was being applied to all formats - Adds format-specific
filenameHash: falseconfiguration for esm, cjs, umd, and iife formats - Excludes MF format from the filename hash override in
composeOutputFilenameConfig, allowing MF to use the default Rspack hashing behavior
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/config.ts | Refactors filenameHash configuration to be format-specific, excluding MF format from hash disabling |
| packages/core/tests/config.test.ts | Updates snapshot tests to use individual snapshots per format for better test clarity |
| packages/core/tests/snapshots/config.test.ts.snap | Regenerates snapshots to reflect the new MF hash behavior and test structure changes |
| tests/integration/minify/index.test.ts | Updates snapshot to include content hash in MF output filename |
| tests/integration/format/index.test.ts | Adds new test to verify MF output includes hash in filenames |
| tests/integration/format/mf/* | Adds new MF format test fixture |
| pnpm-lock.yaml | Registers new test fixture directory |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
should not modify MF's output config, for example, chunk hash should be reserved as the output is prone to be uploaded to CDN and conflict without hash.
Related Links
Checklist