Skip to content

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 14, 2024

Summary

Rsbuild follows semver and it is safe to unpin Rsbuild to allow automatic patch upgrade.

I use ~ instead of ^ because the Rspack minor releases may contain SWC breaking changes.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit d112ec0
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/670dd0f359234a000885c842
😎 Deploy Preview https://deploy-preview-290--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #290 will degrade performances by 51.98%

Comparing unpin_rsbuild_1014 (d112ec0) with main (86f16f9)

Summary

❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main unpin_rsbuild_1014 Change
examples/react-component-bundle-false 173.8 ms 362 ms -51.98%

@chenjiahan chenjiahan marked this pull request as draft October 14, 2024 15:05
@chenjiahan chenjiahan marked this pull request as ready for review October 15, 2024 02:20
@chenjiahan chenjiahan merged commit 9f1551f into main Oct 15, 2024
16 of 17 checks passed
@chenjiahan chenjiahan deleted the unpin_rsbuild_1014 branch October 15, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants