Skip to content

chore: modify release workflow #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore: modify release workflow #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9f33c
chore: modify release workflow
Timeless0911 Oct 29, 2024
6b59765
chore: update
Timeless0911 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,14 @@ Here are the steps to publish (we generally use CI for releases and avoid publis
<!-- 1. [Create release pull request](https://github.com/web-infra-dev/rslib/actions/workflows/release-pull-request.yml). -->

1. Run `pnpm generate-release-pr` to create a release pull request.
2. [Run the release action](https://github.com/web-infra-dev/rslib/actions/workflows/release.yml).
3. [Generate the release notes](https://github.com/web-infra-dev/rslib/releases).
4. Merge the release pull request.
2. [Run the release action on release branch](https://github.com/web-infra-dev/rslib/actions/workflows/release.yml).
3. Merge the release pull request.
4. [Create Git tag on main branch and generate the release notes](https://github.com/web-infra-dev/rslib/releases).

## Caveats

The project is still in its early stages and under active development, so it possible dependents on Rsbuild or Rspack canary versions to test the latest features. The current versions are:

| Package | Link |
| ------------ | ------------------------------------------------------------ |
| @rspack/core | https://github.com/web-infra-dev/rspack/releases/tag/v1.0.10 |
| @rspack/core | https://github.com/web-infra-dev/rspack/releases/tag/v1.0.14 |
2 changes: 1 addition & 1 deletion scripts/generateReleasePr.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ async function main() {
console.log(chalk.blue(`Next version: ${nextVersion}`));

// 3. Create and switch to new branch
const branchName = `release-v${nextVersion}`;
const branchName = `release_v${nextVersion}`;
console.log(chalk.blue(`Creating branch: ${branchName}`));

await $`git checkout -b ${branchName}`;
Expand Down
Loading