Skip to content

feat(create-rslib): add prepublishOnly script for templates #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(create-rslib): add prepublishOnly script for templates #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/create-rslib/template-[node-dual]-[]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
],
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch"
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build"
},
"devDependencies": {
"@rslib/core": "workspace:*"
Expand Down
3 changes: 2 additions & 1 deletion packages/create-rslib/template-[node-dual]-[]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
],
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch"
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build"
},
"devDependencies": {
"@rslib/core": "workspace:*",
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[node-dual]-[vitest]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"test": "vitest run"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[node-dual]-[vitest]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"test": "vitest run"
},
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/create-rslib/template-[node-esm]-[]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
],
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch"
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build"
},
"devDependencies": {
"@rslib/core": "workspace:*"
Expand Down
3 changes: 2 additions & 1 deletion packages/create-rslib/template-[node-esm]-[]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
],
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch"
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build"
},
"devDependencies": {
"@rslib/core": "workspace:*",
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[node-esm]-[vitest]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"test": "vitest run"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[node-esm]-[vitest]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"test": "vitest run"
},
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/create-rslib/template-[react]-[]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
],
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch"
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build"
},
"devDependencies": {
"@rsbuild/plugin-react": "^1.0.7",
Expand Down
3 changes: 2 additions & 1 deletion packages/create-rslib/template-[react]-[]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
],
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch"
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build"
},
"devDependencies": {
"@rsbuild/plugin-react": "^1.0.7",
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[react]-[storybook,vitest]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"build": "rslib build",
"build:storybook": "storybook build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"storybook": "storybook dev",
"test": "vitest run"
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[react]-[storybook,vitest]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"build": "rslib build",
"build:storybook": "storybook build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"storybook": "storybook dev",
"test": "vitest run"
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[react]-[storybook]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"build": "rslib build",
"build:storybook": "storybook build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"storybook": "storybook dev"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[react]-[storybook]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"build": "rslib build",
"build:storybook": "storybook build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"storybook": "storybook dev"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[react]-[vitest]-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"test": "vitest run"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/create-rslib/template-[react]-[vitest]-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"scripts": {
"build": "rslib build",
"dev": "rslib build --watch",
"prepublishOnly": "pnpm run build",
"test": "vitest run"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/create-rslib/test/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const expectPackageJson = (
expect(pkgJson.name).toBe(name);
expect(pkgJson.scripts.dev).toBe('rslib build --watch');
expect(pkgJson.scripts.build).toBe('rslib build');
expect(pkgJson.scripts.prepublishOnly).toBe('pnpm run build');
expect(pkgJson.devDependencies['@rslib/core']).toBeTruthy();
};

Expand All @@ -53,7 +54,6 @@ export const createAndValidate = (
}

execSync(command, { cwd });

const pkgJson = fse.readJSONSync(path.join(dir, 'package.json'));
expectPackageJson(pkgJson, path.basename(name));

Expand Down