Skip to content

fix: catch error when killing DTS child process #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix: catch error when killing DTS child process #510

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a32837
fix: ignore dts kill EPERM error
9aoy Dec 2, 2024
df4f503
fix: update
9aoy Dec 2, 2024
78d4d69
Update packages/plugin-dts/src/index.ts
Timeless0911 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/plugin-dts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,11 @@ export const pluginDts = (options: PluginDtsOptions = {}): RsbuildPlugin => ({
const killProcesses = () => {
for (const childProcess of childProcesses) {
if (!childProcess.killed) {
childProcess.kill();
try {
childProcess.kill();
// silent kill error, such as: kill EPERM error on windows
// https://github.com/nodejs/node/issues/51766
} catch (_err) {}
}
}
childProcesses = [];
Expand Down
Loading