fix: set filename dynamically using a function #912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
composeAutoExtensionConfigfuction, we should only return config aboutoutput.filename.jsinstead of wholeoutput.filenameobject to avoid being merged into an array which Rsbuild will throw an error, see #911 (comment).BTW, just record this scene in this PR that Rslib support setting function for
output.filename.jsand it will take effect in actual output. But we can not get correct js extension when we redirect js path in bundleless mode and will fallback to the default js extension (related toautoExtensionconfig) which may not be consistent with the actual output.Eg.
The actual output is
foo.mjsbut we can not get it and redirect tofoo.jsas a fallback.So if users want to set function for
output.filename.js, the[ext]should better be equal to the default js extension (related toautoExtensionconfig).Related Links
fix: #911
Checklist