feat(linter): add languageOptions support for TypeScript parser

Add languageOptions configuration to lint requests to support custom TypeScript parser options
Remove special case handling for dot-notation rule as it's now handled by languageOptions

Author: ScriptedAlchemy

cmd/rslint/api.go

@@ -107,7 +107,21 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 	rslintconfig.RegisterAllTypeScriptEslintPluginRules()
 
 	// Load rslint configuration and determine which tsconfig files to use
-	_, tsConfigs, configDirectory := rslintconfig.LoadConfigurationWithFallback(req.Config, currentDirectory, fs)
+	var tsConfigs []string
+	var configDirectory string
+	
+	if req.LanguageOptions != nil && req.LanguageOptions.ParserOptions != nil && req.LanguageOptions.ParserOptions.Project != "" {
+		// Use project from languageOptions
+		configDirectory = currentDirectory
+		projectPath := tspath.ResolvePath(currentDirectory, req.LanguageOptions.ParserOptions.Project)
+		if !fs.FileExists(projectPath) {
+			return nil, fmt.Errorf("tsconfig file specified in languageOptions %q doesn't exist", projectPath)
+		}
+		tsConfigs = []string{projectPath}
+	} else {
+		// Use default configuration loading
+		_, tsConfigs, configDirectory = rslintconfig.LoadConfigurationWithFallback(req.Config, currentDirectory, fs)
+	}
 
 	// Create rules
 	var origin_rules = []rule.Rule{

internal/api/api.go

@@ -53,15 +53,27 @@ type HandshakeResponse struct {
 	OK      bool   `json:"ok"`
 }
 
+// LanguageOptions represents language-specific parser options
+type LanguageOptions struct {
+	ParserOptions *ParserOptions `json:"parserOptions,omitempty"`
+}
+
+// ParserOptions represents TypeScript parser options
+type ParserOptions struct {
+	Project        string `json:"project,omitempty"`
+	ProjectService bool   `json:"projectService,omitempty"`
+}
+
 // LintRequest represents a lint request from JS to Go
 type LintRequest struct {
-	Files            []string `json:"files,omitempty"`
-	Config           string   `json:"config,omitempty"` // Path to rslint.json config file
-	Format           string   `json:"format,omitempty"`
-	WorkingDirectory string   `json:"workingDirectory,omitempty"`
+	Files            []string          `json:"files,omitempty"`
+	Config           string            `json:"config,omitempty"` // Path to rslint.json config file
+	Format           string            `json:"format,omitempty"`
+	WorkingDirectory string            `json:"workingDirectory,omitempty"`
 	// Supports both string level and array [level, options] format
-	RuleOptions  map[string]interface{} `json:"ruleOptions,omitempty"`
-	FileContents map[string]string      `json:"fileContents,omitempty"` // Map of file paths to their contents for VFS
+	RuleOptions     map[string]interface{} `json:"ruleOptions,omitempty"`
+	FileContents    map[string]string      `json:"fileContents,omitempty"` // Map of file paths to their contents for VFS
+	LanguageOptions *LanguageOptions       `json:"languageOptions,omitempty"`
 }
 
 // LintResponse represents a lint response from Go to JS

packages/rslint/src/service.ts

@@ -38,6 +38,12 @@ export interface LintOptions {
   workingDirectory?: string;
   ruleOptions?: Record<string, string>;
   fileContents?: Record<string, string>; // Map of file paths to their contents for VFS
+  languageOptions?: {
+    parserOptions?: {
+      project?: string;
+      projectService?: boolean;
+    };
+  };
 }
 
 interface RSlintOptions {
@@ -177,8 +183,14 @@ export class RSLintService {
    * Run the linter on specified files
    */
   async lint(options: LintOptions = {}): Promise<LintResponse> {
-    const { files, config, workingDirectory, ruleOptions, fileContents } =
-      options;
+    const {
+      files,
+      config,
+      workingDirectory,
+      ruleOptions,
+      fileContents,
+      languageOptions,
+    } = options;
     // Send handshake
     await this.sendMessage('handshake', { version: '1.0.0' });
 
@@ -189,6 +201,7 @@ export class RSLintService {
       workingDirectory,
       ruleOptions,
       fileContents,
+      languageOptions,
       format: 'jsonline',
     });
   }

packages/rule-tester/src/index.ts

@@ -177,30 +177,8 @@ export class RuleTester {
               ? false
               : validCase.languageOptions?.parserOptions?.ecmaFeatures?.jsx;
 
-          let options =
+          const options =
             typeof validCase === 'string' ? [] : validCase.options || [];
-
-          // Handle special case for dot-notation rule with noPropertyAccessFromIndexSignature tsconfig
-          if (
-            ruleName === '@typescript-eslint/dot-notation' &&
-            typeof validCase === 'object' &&
-            validCase.languageOptions?.parserOptions?.project ===
-              './tsconfig.noPropertyAccessFromIndexSignature.json'
-          ) {
-            // Simulate noPropertyAccessFromIndexSignature: true by setting allowIndexSignaturePropertyAccess: true
-            if (Array.isArray(options) && options.length === 0) {
-              options = [{ allowIndexSignaturePropertyAccess: true }];
-            } else if (
-              Array.isArray(options) &&
-              options.length > 0 &&
-              typeof options[0] === 'object'
-            ) {
-              options[0] = {
-                ...options[0],
-                allowIndexSignaturePropertyAccess: true,
-              };
-            }
-          }
           let virtual_entry = path.resolve(
             cwd,
             isJSX ? 'src/virtual.tsx' : 'src/virtual.ts',
@@ -226,6 +204,10 @@ export class RuleTester {
             ruleOptions: {
               [ruleName]: options,
             },
+            languageOptions:
+              typeof validCase === 'object'
+                ? validCase.languageOptions
+                : undefined,
           });
 
           assert(
@@ -236,28 +218,13 @@ export class RuleTester {
       });
       test('invalid', async t => {
         for (const item of cases.invalid) {
-          let { code, errors, only = false, skip = false, options = [] } = item;
-
-          // Handle special case for dot-notation rule with noPropertyAccessFromIndexSignature tsconfig
-          if (
-            ruleName === '@typescript-eslint/dot-notation' &&
-            item.languageOptions?.parserOptions?.project ===
-              './tsconfig.noPropertyAccessFromIndexSignature.json'
-          ) {
-            // Simulate noPropertyAccessFromIndexSignature: true by setting allowIndexSignaturePropertyAccess: true
-            if (Array.isArray(options) && options.length === 0) {
-              options = [{ allowIndexSignaturePropertyAccess: true }];
-            } else if (
-              Array.isArray(options) &&
-              options.length > 0 &&
-              typeof options[0] === 'object'
-            ) {
-              options[0] = {
-                ...options[0],
-                allowIndexSignaturePropertyAccess: true,
-              };
-            }
-          }
+          const {
+            code,
+            errors,
+            only = false,
+            skip = false,
+            options = [],
+          } = item;
           if (skip) {
             continue;
           }
@@ -278,6 +245,7 @@ export class RuleTester {
             ruleOptions: {
               [ruleName]: options,
             },
+            languageOptions: item.languageOptions,
           });
 
           expect(diags).toMatchSnapshot();