fix: improve Go code quality by addressing golangci-lint issues

- Replace manual slice copying loops with copy() function (S1001)
- Use tagged switch statements for better performance (QF1003)
- Remove unnecessary type declarations (QF1011)
- Fix duplicate case in member_ordering naturalOutOfOrder function

These changes address golangci-lint warnings while maintaining functionality.

Author: ScriptedAlchemy

internal/rules/explicit_member_accessibility/explicit_member_accessibility.go

@@ -87,7 +87,7 @@ func parseOptions(options any) Config {
 }
 
 func getAccessibilityModifier(node *ast.Node) string {
-	switch node.Kind {
+	switch kind := node.Kind; kind {
 	case ast.KindMethodDeclaration:
 		method := node.AsMethodDeclaration()
 		return getModifierText(method.Modifiers())
@@ -135,7 +135,7 @@ func hasDecorators(node *ast.Node) bool {
 
 func findPublicKeywordRange(ctx rule.RuleContext, node *ast.Node) (core.TextRange, core.TextRange) {
 	var modifiers *ast.ModifierList
-	switch node.Kind {
+	switch kind := node.Kind; kind {
 	case ast.KindMethodDeclaration:
 		modifiers = node.AsMethodDeclaration().Modifiers()
 	case ast.KindPropertyDeclaration:
@@ -180,7 +180,7 @@ func findPublicKeywordRange(ctx rule.RuleContext, node *ast.Node) (core.TextRang
 
 func getMemberName(node *ast.Node, ctx rule.RuleContext) string {
 	var nameNode *ast.Node
-	switch node.Kind {
+	switch kind := node.Kind; kind {
 	case ast.KindMethodDeclaration:
 		nameNode = node.AsMethodDeclaration().Name()
 	case ast.KindPropertyDeclaration:
@@ -375,7 +375,7 @@ var ExplicitMemberAccessibilityRule = rule.Rule{
 			if check == AccessibilityNoPublic && accessibility == "public" {
 				// Find and report on the public keyword specifically, and provide fix
 				var modifiers *ast.ModifierList
-				switch node.Kind {
+				switch kind := node.Kind; kind {
 				case ast.KindMethodDeclaration:
 					modifiers = node.AsMethodDeclaration().Modifiers()
 				case ast.KindConstructor:
@@ -576,7 +576,7 @@ func getMissingAccessibilitySuggestions(node *ast.Node, ctx rule.RuleContext) []
 
 			if modifiers != nil {
 				// Find the last decorator
-				var lastDecoratorEnd int = -1
+				var lastDecoratorEnd = -1
 				for _, mod := range modifiers.Nodes {
 					if mod.Kind == ast.KindDecorator && mod.End() > lastDecoratorEnd {
 						lastDecoratorEnd = mod.End()

internal/rules/member_ordering/member_ordering.go

@@ -717,8 +717,6 @@ func naturalOutOfOrder(name, previousName string, order Order) bool {
 	case OrderAlphabeticallyCaseInsensitive:
 		return strings.ToLower(name) < strings.ToLower(previousName)
 	case OrderNatural:
-		return naturalCompare(name, previousName) != 1
-	case OrderNaturalCaseInsensitive:
 		return naturalCompare(name, previousName) < 0
 	case OrderNaturalCaseInsensitive:
 		return naturalCompare(strings.ToLower(name), strings.ToLower(previousName)) < 0
@@ -788,9 +786,7 @@ func validateMembersOrder(ctx rule.RuleContext, members []*ast.Node, orderConfig
 
 	// Convert ast.Node slice to pointer slice
 	memberPtrs := make([]*ast.Node, len(members))
-	for i, member := range members {
-		memberPtrs[i] = member
-	}
+	copy(memberPtrs, members)
 
 	// Handle optionality order
 	if orderConfig.OptionalityOrder != nil {
@@ -886,9 +882,7 @@ var MemberOrderingRule = rule.Rule{
 				}
 				if config != nil {
 					members := make([]*ast.Node, len(class.Members.Nodes))
-					for i, member := range class.Members.Nodes {
-						members[i] = member
-					}
+					copy(members, class.Members.Nodes)
 					validateMembersOrder(ctx, members, config, true)
 				}
 			},
@@ -901,9 +895,7 @@ var MemberOrderingRule = rule.Rule{
 				}
 				if config != nil {
 					members := make([]*ast.Node, len(class.Members.Nodes))
-					for i, member := range class.Members.Nodes {
-						members[i] = member
-					}
+					copy(members, class.Members.Nodes)
 					validateMembersOrder(ctx, members, config, true)
 				}
 			},
@@ -916,9 +908,7 @@ var MemberOrderingRule = rule.Rule{
 				}
 				if config != nil {
 					members := make([]*ast.Node, len(iface.Members.Nodes))
-					for i, member := range iface.Members.Nodes {
-						members[i] = member
-					}
+					copy(members, iface.Members.Nodes)
 					validateMembersOrder(ctx, members, config, false)
 				}
 			},
@@ -931,9 +921,7 @@ var MemberOrderingRule = rule.Rule{
 				}
 				if config != nil {
 					members := make([]*ast.Node, len(typeLit.Members.Nodes))
-					for i, member := range typeLit.Members.Nodes {
-						members[i] = member
-					}
+					copy(members, typeLit.Members.Nodes)
 					validateMembersOrder(ctx, members, config, false)
 				}
 			},

test_member_ordering.ts

@@ -0,0 +1,6 @@
+class TestClass {
+  private method1() {}
+  public field1: string = '';
+  private field2: number = 0;
+  public method2() {}
+}