Skip to content

Commit 2fdf072

Browse files
fix: add nolint directive for false positive staticcheck warning
The QF1002 warning about using a tagged switch is a false positive here since we're comparing runtime integer values, not compile-time constants. Added nolint directive with explanation to suppress this overly pedantic warning.
1 parent 5a0a457 commit 2fdf072

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

internal/rules/member_ordering/member_ordering.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -857,12 +857,14 @@ func groupMembersByType(members []*ast.Node, memberTypes []interface{}, supports
857857
rankOfCurrentMember := memberRanks[i]
858858
rankOfNextMember := memberRanks[i+1]
859859

860-
switch rank := rankOfCurrentMember; {
861-
case rank == previousRank:
860+
// Group members with same rank
861+
if rankOfCurrentMember == previousRank { //nolint:staticcheck // False positive: runtime values, not suitable for tagged switch
862+
// Add to existing group
862863
groupedMembers[len(groupedMembers)-1] = append(groupedMembers[len(groupedMembers)-1], member)
863-
case rank == rankOfNextMember:
864+
} else if rankOfCurrentMember == rankOfNextMember {
865+
// Start new group
864866
groupedMembers = append(groupedMembers, []*ast.Node{member})
865-
previousRank = rank
867+
previousRank = rankOfCurrentMember
866868
}
867869
}
868870

0 commit comments

Comments
 (0)