Skip to content

Commit 301bc7e

Browse files
authored
chore: fix release tag push (#266)
1 parent 7377f78 commit 301bc7e

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ jobs:
2626
strategy:
2727
fail-fast: false
2828
matrix:
29-
runner:
30-
[
29+
runner: [
3130
rspack-ubuntu-22.04-large,
32-
rspack-windows-2022-large,
31+
# TODO: enable later
32+
# rspack-windows-2022-large,
3333
windows-latest,
3434
rspack-darwin-14-medium,
3535
]
@@ -51,7 +51,7 @@ jobs:
5151
cache-name: test-go
5252
- name: Unit Test
5353
run: |
54-
go test -parallel 4 ./internal/...
54+
go test -parallel 8 ./internal/...
5555
go-lint:
5656
name: Go Lint
5757
runs-on: rspack-ubuntu-22.04-large
@@ -149,6 +149,7 @@ jobs:
149149
needs:
150150
- test-go
151151
- test-node
152+
- go-lint
152153
if: always()
153154
runs-on: ubuntu-latest
154155
name: CI Done

.github/workflows/release.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ jobs:
102102
pnpm -r publish --no-git-checks --tag ${{ github.event.inputs.npm_tag }} --publish-branch ${{ github.event.inputs.branch }}
103103
git config --global user.email "github-actions[bot]@users.noreply.github.com"
104104
git config --global user.name "github-actions"
105-
echo git tag v$(jq -r .version package.json)
106-
git tag v$(jq -r .version package.json)
107-
git push origin --follow-tags
105+
version=$(jq -r .version package.json)
106+
git tag v$version -m "v$version"
107+
git push origin v$version
108108
109109
publish-extension-vscode:
110110
if: ${{ inputs.to_release == 'all' || inputs.to_release == 'extension' }}
@@ -220,7 +220,7 @@ jobs:
220220
- name: Setup Go
221221
uses: ./.github/actions/setup-go
222222
with:
223-
go-version: ${{ env.GO_VERSION }}
223+
go-version: 1.25.0
224224
cache-name: ${{ matrix.node_os }}-${{ matrix.node_arch }}
225225

226226
- name: Install pnpm
@@ -318,7 +318,7 @@ jobs:
318318
- name: Setup Go
319319
uses: ./.github/actions/setup-go
320320
with:
321-
go-version: ${{ env.GO_VERSION }}
321+
go-version: 1.25.0
322322
cache-name: ${{ matrix.node_os }}-${{ matrix.node_arch }}
323323

324324
- name: Install pnpm

0 commit comments

Comments
 (0)