feat: implement no-namespace (#197)

Co-authored-by: heyongqi10 <[email protected]>

Author: holyfata

cmd/rslint/api.go

@@ -33,6 +33,7 @@ import (
 	"github.com/web-infra-dev/rslint/internal/rules/no_misused_promises"
 	"github.com/web-infra-dev/rslint/internal/rules/no_misused_spread"
 	"github.com/web-infra-dev/rslint/internal/rules/no_mixed_enums"
+	"github.com/web-infra-dev/rslint/internal/rules/no_namespace"
 	"github.com/web-infra-dev/rslint/internal/rules/no_redundant_type_constituents"
 	"github.com/web-infra-dev/rslint/internal/rules/no_require_imports"
 	"github.com/web-infra-dev/rslint/internal/rules/no_unnecessary_boolean_literal_compare"
@@ -124,6 +125,7 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 		no_misused_promises.NoMisusedPromisesRule,
 		no_misused_spread.NoMisusedSpreadRule,
 		no_mixed_enums.NoMixedEnumsRule,
+		no_namespace.NoNamespaceRule,
 		no_redundant_type_constituents.NoRedundantTypeConstituentsRule,
 		no_require_imports.NoRequireImportsRule,
 		no_unnecessary_boolean_literal_compare.NoUnnecessaryBooleanLiteralCompareRule,

internal/config/config.go

@@ -24,6 +24,7 @@ import (
 	"github.com/web-infra-dev/rslint/internal/rules/no_misused_promises"
 	"github.com/web-infra-dev/rslint/internal/rules/no_misused_spread"
 	"github.com/web-infra-dev/rslint/internal/rules/no_mixed_enums"
+	"github.com/web-infra-dev/rslint/internal/rules/no_namespace"
 	"github.com/web-infra-dev/rslint/internal/rules/no_redundant_type_constituents"
 	"github.com/web-infra-dev/rslint/internal/rules/no_require_imports"
 	"github.com/web-infra-dev/rslint/internal/rules/no_unnecessary_boolean_literal_compare"
@@ -284,6 +285,7 @@ func RegisterAllTypeScriptEslintPluginRules() {
 	GlobalRuleRegistry.Register("@typescript-eslint/no-misused-promises", no_misused_promises.NoMisusedPromisesRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-misused-spread", no_misused_spread.NoMisusedSpreadRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-mixed-enums", no_mixed_enums.NoMixedEnumsRule)
+	GlobalRuleRegistry.Register("@typescript-eslint/no-namespace", no_namespace.NoNamespaceRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-redundant-type-constituents", no_redundant_type_constituents.NoRedundantTypeConstituentsRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-require-imports", no_require_imports.NoRequireImportsRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-unnecessary-boolean-literal-compare", no_unnecessary_boolean_literal_compare.NoUnnecessaryBooleanLiteralCompareRule)

internal/rules/no_namespace/no_namespace.go

@@ -0,0 +1,88 @@
+package no_namespace
+
+import (
+	"strings"
+
+	"github.com/microsoft/typescript-go/shim/ast"
+	"github.com/web-infra-dev/rslint/internal/rule"
+	"github.com/web-infra-dev/rslint/internal/utils"
+)
+
+// build the message for no-namespace rule
+func buildNoNamespaceMessage() rule.RuleMessage {
+	return rule.RuleMessage{
+		Id:          "moduleSyntaxIsPreferred",
+		Description: "Namespace is not allowed.",
+	}
+}
+
+// rule options
+type NoNamespaceOptions struct {
+	AllowDeclarations    *bool `json:"allowDeclarations"`
+	AllowDefinitionFiles *bool `json:"allowDefinitionFiles"`
+}
+
+// default options
+var defaultNoNamespaceOptions = NoNamespaceOptions{
+	AllowDeclarations:    utils.Ref(false),
+	AllowDefinitionFiles: utils.Ref(true),
+}
+
+// rule instance
+// check if the namespace is used
+var NoNamespaceRule = rule.CreateRule(rule.Rule{
+	Name: "no-namespace",
+	Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
+		opts := defaultNoNamespaceOptions
+
+		// Parse options with dual-format support (handles both array and object formats)
+		if options != nil {
+			var optsMap map[string]interface{}
+			var ok bool
+
+			// Handle array format: [{ option: value }]
+			if optArray, isArray := options.([]interface{}); isArray && len(optArray) > 0 {
+				optsMap, ok = optArray[0].(map[string]interface{})
+			} else {
+				// Handle direct object format: { option: value }
+				optsMap, ok = options.(map[string]interface{})
+			}
+
+			if ok {
+				if allowDeclarations, ok := optsMap["allowDeclarations"].(bool); ok {
+					opts.AllowDeclarations = utils.Ref(allowDeclarations)
+				}
+				if allowDefinitionFiles, ok := optsMap["allowDefinitionFiles"].(bool); ok {
+					opts.AllowDefinitionFiles = utils.Ref(allowDefinitionFiles)
+				}
+			}
+		}
+
+		return rule.RuleListeners{
+			ast.KindModuleDeclaration: func(node *ast.Node) {
+				moduleDecl := node.AsModuleDeclaration()
+				if moduleDecl == nil {
+					return
+				}
+
+				// Check if this is a namespace declaration (keyword is KindNamespaceKeyword)
+				if moduleDecl.Keyword != ast.KindNamespaceKeyword {
+					return
+				}
+
+				// Check if we're in a .d.ts file and allowDefinitionFiles is true
+				if opts.AllowDefinitionFiles != nil && *opts.AllowDefinitionFiles && strings.HasSuffix(ctx.SourceFile.FileName(), ".d.ts") {
+					return
+				}
+
+				// Check if this is a declare namespace and allowDeclarations is true
+				if opts.AllowDeclarations != nil && *opts.AllowDeclarations && utils.IncludesModifier(node, ast.KindDeclareKeyword) {
+					return
+				}
+
+				// Report the namespace usage
+				ctx.ReportNode(moduleDecl.Name(), buildNoNamespaceMessage())
+			},
+		}
+	},
+})