fix(rule): fix crash in no-misused-new rule caused by missing node.Name().Text() in ComputedPropertyName node (#419)

Author: fansenze

internal/plugins/typescript/rules/no_misused_new/no_misused_new.go

@@ -3,6 +3,7 @@ package no_misused_new
 import (
 	"github.com/microsoft/typescript-go/shim/ast"
 	"github.com/web-infra-dev/rslint/internal/rule"
+	"github.com/web-infra-dev/rslint/internal/utils"
 )
 
 /**
@@ -34,7 +35,8 @@ var NoMisusedNewRule = rule.CreateRule(rule.Rule{
 					return
 				}
 
-				if node.Name().Text() != "new" {
+				nodeNameText, _ := utils.GetNameFromMember(ctx.SourceFile, node.Name())
+				if nodeNameText != "new" {
 					return
 				}
 				// If the function body exists, it's valid for this rule.
@@ -62,7 +64,8 @@ var NoMisusedNewRule = rule.CreateRule(rule.Rule{
 				}
 			},
 			ast.KindMethodSignature: func(node *ast.Node) {
-				if node.Name().Text() == "constructor" {
+				nodeNameText, _ := utils.GetNameFromMember(ctx.SourceFile, node.Name())
+				if nodeNameText == "constructor" {
 					ctx.ReportNode(node, rule.RuleMessage{
 						Id:          "errorMessageInterface",
 						Description: "interfaces cannot be constructed, only classes.",

internal/plugins/typescript/rules/no_misused_new/no_misused_new_test.go

@@ -170,5 +170,62 @@ func TestNoMisusedNewRule(t *testing.T) {
 				},
 			},
 		},
+		{
+			Code: `
+				class C {
+					['constructor']() {};
+				}
+			`,
+		},
+		{
+			Code: `
+				class C {
+				  ['new'](): C;
+				}
+			`,
+			Errors: []rule_tester.InvalidTestCaseError{
+				{
+					MessageId: "errorMessageClass",
+				},
+			},
+		},
+		{
+			Code: `
+				declare abstract class C {
+				  ['constructor']() {};
+				}
+			`,
+		},
+		{
+			Code: `
+				declare abstract class C {
+				  ['new'](): C;
+				}
+			`,
+			Errors: []rule_tester.InvalidTestCaseError{
+				{
+					MessageId: "errorMessageClass",
+				},
+			},
+		},
+		{
+			Code: `
+				interface I {
+					['new'](): I;
+				}
+			`,
+		},
+		{
+			Code: `
+				interface I {
+				  ['constructor'](): '';
+				}
+			`,
+			Errors: []rule_tester.InvalidTestCaseError{
+				{
+					MessageId: "errorMessageInterface",
+				},
+			},
+		},
 	})
 }

packages/rslint-test-tools/tests/typescript-eslint/rules/__snapshots__/no-misused-new.test.ts.snap

@@ -195,3 +195,93 @@ interface I {
   "ruleCount": 1,
 }
 `;
+
+exports[`no-misused-new > invalid 7`] = `
+{
+  "code": "
+class C {
+  ['new'](): C;
+}
+      ",
+  "diagnostics": [
+    {
+      "message": "Class cannot have method named \`new\`.",
+      "messageId": "errorMessageClass",
+      "range": {
+        "end": {
+          "column": 16,
+          "line": 3,
+        },
+        "start": {
+          "column": 3,
+          "line": 3,
+        },
+      },
+      "ruleName": "@typescript-eslint/no-misused-new",
+    },
+  ],
+  "errorCount": 1,
+  "fileCount": 1,
+  "ruleCount": 1,
+}
+`;
+
+exports[`no-misused-new > invalid 8`] = `
+{
+  "code": "
+declare abstract class C {
+  ['new'](): C;
+}
+      ",
+  "diagnostics": [
+    {
+      "message": "Class cannot have method named \`new\`.",
+      "messageId": "errorMessageClass",
+      "range": {
+        "end": {
+          "column": 16,
+          "line": 3,
+        },
+        "start": {
+          "column": 3,
+          "line": 3,
+        },
+      },
+      "ruleName": "@typescript-eslint/no-misused-new",
+    },
+  ],
+  "errorCount": 1,
+  "fileCount": 1,
+  "ruleCount": 1,
+}
+`;
+
+exports[`no-misused-new > invalid 9`] = `
+{
+  "code": "
+interface I {
+  ['constructor'](): '';
+}
+      ",
+  "diagnostics": [
+    {
+      "message": "interfaces cannot be constructed, only classes.",
+      "messageId": "errorMessageInterface",
+      "range": {
+        "end": {
+          "column": 25,
+          "line": 3,
+        },
+        "start": {
+          "column": 3,
+          "line": 3,
+        },
+      },
+      "ruleName": "@typescript-eslint/no-misused-new",
+    },
+  ],
+  "errorCount": 1,
+  "fileCount": 1,
+  "ruleCount": 1,
+}
+`;

packages/rslint-test-tools/tests/typescript-eslint/rules/no-misused-new.test.ts

@@ -70,6 +70,21 @@ interface foo {
     `
 interface foo {
   new <T>(): 'x';
+}
+    `,
+    `
+class C {
+  ['constructor']() {};
+}
+    `,
+    `
+declare abstract class C {
+  ['constructor']() {};
+}
+    `,
+    `
+interface I {
+  ['new'](): I;
 }
     `,
   ],
@@ -156,6 +171,48 @@ declare abstract class C {
       code: `
 interface I {
   constructor(): '';
+}
+      `,
+      errors: [
+        {
+          column: 3,
+          line: 3,
+          messageId: 'errorMessageInterface',
+        },
+      ],
+    },
+    {
+      code: `
+class C {
+  ['new'](): C;
+}
+      `,
+      errors: [
+        {
+          column: 3,
+          line: 3,
+          messageId: 'errorMessageClass',
+        },
+      ],
+    },
+    {
+      code: `
+declare abstract class C {
+  ['new'](): C;
+}
+      `,
+      errors: [
+        {
+          column: 3,
+          line: 3,
+          messageId: 'errorMessageClass',
+        },
+      ],
+    },
+    {
+      code: `
+interface I {
+  ['constructor'](): '';
 }
       `,
       errors: [