refactor: use createRule to defineRule (#161)

Author: hardfist

.github/workflows/ci.yml

@@ -41,7 +41,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: latest
+          version: v2.3.0
           args: --timeout=5m ./cmd/... ./internal/...
       - name: go vet
         run: npm run lint:go

.golangci.yml

@@ -37,7 +37,7 @@ linters:
     - misspell
     - musttag
     - nakedret
-    - nolintlint
+    # - nolintlint
     - paralleltest
     - perfsprint
     - predeclared

cmd/rslint/lsp.go

@@ -95,7 +95,7 @@ func (s *LSPServer) handleInitialize(ctx context.Context, req *jsonrpc2.Request)
 	if err := json.Unmarshal(*req.Params, &params); err != nil {
 		s.rootURI = "."
 	} else {
-		//nolint:staticcheck
+		//nolint
 		if params.RootUri.DocumentUri != nil {
 			s.rootURI = uriToPath(string(*params.RootUri.DocumentUri))
 		}

internal/config/config.go

@@ -318,7 +318,6 @@ func getAllTypeScriptEslintPluginRules() []rule.Rule {
 	allRules := GlobalRuleRegistry.GetAllRules()
 	var rules []rule.Rule
 	for _, rule := range allRules {
-		rule.Name = "@typescript-eslint/" + rule.Name
 		rules = append(rules, rule)
 	}
 	return rules

internal/linter/linter.go

@@ -59,7 +59,7 @@ func RunLinter(programs []*compiler.Program, singleThreaded bool, allowFiles []s
 						rules := getRulesForFile(file)
 						// Create disable manager for this file
 						disableManager := rule.NewDisableManager(file)
-						
+
 						for _, r := range rules {
 							ctx := rule.RuleContext{
 								SourceFile:     file,

internal/rule/disable_manager.go

@@ -27,9 +27,9 @@ const (
 // DisableManager tracks which rules are disabled at different locations in a file
 type DisableManager struct {
 	sourceFile            *ast.SourceFile
-	disabledRules         map[string]bool    // Rules disabled for the entire file
-	lineDisabledRules     map[int][]string   // Rules disabled for specific lines
-	nextLineDisabledRules map[int][]string   // Rules disabled for the next line
+	disabledRules         map[string]bool  // Rules disabled for the entire file
+	lineDisabledRules     map[int][]string // Rules disabled for specific lines
+	nextLineDisabledRules map[int][]string // Rules disabled for the next line
 }
 
 // NewDisableManager creates a new DisableManager for the given source file

internal/rule/rule.go

@@ -87,6 +87,13 @@ type Rule struct {
 	Run  func(ctx RuleContext, options any) RuleListeners
 }
 
+func CreateRule(r Rule) Rule {
+	return Rule{
+		Name: "@typescript-eslint/" + r.Name,
+		Run:  r.Run,
+	}
+}
+
 type RuleMessage struct {
 	Id          string
 	Description string
@@ -158,7 +165,7 @@ type RuleContext struct {
 	SourceFile                 *ast.SourceFile
 	Program                    *compiler.Program
 	TypeChecker                *checker.Checker
-	DisableManager            *DisableManager
+	DisableManager             *DisableManager
 	ReportRange                func(textRange core.TextRange, msg RuleMessage)
 	ReportRangeWithSuggestions func(textRange core.TextRange, msg RuleMessage, suggestions ...RuleSuggestion)
 	ReportNode                 func(node *ast.Node, msg RuleMessage)

internal/rules/adjacent_overload_signatures/adjacent_overload_signatures.go

@@ -180,7 +180,7 @@ func checkBodyForOverloadMethods(ctx rule.RuleContext, node *ast.Node) {
 	}
 }
 
-var AdjacentOverloadSignaturesRule = rule.Rule{
+var AdjacentOverloadSignaturesRule = rule.CreateRule(rule.Rule{
 	Name: "adjacent-overload-signatures",
 	Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
 		// Check the source file at the beginning
@@ -204,4 +204,4 @@ var AdjacentOverloadSignaturesRule = rule.Rule{
 			},
 		}
 	},
-}
+})

internal/rules/array_type/array_type.go

@@ -143,7 +143,7 @@ func buildErrorStringGenericSimpleMessage(readonlyPrefix, typeStr, className str
 	}
 }
 
-var ArrayTypeRule = rule.Rule{
+var ArrayTypeRule = rule.CreateRule(rule.Rule{
 	Name: "array-type",
 	Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
 		opts := ArrayTypeOptions{
@@ -438,4 +438,4 @@ var ArrayTypeRule = rule.Rule{
 			},
 		}
 	},
-}
+})

internal/rules/await_thenable/await_thenable.go

@@ -42,7 +42,7 @@ func buildAwaitUsingOfNonAsyncDisposableMessage() rule.RuleMessage {
 	}
 }
 
-var AwaitThenableRule = rule.Rule{
+var AwaitThenableRule = rule.CreateRule(rule.Rule{
 	Name: "await-thenable",
 	Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
 		return rule.RuleListeners{
@@ -131,4 +131,4 @@ var AwaitThenableRule = rule.Rule{
 			},
 		}
 	},
-}
+})