chore: passing more case (#173)

Author: hardfist

internal/rules/no_confusing_void_expression/no_confusing_void_expression.go

@@ -1,6 +1,7 @@
 package no_confusing_void_expression
 
 import (
+	"encoding/json"
 	"github.com/microsoft/typescript-go/shim/ast"
 	"github.com/microsoft/typescript-go/shim/checker"
 	"github.com/microsoft/typescript-go/shim/scanner"
@@ -58,17 +59,29 @@ func buildVoidExprWrapVoidMessage() rule.RuleMessage {
 }
 
 type NoConfusingVoidExpressionOptions struct {
-	IgnoreArrowShorthand         bool
-	IgnoreVoidOperator           bool
-	IgnoreVoidReturningFunctions bool
+	IgnoreArrowShorthand         bool `json:"ignoreArrowShorthand,omitempty"`
+	IgnoreVoidOperator           bool `json:"ignoreVoidOperator,omitempty"`
+	IgnoreVoidReturningFunctions bool `json:"ignoreVoidReturningFunctions,omitempty"`
 }
 
 var NoConfusingVoidExpressionRule = rule.CreateRule(rule.Rule{
 	Name: "no-confusing-void-expression",
 	Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
 		opts, ok := options.(NoConfusingVoidExpressionOptions)
+
 		if !ok {
+			// try convert options to JSON and back to struct
 			opts = NoConfusingVoidExpressionOptions{}
+			// get first element of options
+			options_array, _ := options.([]interface{})
+			// if options_array has at least one element, try to unmarshal it
+			if len(options_array) > 0 {
+				optsJSON, err := json.Marshal(options_array[0])
+				if err == nil {
+					json.Unmarshal(optsJSON, &opts)
+				}
+
+			}
 		}
 
 		canFix := func(node *ast.Node) bool {

internal/utils/create_program.go

@@ -43,7 +43,12 @@ func CreateProgram(singleThreaded bool, fs vfs.FS, cwd string, tsconfigPath stri
 
 	diagnostics := program.GetSyntacticDiagnostics(context.Background(), nil)
 	if len(diagnostics) != 0 {
-		return nil, fmt.Errorf("found %v syntactic errors. Try running \"tsgo --noEmit\" first", len(diagnostics))
+		// convert diagnostics to a string for better error reporting
+		var diagnosticStrings []string
+		for _, diagnostic := range diagnostics {
+			diagnosticStrings = append(diagnosticStrings, diagnostic.Message(), diagnostic.File().Text())
+		}
+		return nil, fmt.Errorf("found %v syntactic errors. %v", len(diagnostics), diagnosticStrings)
 	}
 
 	program.BindSourceFiles()

packages/rslint-test-tools/rstest.config.mts

@@ -4,10 +4,11 @@ export default defineConfig({
   testEnvironment: 'node',
   globals: true,
   include: [
-    './tests/typescript-eslint/rules/await-thenable.test.ts',
-    './tests/typescript-eslint/rules/no-array-delete.test.ts',
-    './tests/typescript-eslint/rules/no-for-in-array.test.ts',
     './tests/typescript-eslint/rules/adjacent-overload-signatures.test.ts',
     './tests/typescript-eslint/rules/array-type.test.ts',
+    './tests/typescript-eslint/rules/await-thenable.test.ts',
+    './tests/typescript-eslint/rules/class-literal-property-style.test.ts',
+    './tests/typescript-eslint/rules/no-array-delete.test.ts',
+    './tests/typescript-eslint/rules/no-confusing-void-expression.test.ts',
   ],
 });

packages/rslint-test-tools/tests/typescript-eslint/fixtures/tsconfig.json

@@ -1,7 +1,10 @@
 {
   "compilerOptions": {
     "strictNullChecks": true,
-    "isolatedModules": true
+    "isolatedModules": true,
+    "jsx": "preserve"
   },
-  "include": ["src/**/*.ts"]
-}
+  "include": [
+    "src/**/*.ts"
+  ]
+}

packages/rslint-test-tools/tests/typescript-eslint/fixtures/tsconfig.virtual.json

@@ -1,6 +1,9 @@
 {
   "compilerOptions": {
-    "strictNullChecks": true
+    "strictNullChecks": true,
+    "jsx": "preserve"
   },
-  "include": ["src/virtual.ts"]
-}
+  "include": [
+    "src/virtual.ts"
+  ]
+}