Revert "feat: implement '@typescript/no-non-null-assertion'" (#218)

Author: hardfist

cmd/rslint/api.go

@@ -34,7 +34,6 @@ import (
 	"github.com/web-infra-dev/rslint/internal/rules/no_misused_spread"
 	"github.com/web-infra-dev/rslint/internal/rules/no_mixed_enums"
 	"github.com/web-infra-dev/rslint/internal/rules/no_namespace"
-	"github.com/web-infra-dev/rslint/internal/rules/no_non_null_assertion"
 	"github.com/web-infra-dev/rslint/internal/rules/no_redundant_type_constituents"
 	"github.com/web-infra-dev/rslint/internal/rules/no_require_imports"
 	"github.com/web-infra-dev/rslint/internal/rules/no_unnecessary_boolean_literal_compare"
@@ -127,7 +126,6 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
 		no_misused_spread.NoMisusedSpreadRule,
 		no_mixed_enums.NoMixedEnumsRule,
 		no_namespace.NoNamespaceRule,
-		no_non_null_assertion.NoNonNullAssertionRule,
 		no_redundant_type_constituents.NoRedundantTypeConstituentsRule,
 		no_require_imports.NoRequireImportsRule,
 		no_unnecessary_boolean_literal_compare.NoUnnecessaryBooleanLiteralCompareRule,

internal/config/config.go

@@ -25,7 +25,6 @@ import (
 	"github.com/web-infra-dev/rslint/internal/rules/no_misused_spread"
 	"github.com/web-infra-dev/rslint/internal/rules/no_mixed_enums"
 	"github.com/web-infra-dev/rslint/internal/rules/no_namespace"
-	"github.com/web-infra-dev/rslint/internal/rules/no_non_null_assertion"
 	"github.com/web-infra-dev/rslint/internal/rules/no_redundant_type_constituents"
 	"github.com/web-infra-dev/rslint/internal/rules/no_require_imports"
 	"github.com/web-infra-dev/rslint/internal/rules/no_unnecessary_boolean_literal_compare"
@@ -287,7 +286,6 @@ func RegisterAllTypeScriptEslintPluginRules() {
 	GlobalRuleRegistry.Register("@typescript-eslint/no-misused-spread", no_misused_spread.NoMisusedSpreadRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-mixed-enums", no_mixed_enums.NoMixedEnumsRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-namespace", no_namespace.NoNamespaceRule)
-	GlobalRuleRegistry.Register("@typescript-eslint/no-non-null-assertion", no_non_null_assertion.NoNonNullAssertionRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-redundant-type-constituents", no_redundant_type_constituents.NoRedundantTypeConstituentsRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-require-imports", no_require_imports.NoRequireImportsRule)
 	GlobalRuleRegistry.Register("@typescript-eslint/no-unnecessary-boolean-literal-compare", no_unnecessary_boolean_literal_compare.NoUnnecessaryBooleanLiteralCompareRule)

internal/rules/no_non_null_assertion/no_non_null_assertion.go

@@ -15,6 +15,5 @@ export default defineConfig({
     './tests/typescript-eslint/rules/no-require-imports.test.ts',
     './tests/typescript-eslint/rules/no-duplicate-type-constituents.test.ts',
     './tests/typescript-eslint/rules/no_namespace.test.ts',
-    './tests/typescript-eslint/rules/no_non_null_assertion.test.ts',
   ],
 });

internal/rules/no_non_null_assertion/no_non_null_assertion_test.go

@@ -19,8 +19,7 @@
       "@typescript-eslint/no-empty-function": "error",
       "@typescript-eslint/no-empty-interface": "error",
       "@typescript-eslint/no-require-imports": "error",
-      "@typescript-eslint/no-namespace": "error",
-      "@typescript-eslint/no-non-null-assertion": "error"
+      "@typescript-eslint/no-namespace": "error"
     },
     "plugins": ["@typescript-eslint"]
   }

packages/rslint-test-tools/rstest.config.mts

@@ -58,7 +58,6 @@ export class Extension implements Disposable {
   ): Rslint {
     if (this.rslintInstances.has(id)) {
       this.logger.warn(`Rslint instance with id '${id}' already exists`);
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       return this.rslintInstances.get(id)!;
     }
 

packages/rslint/fixtures/rslint.json

@@ -293,7 +293,6 @@ export class Rslint implements Disposable {
     }
 
     this.logger.debug('Final Rslint binary path:', finalBinPath);
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     return finalBinPath!;
   }
 }