chore: use golanglint in ci (#147)

Author: hardfist

.github/workflows/ci.yml

@@ -33,6 +33,11 @@ jobs:
         with:
           go-version: ${{ matrix.go-version }}
           cache-name: test-go
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v8
+        with:
+          version: latest
+          args: --timeout=5m ./cmd/... ./internal/...
       - name: go vet
         run: npm run lint:go
       - name: go fmt

.golangci.yml

@@ -0,0 +1,39 @@
+version: '2'
+linters:
+  enable:
+    - govet # Go vet examiner
+    - ineffassign # Detect ineffectual assignments
+
+    - unused # Check for unused constants, variables, functions and types
+    - misspell # Finds commonly misspelled English words
+    - unconvert # Remove unnecessary type conversions
+
+  disable:
+    - errcheck # Check for unchecked errors
+    - gosec # Inspects source code for security problems
+    - staticcheck # It's a set of rules from staticcheck
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+  new: false
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

cmd/rslint/cmd.go

@@ -449,9 +449,10 @@ func runCMD() int {
 		w := bufio.NewWriterSize(os.Stdout, 4096*100)
 		defer w.Flush()
 		for d := range diagnosticsChan {
-			if d.Severity == rule.SeverityError {
+			switch d.Severity {
+			case rule.SeverityError:
 				errorsCount++
-			} else if d.Severity == rule.SeverityWarning {
+			case rule.SeverityWarning:
 				warningsCount++
 			}
 
@@ -509,7 +510,7 @@ func runCMD() int {
 
 			if len(diagnosticsWithFixes) > 0 {
 				// Read the original file content
-				originalContent := string(diagnosticsWithFixes[0].SourceFile.Text())
+				originalContent := diagnosticsWithFixes[0].SourceFile.Text()
 
 				// Apply fixes
 				fixedContent, unapplied, wasFixed := linter.ApplyRuleFixes(originalContent, diagnosticsWithFixes)
@@ -600,10 +601,7 @@ func runCMD() int {
 		}
 	}
 
-	tooManyWarnings := false
-	if maxWarnings >= 0 && warningsCount > maxWarnings {
-		tooManyWarnings = true
-	}
+	tooManyWarnings := maxWarnings >= 0 && warningsCount > maxWarnings
 
 	if errorsCount == 0 && tooManyWarnings {
 		fmt.Fprintf(os.Stderr, "Rslint found too many warnings (maximum: %d).\n", maxWarnings)

cmd/rslint/main.go

@@ -25,5 +25,5 @@ func runMain() int {
 		}
 	}
 	// run in CLI mode for direct command line usage
-	return int(runCMD())
+	return runCMD()
 }

internal/rules/no_base_to_string/no_base_to_string.go

@@ -19,7 +19,7 @@ func certaintyToString(certainty usefulness) string {
 	case usefulnessSometimes:
 		return "always"
 	default:
-		panic("unkown certainty")
+		panic("unknown certainty")
 	}
 }
 

internal/rules/no_misused_promises/no_misused_promises.go

@@ -25,7 +25,7 @@ func buildPredicateMessage() rule.RuleMessage {
 func buildSpreadMessage() rule.RuleMessage {
 	return rule.RuleMessage{
 		Id:          "spread",
-		Description: "Expected a non-Promise value to be spreaded in an object.",
+		Description: "Expected a non-Promise value to be spread in an object.",
 	}
 }
 func buildVoidReturnArgumentMessage() rule.RuleMessage {

internal/rules/no_unsafe_enum_comparison/no_unsafe_enum_comparison.go

@@ -21,6 +21,8 @@ func buildMismatchedConditionMessage() rule.RuleMessage {
 		Description: "The two values in this comparison do not have a shared enum type.",
 	}
 }
+
+//nolint:unused
 func buildReplaceValueWithEnumMessage() rule.RuleMessage {
 	return rule.RuleMessage{
 		Id:          "replaceValueWithEnum",

internal/rules/require_await/require_await.go

@@ -13,6 +13,8 @@ func buildMissingAwaitMessage() rule.RuleMessage {
 		Description: "Function has no 'await' expression.",
 	}
 }
+
+//nolint:unused
 func buildRemoveAsyncMessage() rule.RuleMessage {
 	return rule.RuleMessage{
 		Id:          "removeAsync",

internal/rules/switch_exhaustiveness_check/switch_exhaustiveness_check.go

@@ -10,6 +10,7 @@ import (
 	"github.com/web-infra-dev/rslint/internal/utils"
 )
 
+//nolint:unused
 func buildAddMissingCasesMessage() rule.RuleMessage {
 	return rule.RuleMessage{
 		Id:          "addMissingCases",

package.json

@@ -25,8 +25,8 @@
     "test:go": "go test ./internal/...",
     "typecheck": "pnpm tsc -b tsconfig.json",
     "lint": "rslint",
-    "lint:go": "go vet ./cmd/... ./internal/...",
-    "format:go": "go fmt ./cmd/... ./internal/...",
+    "lint:go": "golangci-lint run ./cmd/... ./internal/...",
+    "format:go": "golangci-lint fmt ./cmd/... ./internal/...",
     "prepare": "husky"
   },
   "devDependencies": {