Skip to content

fix: test failed in ci when using canary version #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: test failed in ci when using canary version #31

merged 1 commit into from
Apr 28, 2025

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Apr 28, 2025

The regex is wrong when matching canary version of rspack

@LingyuCoder LingyuCoder requested review from SyMind and Copilot April 28, 2025 09:42
Copilot AI reviewed Apr 28, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@LingyuCoder LingyuCoder merged commit 0244b83 into main Apr 28, 2025
6 checks passed
@LingyuCoder LingyuCoder deleted the fix/canary-ci branch April 28, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@SyMind SyMind SyMind approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @SyMind