Skip to content

fix: avoid exceeding the maximum call stack size #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: avoid exceeding the maximum call stack size #9

merged 1 commit into from
Oct 11, 2024

Conversation

@inottn
Copy link
Contributor

@inottn inottn commented Oct 10, 2024

fix #7 fix web-infra-dev/rspack#8079

m.require.resolve might be undefined.

LingyuCoder
LingyuCoder approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@LingyuCoder LingyuCoder merged commit e3ff091 into web-infra-dev:main Oct 11, 2024
4 checks passed
@inottn inottn deleted the fix/7 branch October 11, 2024 04:42
@JounQin
Copy link

JounQin commented Oct 11, 2024

When will this PR been released?

@chenjiahan
Copy link
Member

chenjiahan commented Oct 11, 2024

@JounQin Released: https://github.com/web-infra-dev/rspack-dev-server/releases/tag/v1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: rspack serve throws Maximum call stack size exceeded when using JS APIs and a multi-config Maximum call stack size exceeded

4 participants

@inottn @JounQin @chenjiahan @LingyuCoder