refactor: enable more perf rule

Author: hardfist

Cargo.toml

@@ -496,7 +496,7 @@ verbose_bit_mask             = "warn"
 zero_sized_map_values        = "warn"
 
 # performance
-perf = "warn"
+perf = { level = "warn", priority = -1 }
 # performance - memory allocation optimization
 box_collection       = "warn"
 redundant_allocation = "warn"

crates/rspack/src/builder/builder_context.rs

@@ -127,7 +127,7 @@ impl BuilderContext {
         plugins.push(rspack_plugin_externals::node_target_plugin())
       }
       BuiltinPluginOptions::ElectronTargetPlugin(context) => {
-        rspack_plugin_externals::electron_target_plugin(context, &mut plugins)
+        rspack_plugin_externals::electron_target_plugin(&context, &mut plugins)
       }
       BuiltinPluginOptions::HttpExternalsRspackPlugin((css, web_async)) => {
         plugins.push(rspack_plugin_externals::http_externals_rspack_plugin(
@@ -149,11 +149,11 @@ impl BuilderContext {
         plugins.push(rspack_plugin_runtime::ModuleChunkFormatPlugin::default().boxed());
       }
       BuiltinPluginOptions::EnableChunkLoadingPlugin(chunk_loading_type) => {
-        rspack_plugin_runtime::enable_chunk_loading_plugin(chunk_loading_type, &mut plugins);
+        rspack_plugin_runtime::enable_chunk_loading_plugin(&chunk_loading_type, &mut plugins);
       }
       BuiltinPluginOptions::EnableWasmLoadingPlugin(wasm_loading_type) => {
         plugins.push(rspack_plugin_wasm::enable_wasm_loading_plugin(
-          wasm_loading_type,
+          &wasm_loading_type,
         ));
       }
 
@@ -169,7 +169,7 @@ impl BuilderContext {
       BuiltinPluginOptions::SourceMapDevToolPlugin(options) => {
         plugins.push(
           rspack_plugin_devtool::SourceMapDevToolModuleOptionsPlugin::new(
-            rspack_plugin_devtool::SourceMapDevToolModuleOptionsPluginOptions {
+            &rspack_plugin_devtool::SourceMapDevToolModuleOptionsPluginOptions {
               module: options.module,
               cheap: !options.columns,
             },
@@ -181,7 +181,7 @@ impl BuilderContext {
       BuiltinPluginOptions::EvalSourceMapDevToolPlugin(options) => {
         plugins.push(
           rspack_plugin_devtool::SourceMapDevToolModuleOptionsPlugin::new(
-            rspack_plugin_devtool::SourceMapDevToolModuleOptionsPluginOptions {
+            &rspack_plugin_devtool::SourceMapDevToolModuleOptionsPluginOptions {
               module: options.module,
               cheap: !options.columns,
             },
@@ -315,7 +315,7 @@ impl BuilderContext {
 
       // Define and optimization plugins
       BuiltinPluginOptions::DefinePlugin(values) => {
-        plugins.push(rspack_plugin_javascript::define_plugin::DefinePlugin::new(values).boxed())
+        plugins.push(rspack_plugin_javascript::define_plugin::DefinePlugin::new(&values).boxed())
       }
       BuiltinPluginOptions::AnyMinimizerRspackPlugin(plugin) => plugins.push(plugin),
 

crates/rspack_binding_api/src/compilation/mod.rs

@@ -371,7 +371,7 @@ impl JsCompilation {
   pub fn rename_asset(&mut self, filename: String, new_name: String) -> Result<()> {
     let compilation = self.as_mut()?;
 
-    compilation.rename_asset(&filename, new_name);
+    compilation.rename_asset(&filename, &new_name);
     Ok(())
   }
 

crates/rspack_binding_api/src/exports_info.rs

@@ -105,9 +105,9 @@ impl JsExportsInfo {
       Either::B(v) => v.into_iter().map(Into::into).collect::<Vec<_>>(),
     };
     let exports_info = ExportsInfoGetter::prefetch(
-      &self.exports_info,
+      self.exports_info,
       module_graph,
-      PrefetchExportsInfoMode::Nested(&names),
+      &PrefetchExportsInfoMode::Nested(&names),
     );
     let used = exports_info.get_used(&names, runtime.as_ref());
     Ok(used as u32)

crates/rspack_binding_api/src/raw_options/raw_builtins/mod.rs

@@ -67,8 +67,11 @@ use rspack_plugin_ignore::IgnorePlugin;
 use rspack_plugin_javascript::{
   FlagDependencyExportsPlugin, FlagDependencyUsagePlugin, InferAsyncModulesPlugin,
   InlineExportsPlugin, JsPlugin, MangleExportsPlugin, ModuleConcatenationPlugin,
-  SideEffectsFlagPlugin, api_plugin::APIPlugin, define_plugin::DefinePlugin,
-  provide_plugin::ProvidePlugin, url_plugin::URLPlugin,
+  SideEffectsFlagPlugin,
+  api_plugin::APIPlugin,
+  define_plugin::{DefinePlugin, DefineValue},
+  provide_plugin::ProvidePlugin,
+  url_plugin::URLPlugin,
 };
 use rspack_plugin_json::JsonPlugin;
 use rspack_plugin_library::enable_library_plugin;
@@ -301,11 +304,9 @@ impl<'a> BuiltinPlugin<'a> {
     match name {
       // webpack also have these plugins
       BuiltinPluginName::DefinePlugin => {
-        let plugin = DefinePlugin::new(
-          downcast_into(self.options)
-            .map_err(|report| napi::Error::from_reason(report.to_string()))?,
-        )
-        .boxed();
+        let definitions: DefineValue = downcast_into(self.options)
+          .map_err(|report| napi::Error::from_reason(report.to_string()))?;
+        let plugin = DefinePlugin::new(&definitions).boxed();
         plugins.push(plugin);
       }
       BuiltinPluginName::ProvidePlugin => {
@@ -393,12 +394,14 @@ impl<'a> BuiltinPlugin<'a> {
       BuiltinPluginName::ElectronTargetPlugin => {
         let context = downcast_into::<String>(self.options)
           .map_err(|report| napi::Error::from_reason(report.to_string()))?;
-        electron_target_plugin(context.into(), plugins);
+        let context: ElectronTargetContext = context.into();
+        electron_target_plugin(&context, plugins);
       }
       BuiltinPluginName::EnableChunkLoadingPlugin => {
         let chunk_loading_type = downcast_into::<String>(self.options)
           .map_err(|report| napi::Error::from_reason(report.to_string()))?;
-        enable_chunk_loading_plugin(chunk_loading_type.as_str().into(), plugins);
+        let chunk_loading_type: ChunkLoadingType = chunk_loading_type.as_str().into();
+        enable_chunk_loading_plugin(&chunk_loading_type, plugins);
       }
       BuiltinPluginName::EnableLibraryPlugin => {
         let library_type = downcast_into::<String>(self.options)
@@ -408,9 +411,8 @@ impl<'a> BuiltinPlugin<'a> {
       BuiltinPluginName::EnableWasmLoadingPlugin => {
         let wasm_loading_type = downcast_into::<String>(self.options)
           .map_err(|report| napi::Error::from_reason(report.to_string()))?;
-        plugins.push(enable_wasm_loading_plugin(
-          wasm_loading_type.as_str().into(),
-        ));
+        let wasm_loading_type: WasmLoadingType = wasm_loading_type.as_str().into();
+        plugins.push(enable_wasm_loading_plugin(&wasm_loading_type));
       }
       BuiltinPluginName::FetchCompileAsyncWasmPlugin => {
         plugins.push(FetchCompileAsyncWasmPlugin::default().boxed());
@@ -580,7 +582,7 @@ impl<'a> BuiltinPlugin<'a> {
             .map_err(|report| napi::Error::from_reason(report.to_string()))?
             .into();
         plugins.push(
-          SourceMapDevToolModuleOptionsPlugin::new(SourceMapDevToolModuleOptionsPluginOptions {
+          SourceMapDevToolModuleOptionsPlugin::new(&SourceMapDevToolModuleOptionsPluginOptions {
             module: options.module,
             cheap: !options.columns,
           })
@@ -594,7 +596,7 @@ impl<'a> BuiltinPlugin<'a> {
             .map_err(|report| napi::Error::from_reason(report.to_string()))?
             .into();
         plugins.push(
-          SourceMapDevToolModuleOptionsPlugin::new(SourceMapDevToolModuleOptionsPluginOptions {
+          SourceMapDevToolModuleOptionsPlugin::new(&SourceMapDevToolModuleOptionsPluginOptions {
             module: options.module,
             cheap: !options.columns,
           })

crates/rspack_binding_api/src/swc.rs

@@ -66,7 +66,7 @@ fn _transform(source: String, options: String) -> napi::Result<TransformOutput>
         options.filename.clone().into(),
       ))),
       comments,
-      options,
+      &options,
       Some(module_source_map_kind),
       |_, _| {},
       |_| noop_pass(),

crates/rspack_browser/src/oneshot.rs

@@ -24,9 +24,7 @@ pub fn channel<T>() -> (Sender<T>, Receiver<T>) {
     inner: inner.clone(),
   };
 
-  let rx = Receiver {
-    inner: inner.clone(),
-  };
+  let rx = Receiver { inner };
 
   (tx, rx)
 }

crates/rspack_cacheable_macros/src/cacheable/impl.rs

@@ -48,7 +48,7 @@ impl VisitMut for FieldAttrVisitor {
 }
 
 /// impl #[cacheable] without with args
-pub fn impl_cacheable(tokens: TokenStream, args: CacheableArgs) -> TokenStream {
+pub fn impl_cacheable(tokens: TokenStream, args: &CacheableArgs) -> TokenStream {
   let mut input = parse_macro_input!(tokens as Item);
 
   let mut visitor = FieldAttrVisitor::default();

crates/rspack_cacheable_macros/src/cacheable/mod.rs

@@ -16,7 +16,7 @@ pub fn cacheable(
   if args.with.is_some() {
     impl_cacheable_with(tokens, args)
   } else {
-    impl_cacheable(tokens, args)
+    impl_cacheable(tokens, &args)
   }
 }
 

crates/rspack_cacheable_test/tests/with/as_preset/rspack_sources.rs

@@ -7,8 +7,8 @@ struct Data(#[cacheable(with=AsPreset)] BoxSource);
 
 #[test]
 fn test_rspack_source() {
-  fn test_data(data: Data) {
-    let bytes = to_bytes(&data, &()).unwrap();
+  fn test_data(data: &Data) {
+    let bytes = to_bytes(data, &()).unwrap();
     let new_data: Data = from_bytes(&bytes, &()).unwrap();
     assert_eq!(data.0.buffer(), new_data.0.buffer());
     assert_eq!(
@@ -17,6 +17,6 @@ fn test_rspack_source() {
     );
   }
 
-  test_data(Data(RawBufferSource::from("123".as_bytes()).boxed()));
-  test_data(Data(RawStringSource::from_static("123").boxed()));
+  test_data(&Data(RawBufferSource::from("123".as_bytes()).boxed()));
+  test_data(&Data(RawStringSource::from_static("123").boxed()));
 }