fix: mf should correctly hoist modules (#11743)

Author: ahabhgk

crates/rspack_plugin_mf/src/container/hoist_container_references_plugin.rs

@@ -20,7 +20,7 @@ use std::{
 use async_trait::async_trait;
 use rspack_core::{
   Compilation, CompilationOptimizeChunks, CompilerCompilation, Dependency, DependencyId,
-  ModuleIdentifier, Plugin, incremental::Mutation,
+  ModuleIdentifier, Plugin, RuntimeSpec, incremental::Mutation,
 };
 use rspack_error::Result;
 use rspack_hook::{plugin, plugin_hook};
@@ -206,7 +206,8 @@ async fn optimize_chunks(&self, compilation: &mut Compilation) -> Result<Option<
     let runtime_chunks = compilation
       .chunk_graph
       .get_module_runtimes_iter(*module, &compilation.chunk_by_ukey)
-      .filter_map(|runtime_spec| entries.get(&runtime_spec).copied())
+      .flat_map(|runtime| runtime.iter())
+      .filter_map(|runtime| entries.get(&RuntimeSpec::from_iter([*runtime])).copied())
       .collect::<Vec<_>>();
     for runtime_chunk in runtime_chunks {
       if !compilation

tests/rspack-test/watchCases/async-modules/top-level-await/0/case1/index.js

@@ -8,7 +8,6 @@ it("should have correct value", async () => {
   expect(globalThis.case1).toBe(parseInt(WATCH_STEP, 10))
   const content = await fs.promises.readFile(__filename, "utf-8")
   const result = WATCH_STEP === "1";
-  debugger
   expect(isAsyncModule(content, "./case1/index.js")).toBe(result)
   expect(isAsyncModule(content, "./case1/a.js")).toBe(result)
   expect(isAsyncModule(content, "./case1/b.js")).toBe(result)

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/0/a.js

@@ -0,0 +1,8 @@
+export function Test(count) {
+  return <div>{count}</div>;
+}
+
+it("should not throw error", async () => {
+  expect(Test(0).props.children).toBe(0);
+  await import("./main");
+})

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/0/b.js

@@ -0,0 +1,8 @@
+export function Test(count) {
+  return <div>{count}</div>;
+}
+
+it("should not throw error", async () => {
+  expect(Test(0).props.children).toBe(0);
+  await import("./main");
+})

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/0/getWorker.js

@@ -0,0 +1,5 @@
+export default () => {
+	const worker = new Worker(new URL("./worker", import.meta.url));
+	worker.testName = `test worker ${WATCH_STEP}`;
+	return worker;
+};

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/0/main.js

@@ -0,0 +1,5 @@
+import getWorker from "./getWorker";
+
+it("should have correct value", () => {
+  expect(getWorker().testName).toBe("test worker 0");
+})

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/0/worker.js

@@ -0,0 +1,2 @@
+const x = {};
+export { x };

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/1/main.js

@@ -0,0 +1,5 @@
+import getWorker from "./getWorker";
+
+it("should rebuild successfully", () => {
+  expect(getWorker().testName).toBe("test worker 1");
+})

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/rspack.config.js

@@ -0,0 +1,60 @@
+const rspack = require("@rspack/core");
+const ReactRefreshPlugin = require("@rspack/plugin-react-refresh");
+
+/** @type {import("webpack").Configuration} */
+module.exports = {
+	entry: {
+		a: "./a.js",
+		b: "./b.js",
+	},
+	output: {
+		filename: "[name].js",
+	},
+	target: "web",
+	optimization: {
+		splitChunks: {
+			chunks: "all",
+			cacheGroups: {
+				defaultVendors: {
+					name: "vendors", // add name for defaultVendors, need a specific name to run it at test.config.js findBundle
+					reuseExistingChunk: true,
+					test: /[\\/]node_modules[\\/]/i,
+					priority: -10
+				}
+			},
+		}
+	},
+	module: {
+		rules: [
+			{
+				test: /\.js/,
+				use: [{
+					loader: 'builtin:swc-loader',
+					options: {
+						jsc: {
+							parser: {
+								jsx: true,
+								syntax: 'ecmascript'
+							},
+							transform: {
+								react: {
+									development: true,
+									refresh: true,
+									runtime: 'automatic'
+								}
+							},
+							target: "es2022"
+						},
+					}
+				}],
+			}
+		]
+	},
+	plugins: [
+		new rspack.container.ModuleFederationPlugin({
+			name: "test",
+			shareStrategy: "loaded-first"
+		}),
+		new ReactRefreshPlugin() // Need this to trigger hoisting (hoist_container_references_plugin.rs)
+	]
+};

tests/rspack-test/watchCases/chunks/mf-hoisting-multi-entries/test.config.js

@@ -0,0 +1,8 @@
+module.exports = {
+	findBundle(i, config, step) {
+		return ["vendors.js", "a.js", "b.js"]
+	},
+	moduleScope(scope) {
+		scope.window.document.defaultView = scope.window;
+	}
+};