perf: Enable more Clippy performance checks and reduce redundant clones (#13069)

Enable clippy perf rules

Author: hardfist

Cargo.toml

@@ -508,6 +508,9 @@ verbose_file_reads              = "warn"
 #mem_forget                      = "warn"
 
 # performance
+iter_filter_is_ok       = "warn"
+iter_filter_is_some     = "warn"
+iter_with_drain         = "warn"
 redundant_clone         = "warn"
 regex_creation_in_loops = "warn"
 

crates/rspack_binding_api/src/compilation/diagnostics.rs

@@ -183,7 +183,7 @@ impl Diagnostics {
       i += 1;
     }
 
-    for diagnostic in to_insert.drain(..) {
+    for diagnostic in to_insert {
       new_diagnostics.push(diagnostic);
     }
 

crates/rspack_core/src/artifacts/build_chunk_graph_artifact.rs

@@ -244,16 +244,16 @@ impl ArtifactExt for BuildChunkGraphArtifact {
   fn recover(_incremental: &crate::incremental::Incremental, new: &mut Self, old: &mut Self) {
     new.code_splitter = mem::take(&mut old.code_splitter);
     rayon::scope(|s| {
-      s.spawn(|_| new.chunk_by_ukey = old.chunk_by_ukey.clone());
-      s.spawn(|_| new.chunk_graph = old.chunk_graph.clone());
-      s.spawn(|_| new.chunk_group_by_ukey = old.chunk_group_by_ukey.clone());
+      s.spawn(|_| new.chunk_by_ukey.clone_from(&old.chunk_by_ukey));
+      s.spawn(|_| new.chunk_graph.clone_from(&old.chunk_graph));
+      s.spawn(|_| new.chunk_group_by_ukey.clone_from(&old.chunk_group_by_ukey));
 
-      s.spawn(|_| new.async_entrypoints = old.async_entrypoints.clone());
-      s.spawn(|_| new.named_chunk_groups = old.named_chunk_groups.clone());
-      s.spawn(|_| new.named_chunks = old.named_chunks.clone());
+      s.spawn(|_| new.async_entrypoints.clone_from(&old.async_entrypoints));
+      s.spawn(|_| new.named_chunk_groups.clone_from(&old.named_chunk_groups));
+      s.spawn(|_| new.named_chunks.clone_from(&old.named_chunks));
       s.spawn(|_| {
-        new.entrypoints = old.entrypoints.clone();
-        new.module_idx = old.module_idx.clone();
+        new.entrypoints.clone_from(&old.entrypoints);
+        new.module_idx.clone_from(&old.module_idx);
       });
     });
   }

crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs

@@ -1160,6 +1160,6 @@ impl ChunkGraph {
 
         None
       })
-      .unwrap_or(module.source_types(module_graph).iter().copied().collect())
+      .unwrap_or_else(|| module.source_types(module_graph).iter().copied().collect())
   }
 }

crates/rspack_core/src/compilation/assign_runtime_ids/mod.rs

@@ -27,7 +27,7 @@ impl PassExt for AssignRuntimeIdsPass {
           Some(EntryRuntime::String(s)) => Some(s.to_owned()),
           _ => None,
         })
-        .or(entrypoint.name().map(|n| n.to_string()));
+        .or_else(|| entrypoint.name().map(|n| n.to_string()));
       if let (Some(runtime), Some(chunk)) = (
         runtime,
         chunk_by_ukey.get(&entrypoint.get_runtime_chunk(chunk_group_by_ukey)),

crates/rspack_core/src/compilation/build_chunk_graph/incremental.rs

@@ -460,7 +460,7 @@ impl CodeSplitter {
 
     let cgi = self.chunk_group_infos.expect_get_mut(&cgi_ukey);
     let group_ukey = cgi.chunk_group;
-    cgi.skipped_items = cache_result.skipped_modules.clone();
+    cgi.skipped_items.clone_from(&cache_result.skipped_modules);
 
     let chunk_graph = &mut compilation.build_chunk_graph_artifact.chunk_graph;
     for module in &cache_result.modules {
@@ -475,8 +475,12 @@ impl CodeSplitter {
       .build_chunk_graph_artifact
       .chunk_group_by_ukey
       .expect_get_mut(&group_ukey);
-    group.module_pre_order_indices = cache_result.pre_order_indices.clone();
-    group.module_post_order_indices = cache_result.post_order_indices.clone();
+    group
+      .module_pre_order_indices
+      .clone_from(&cache_result.pre_order_indices);
+    group
+      .module_post_order_indices
+      .clone_from(&cache_result.post_order_indices);
 
     for block in &cache_result.outgoings {
       self.make_chunk_group(

crates/rspack_core/src/compilation/build_module_graph/graph_updater/cutout/mod.rs

@@ -132,13 +132,11 @@ impl Cutout {
       }
     }
     // add entry dependencies
-    for dep in next_entry_dependencies
-      .difference(&entry_dependencies)
-      .copied()
-      .collect::<Vec<_>>()
-    {
-      build_deps.insert((dep, None));
-      entry_dependencies.insert(dep);
+    for dep in next_entry_dependencies.iter() {
+      if !entry_dependencies.contains(dep) {
+        build_deps.insert((*dep, None));
+        entry_dependencies.insert(*dep);
+      }
     }
     artifact.entry_dependencies = entry_dependencies;
 

crates/rspack_core/src/compilation/build_module_graph/graph_updater/repair/build.rs

@@ -182,7 +182,7 @@ impl Task<TaskContext> for BuildResultTask {
 
     {
       let mgm = module_graph.module_graph_module_by_identifier_mut(&module.identifier());
-      mgm.all_dependencies = all_dependencies.clone();
+      mgm.all_dependencies.clone_from(&all_dependencies);
     }
 
     let module_identifier = module.identifier();

crates/rspack_core/src/compilation/build_module_graph/graph_updater/repair/lazy.rs

@@ -28,13 +28,10 @@ impl Task<TaskContext> for ProcessUnlazyDependenciesTask {
       .module_to_lazy_make
       .get_lazy_dependencies(&original_module_identifier)
       .expect("only module has lazy dependencies should run into ProcessUnlazyDependenciesTask");
-    let requested_deps: Vec<DependencyId> = lazy_dependencies
-      .requested_lazy_dependencies(&forwarded_ids)
-      .into_iter()
-      .collect();
 
     let module_graph = &mut context.artifact.module_graph;
-    let dependencies_to_process: Vec<DependencyId> = requested_deps
+    let dependencies_to_process: Vec<DependencyId> = lazy_dependencies
+      .requested_lazy_dependencies(&forwarded_ids)
       .into_iter()
       .filter(|dep| {
         let dep = module_graph.dependency_by_id_mut(dep);

crates/rspack_core/src/compilation/build_module_graph/module_executor/entry.rs

@@ -46,7 +46,7 @@ impl Task<ExecutorTaskContext> for EntryTask {
         // not exist, generate a new dependency
         let dep = Box::new(LoaderImportDependency::new(
           meta.request.clone(),
-          origin_module_context.unwrap_or(Context::from("")),
+          origin_module_context.unwrap_or_else(|| Context::from("")),
         ));
         let dep_id = *dep.id();