refactor: remove unnecessary clone

Author: hardfist

crates/rspack_core/src/chunk.rs

@@ -329,7 +329,9 @@ impl Chunk {
       group.insert_chunk(new_chunk.ukey, self.ukey);
       new_chunk.add_group(group.ukey);
     }
-    new_chunk.id_name_hints.extend(self.id_name_hints.clone());
+    new_chunk
+      .id_name_hints
+      .extend(self.id_name_hints.iter().cloned());
     new_chunk.runtime.extend(&self.runtime);
   }
 
@@ -618,12 +620,13 @@ impl Chunk {
       }
     }
 
-    for chunk_group_ukey in initial_queue.clone().iter() {
+    let initial_keys: Vec<_> = initial_queue.iter().copied().collect();
+    for chunk_group_ukey in initial_keys {
       add_to_queue(
         chunk_group_by_ukey,
         &mut queue,
         &mut initial_queue,
-        chunk_group_ukey,
+        &chunk_group_ukey,
       );
     }
 
@@ -895,13 +898,8 @@ impl Chunk {
     if include_direct_children {
       for chunk_ukey in self
         .get_sorted_groups_iter(&compilation.chunk_group_by_ukey)
-        .filter_map(|chunk_group_ukey| {
-          compilation
-            .chunk_group_by_ukey
-            .get(chunk_group_ukey)
-            .map(|g| g.chunks.clone())
-        })
-        .flatten()
+        .filter_map(|chunk_group_ukey| compilation.chunk_group_by_ukey.get(chunk_group_ukey))
+        .flat_map(|g| g.chunks.iter().copied())
       {
         add_child_ids_task.push((chunk_ukey, ChunkGroupOrderKey::Prefetch));
         add_child_ids_task.push((chunk_ukey, ChunkGroupOrderKey::Preload));

crates/rspack_core/src/compilation/build_chunk_graph/incremental.rs

@@ -310,7 +310,7 @@ impl CodeSplitter {
 
       for chunk_ukey in &cgm.chunks {
         let chunk = compilation.chunk_by_ukey.expect_get(chunk_ukey);
-        chunk_groups.extend(chunk.groups().clone());
+        chunk_groups.extend(chunk.groups().iter().copied());
       }
     }
     for group in chunk_groups {

crates/rspack_core/src/compiler/rebuild.rs

@@ -67,7 +67,7 @@ impl Compiler {
       removed_files.extend(deleted_files.iter().map(|files| Path::new(files).into()));
 
       let mut all_files = modified_files.clone();
-      all_files.extend(removed_files.clone());
+      all_files.extend(removed_files.iter().cloned());
 
       self.plugin_driver.clear_cache(self.compilation.id());
 

crates/rspack_core/src/concatenated_module.rs

@@ -900,7 +900,7 @@ impl Module for ConcatenatedModule {
         continue;
       };
       if info.has_ast {
-        all_used_names.extend(info.all_used_names.clone());
+        all_used_names.extend(info.all_used_names.iter().cloned());
       }
     }
 

crates/rspack_core/src/utils/runtime.rs

@@ -18,7 +18,7 @@ pub fn get_entry_runtime(
   if let Some(depend_on) = &options.depend_on {
     let mut result: RuntimeSpec = Default::default();
     let mut queue = vec![];
-    queue.extend(depend_on.clone());
+    queue.extend(depend_on.iter().cloned());
 
     let mut visited = HashSet::<String>::default();