fix: align amd option behavior with webpack (#9011)

Author: nilptr

crates/rspack_plugin_javascript/src/dependency/amd/amd_require_dependency.rs

@@ -81,7 +81,7 @@ impl DependencyTemplate for AMDRequireDependency {
     {
       let start_block = promise + ".then(function() {";
       let end_block = format!(
-        ";}})['catch']{}",
+        ";}})['catch']({})",
         RuntimeGlobals::UNCAUGHT_ERROR_HANDLER.name()
       );
       code_generatable_context

crates/rspack_plugin_javascript/src/parser_plugin/api_plugin.rs

@@ -355,7 +355,6 @@ impl JavascriptParserPlugin for APIPlugin {
         not_supported_expr!(is_require_extensions, expr, "require.extensions");
         not_supported_expr!(is_require_config, expr, "require.config");
         not_supported_expr!(is_require_version, expr, "require.version");
-        not_supported_expr!(is_require_amd, expr, "require.amd");
         not_supported_expr!(is_require_include, expr, "require.include");
         not_supported_expr!(is_require_onerror, expr, "require.onError");
         not_supported_expr!(is_require_main_require, expr, "require.main.require");

crates/rspack_plugin_javascript/src/parser_plugin/esm_detection_parser_plugin.rs

@@ -43,6 +43,11 @@ impl ESMDetectionParserPlugin {
   }
 }
 
+// nonHarmonyIdentifiers
+fn is_non_esm_identifier(name: &str) -> bool {
+  name == "exports" || name == "define"
+}
+
 // Port from https://github.com/webpack/webpack/blob/main/lib/dependencies/HarmonyDetectionParserPlugin.js
 impl JavascriptParserPlugin for ESMDetectionParserPlugin {
   fn program(&self, parser: &mut JavascriptParser, ast: &Program) -> Option<bool> {
@@ -97,17 +102,35 @@ impl JavascriptParserPlugin for ESMDetectionParserPlugin {
     expr: &UnaryExpr,
     for_name: &str,
   ) -> Option<BasicEvaluatedExpression> {
-    (parser.is_esm && for_name == "exports")
+    (parser.is_esm && is_non_esm_identifier(for_name))
       .then(|| BasicEvaluatedExpression::with_range(expr.span().real_lo(), expr.span_hi().0))
   }
 
+  fn r#typeof(
+    &self,
+    parser: &mut JavascriptParser,
+    _expr: &UnaryExpr,
+    for_name: &str,
+  ) -> Option<bool> {
+    (parser.is_esm && is_non_esm_identifier(for_name)).then_some(true)
+  }
+
   fn identifier(
     &self,
     parser: &mut JavascriptParser,
     _ident: &Ident,
     for_name: &str,
   ) -> Option<bool> {
-    (parser.is_esm && for_name == "exports").then_some(true)
+    (parser.is_esm && is_non_esm_identifier(for_name)).then_some(true)
+  }
+
+  fn call(
+    &self,
+    parser: &mut JavascriptParser,
+    _expr: &swc_core::ecma::ast::CallExpr,
+    for_name: &str,
+  ) -> Option<bool> {
+    (parser.is_esm && is_non_esm_identifier(for_name)).then_some(true)
   }
 }
 

packages/rspack-test-tools/tests/__snapshots__/Defaults.test.js.snap

@@ -340,6 +340,26 @@ Object {
   resolve: Object {
     aliasFields: Array [],
     byDependency: Object {
+      amd: Object {
+        aliasFields: Array [
+          browser,
+        ],
+        conditionNames: Array [
+          require,
+          module,
+          ...,
+        ],
+        extensions: Array [
+          .js,
+          .json,
+          .wasm,
+        ],
+        mainFields: Array [
+          browser,
+          module,
+          ...,
+        ],
+      },
       commonjs: Object {
         aliasFields: Array [
           browser,