fix: correct favicon path when output.publicPath is set to auto (#8415)

Author: inottn

crates/rspack_plugin_html/src/asset.rs

@@ -111,21 +111,17 @@ impl HtmlPluginAssets {
         favicon_relative_path.to_string_lossy().to_string().as_str(),
       ));
 
-      let fake_html_file_name = compilation
-        .get_path(
-          html_file_name,
-          PathData::default().filename(output_path.as_str()),
-        )
-        .always_ok();
-
       if favicon_path.to_str().unwrap_or_default().is_empty() {
-        favicon_path = compilation
-          .options
-          .output
-          .path
-          .as_std_path()
-          .join(favicon_relative_path)
-          .relative(PathBuf::from(fake_html_file_name).join(".."));
+        let fake_html_file_name = compilation
+          .get_path(
+            html_file_name,
+            PathData::default().filename(output_path.as_str()),
+          )
+          .always_ok();
+        let output_path = compilation.options.output.path.as_std_path();
+        favicon_path = output_path
+          .relative(output_path.join(fake_html_file_name).join(".."))
+          .join(favicon_relative_path);
       } else {
         favicon_path.push(favicon_relative_path);
       }

packages/rspack-test-tools/tests/configCases/builtins/html-favicon-absolute-publicpath-auto/favicon.ico

@@ -0,0 +1,11 @@
+const fs = require("fs");
+const path = require("path");
+
+it("html favicon with absolute path and public path", () => {
+	const faviconPath = path.join(__dirname, "./favicon.ico");
+	expect(fs.existsSync(faviconPath)).toBe(true);
+
+	const htmlPath = path.join(__dirname, "./index.html");
+	const htmlContent = fs.readFileSync(htmlPath, "utf-8");
+	expect(htmlContent).toContain('<link href="favicon.ico" rel="icon">');
+});

packages/rspack-test-tools/tests/configCases/builtins/html-favicon-absolute-publicpath-auto/index.js

@@ -0,0 +1,14 @@
+const path = require("path");
+const { rspack } = require("@rspack/core");
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	output: {
+	    publicPath: "auto",
+	},
+	plugins: [
+		new rspack.HtmlRspackPlugin({
+			favicon: path.resolve(__dirname, "favicon.ico")
+		})
+	]
+};

packages/rspack-test-tools/tests/configCases/builtins/html-favicon-absolute-publicpath-auto/rspack.config.js

@@ -0,0 +1,11 @@
+const fs = require("fs");
+const path = require("path");
+
+it("html favicon with absolute path and public path", () => {
+	const faviconPath = path.join(__dirname, "./favicon.ico");
+	expect(fs.existsSync(faviconPath)).toBe(true);
+
+	const htmlPath = path.join(__dirname, "./index.html");
+	const htmlContent = fs.readFileSync(htmlPath, "utf-8");
+	expect(htmlContent).toContain('<link href="favicon.ico" rel="icon">');
+});

packages/rspack-test-tools/tests/configCases/builtins/html-favicon-relative-publicpath-auto/favicon.ico

@@ -0,0 +1,14 @@
+const path = require("path");
+const { rspack } = require("@rspack/core");
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	output: {
+	    publicPath: "auto",
+	},
+	plugins: [
+		new rspack.HtmlRspackPlugin({
+			favicon: "favicon.ico"
+		})
+	]
+};