feat: using runtime_template to support output.environment (#9052)

- Introduced new runtime template in `runtime_template.rs` to support enhanced functionality.
- Adjusted raw output handling in `raw_output.rs` for improved performance.
- Updated various snapshot tests to reflect changes in output and ensure consistency.

These changes aim to improve the overall type safety and reduce production size.

Author: GiveMe-A-Name

crates/node_binding/binding.d.ts

@@ -1382,6 +1382,16 @@ export interface RawEnvironment {
   const?: boolean
   arrowFunction?: boolean
   nodePrefixForCoreModules?: boolean
+  asyncFunction?: boolean
+  bigIntLiteral?: boolean
+  destructuring?: boolean
+  document?: boolean
+  dynamicImport?: boolean
+  forOf?: boolean
+  globalThis?: boolean
+  module?: boolean
+  optionalChaining?: boolean
+  templateLiteral?: boolean
 }
 
 export interface RawEvalDevToolModulePluginOptions {

crates/rspack/src/builder/mod.rs

@@ -2247,6 +2247,16 @@ impl OutputOptionsBuilder {
       r#const: tp.and_then(|t| t.r#const),
       arrow_function: tp.and_then(|t| t.arrow_function),
       node_prefix_for_core_modules: tp.and_then(|t| t.node_prefix_for_core_modules),
+      async_function: tp.and_then(|t| t.async_function),
+      big_int_literal: tp.and_then(|t| t.big_int_literal),
+      destructuring: tp.and_then(|t| t.destructuring),
+      for_of: tp.and_then(|t| t.for_of),
+      global_this: tp.and_then(|t| t.global_this),
+      optional_chaining: tp.and_then(|t| t.optional_chaining),
+      document: tp.and_then(|t| t.document),
+      dynamic_import: tp.and_then(|t| t.dynamic_import),
+      template_literal: tp.and_then(|t| t.template_literal),
+      module: tp.and_then(|t| t.module),
     };
 
     OutputOptions {

crates/rspack_binding_values/src/raw_options/raw_output.rs

@@ -46,6 +46,16 @@ pub struct RawEnvironment {
   pub r#const: Option<bool>,
   pub arrow_function: Option<bool>,
   pub node_prefix_for_core_modules: Option<bool>,
+  pub async_function: Option<bool>,
+  pub big_int_literal: Option<bool>,
+  pub destructuring: Option<bool>,
+  pub document: Option<bool>,
+  pub dynamic_import: Option<bool>,
+  pub for_of: Option<bool>,
+  pub global_this: Option<bool>,
+  pub module: Option<bool>,
+  pub optional_chaining: Option<bool>,
+  pub template_literal: Option<bool>,
 }
 
 impl From<RawEnvironment> for Environment {
@@ -54,6 +64,16 @@ impl From<RawEnvironment> for Environment {
       r#const: value.r#const,
       arrow_function: value.arrow_function,
       node_prefix_for_core_modules: value.node_prefix_for_core_modules,
+      async_function: value.async_function,
+      big_int_literal: value.big_int_literal,
+      destructuring: value.destructuring,
+      document: value.document,
+      dynamic_import: value.dynamic_import,
+      for_of: value.for_of,
+      global_this: value.global_this,
+      module: value.module,
+      optional_chaining: value.optional_chaining,
+      template_literal: value.template_literal,
     }
   }
 }

crates/rspack_core/src/compiler/compilation.rs

@@ -51,7 +51,8 @@ use crate::{
   DependencyType, Entry, EntryData, EntryOptions, EntryRuntime, Entrypoint, ExecuteModuleId,
   Filename, ImportVarMap, LocalFilenameFn, Logger, ModuleFactory, ModuleGraph, ModuleGraphPartial,
   ModuleIdentifier, ModuleIdsArtifact, PathData, ResolverFactory, RuntimeGlobals, RuntimeModule,
-  RuntimeSpecMap, SharedPluginDriver, SideEffectsOptimizeArtifact, SourceType, Stats,
+  RuntimeSpecMap, RuntimeTemplate, SharedPluginDriver, SideEffectsOptimizeArtifact, SourceType,
+  Stats,
 };
 
 pub type BuildDependency = (
@@ -180,6 +181,7 @@ pub struct Compilation {
   pub loader_resolver_factory: Arc<ResolverFactory>,
   pub named_chunks: HashMap<String, ChunkUkey>,
   pub named_chunk_groups: HashMap<String, ChunkGroupUkey>,
+  pub runtime_template: RuntimeTemplate,
 
   // artifact for infer_async_modules_plugin
   pub async_modules_artifact: AsyncModulesArtifact,
@@ -276,6 +278,7 @@ impl Compilation {
     Self {
       id: CompilationId::new(),
       hot_index: 0,
+      runtime_template: RuntimeTemplate::new(options.output.environment),
       records,
       options,
       other_module_graph: None,

crates/rspack_core/src/init_fragment.rs

@@ -157,6 +157,7 @@ fn first<C>(fragments: Vec<Box<dyn InitFragment<C>>>) -> Box<dyn InitFragment<C>
 pub trait InitFragmentRenderContext {
   fn add_runtime_requirements(&mut self, requirement: RuntimeGlobals);
   fn runtime_condition_expression(&mut self, runtime_condition: &RuntimeCondition) -> String;
+  fn returning_function(&self, return_value: &str, args: &str) -> String;
 }
 
 pub trait InitFragment<C>: IntoAny + DynHash + DynClone + Debug + Sync + Send {
@@ -269,6 +270,13 @@ impl InitFragmentRenderContext for GenerateContext<'_> {
       self.runtime_requirements,
     )
   }
+
+  fn returning_function(&self, return_value: &str, args: &str) -> String {
+    self
+      .compilation
+      .runtime_template
+      .returning_function(return_value, args)
+  }
 }
 
 pub struct ChunkRenderContext;
@@ -281,6 +289,10 @@ impl InitFragmentRenderContext for ChunkRenderContext {
   fn runtime_condition_expression(&mut self, _runtime_condition: &RuntimeCondition) -> String {
     unreachable!("should not call runtime condition expression in chunk render context")
   }
+
+  fn returning_function(&self, _return_value: &str, _args: &str) -> String {
+    unreachable!("should not call returning function in chunk render context")
+  }
 }
 
 #[derive(Debug, Clone, Hash)]
@@ -359,7 +371,11 @@ impl<C: InitFragmentRenderContext> InitFragment<C> for ESMExportInitFragment {
         .iter()
         .map(|s| {
           let prop = property_name(&s.0)?;
-          Ok(format!("{}: function() {{ return {}; }}", prop, s.1))
+          Ok(format!(
+            "{}: {}",
+            prop,
+            context.returning_function(&s.1, "")
+          ))
         })
         .collect::<Result<Vec<_>>>()?
         .join(",\n  ")

crates/rspack_core/src/lib.rs

@@ -18,6 +18,8 @@ mod fake_namespace_object;
 mod template;
 pub use fake_namespace_object::*;
 pub use template::Template;
+mod runtime_template;
+pub use runtime_template::*;
 mod module_profile;
 pub use module_profile::*;
 use rspack_collections::Database;

crates/rspack_core/src/options/output.rs

@@ -468,11 +468,21 @@ pub struct LibraryCustomUmdObject {
   pub root: Option<Vec<String>>,
 }
 
-#[derive(Debug)]
+#[derive(Debug, Copy, Clone)]
 pub struct Environment {
   pub r#const: Option<bool>,
   pub arrow_function: Option<bool>,
   pub node_prefix_for_core_modules: Option<bool>,
+  pub async_function: Option<bool>,
+  pub big_int_literal: Option<bool>,
+  pub destructuring: Option<bool>,
+  pub document: Option<bool>,
+  pub dynamic_import: Option<bool>,
+  pub for_of: Option<bool>,
+  pub global_this: Option<bool>,
+  pub module: Option<bool>,
+  pub optional_chaining: Option<bool>,
+  pub template_literal: Option<bool>,
 }
 
 impl Environment {
@@ -487,4 +497,44 @@ impl Environment {
   pub fn supports_node_prefix_for_core_modules(&self) -> bool {
     self.node_prefix_for_core_modules.unwrap_or_default()
   }
+
+  pub fn supports_async_function(&self) -> bool {
+    self.async_function.unwrap_or_default()
+  }
+
+  pub fn supports_big_int_literal(&self) -> bool {
+    self.big_int_literal.unwrap_or_default()
+  }
+
+  pub fn supports_destructuring(&self) -> bool {
+    self.destructuring.unwrap_or_default()
+  }
+
+  pub fn supports_document(&self) -> bool {
+    self.document.unwrap_or_default()
+  }
+
+  pub fn supports_dynamic_import(&self) -> bool {
+    self.dynamic_import.unwrap_or_default()
+  }
+
+  pub fn supports_for_of(&self) -> bool {
+    self.for_of.unwrap_or_default()
+  }
+
+  pub fn supports_global_this(&self) -> bool {
+    self.global_this.unwrap_or_default()
+  }
+
+  pub fn supports_module(&self) -> bool {
+    self.module.unwrap_or_default()
+  }
+
+  pub fn supports_optional_chaining(&self) -> bool {
+    self.optional_chaining.unwrap_or_default()
+  }
+
+  pub fn supports_template_literal(&self) -> bool {
+    self.template_literal.unwrap_or_default()
+  }
 }

crates/rspack_core/src/runtime_template.rs

@@ -0,0 +1,37 @@
+use std::fmt::Debug;
+
+use crate::Environment;
+
+pub struct RuntimeTemplate {
+  environment: Environment,
+}
+
+impl Debug for RuntimeTemplate {
+  fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+    f.debug_struct("runtime_template")
+      .field("environment", &self.environment)
+      .finish()
+  }
+}
+
+impl RuntimeTemplate {
+  pub fn new(environment: Environment) -> Self {
+    Self { environment }
+  }
+
+  pub fn returning_function(&self, return_value: &str, args: &str) -> String {
+    if self.environment.supports_arrow_function() {
+      format!("({args}) => ({return_value})")
+    } else {
+      format!("function({args}) {{ return {return_value}; }}")
+    }
+  }
+
+  pub fn basic_function(&self, args: &str, body: &str) -> String {
+    if self.environment.supports_arrow_function() {
+      format!("({args}) => {{\n {body} \n}}")
+    } else {
+      format!("function({args}) {{\n {body} \n}}")
+    }
+  }
+}

packages/rspack-test-tools/tests/__snapshots__/NewCodeSplitting-stats-output.test.js.snap

@@ -98,7 +98,7 @@ Rspack x.x.x compiled successfully in X s
 
 exports[`new code splitting stats output new code splitting stats output/filename should print correct stats for: NewCodeSplittingStatsOutput 1`] = `
 asset 909.xxxx.js 9.14 KiB [emitted] (name: main)
-asset 521.xxxx.js 337 bytes [emitted]
+asset 521.xxxx.js 322 bytes [emitted]
 runtime modules 7.54 KiB 11 modules
 cacheable modules 70 bytes
   ./index.js 38 bytes [built] [code generated]
@@ -219,7 +219,7 @@ Rspack compiled with 1 error
 
 exports[`new code splitting stats output new code splitting stats output/named-chunk-group should print correct stats for: NewCodeSplittingStatsOutput 1`] = `
 Entrypoint main 9.13 KiB = main.js
-Chunk Group cimanyd 337 bytes = cimanyd.js
+Chunk Group cimanyd 322 bytes = cimanyd.js
 `;
 
 exports[`new code splitting stats output new code splitting stats output/nonexistent-import-source-error should print correct stats for: NewCodeSplittingStatsOutput 1`] = `
@@ -438,7 +438,7 @@ Rspack x.x.x compiled successfully in X s
 `;
 
 exports[`new code splitting stats output new code splitting stats output/simple-export should print correct stats for: NewCodeSplittingStatsOutput 1`] = `
-asset bundle.js 1.71 KiB [emitted] (name: main)
+asset bundle.js 1.69 KiB [emitted] (name: main)
 runtime modules 677 bytes 3 modules
 ./index.js 26 bytes [built] [code generated]
 Rspack x.x.x compiled successfully in X s

packages/rspack-test-tools/tests/__snapshots__/StatsOutput.test.js.snap

@@ -98,7 +98,7 @@ Rspack x.x.x compiled successfully in X s
 
 exports[`statsOutput statsOutput/filename should print correct stats for 1`] = `
 asset 909.xxxx.js 9.14 KiB [emitted] (name: main)
-asset 521.xxxx.js 337 bytes [emitted]
+asset 521.xxxx.js 322 bytes [emitted]
 runtime modules 7.54 KiB 11 modules
 cacheable modules 70 bytes
   ./index.js 38 bytes [built] [code generated]
@@ -219,7 +219,7 @@ Rspack compiled with 1 error
 
 exports[`statsOutput statsOutput/named-chunk-group should print correct stats for 1`] = `
 Entrypoint main 9.13 KiB = main.js
-Chunk Group cimanyd 337 bytes = cimanyd.js
+Chunk Group cimanyd 322 bytes = cimanyd.js
 `;
 
 exports[`statsOutput statsOutput/nonexistent-import-source-error should print correct stats for 1`] = `
@@ -438,7 +438,7 @@ Rspack x.x.x compiled successfully in X s
 `;
 
 exports[`statsOutput statsOutput/simple-export should print correct stats for 1`] = `
-asset bundle.js 1.71 KiB [emitted] (name: main)
+asset bundle.js 1.69 KiB [emitted] (name: main)
 runtime modules 677 bytes 3 modules
 ./index.js 26 bytes [built] [code generated]
 Rspack x.x.x compiled successfully in X s