fix(css): should generate css assets even if the imported css file is empty (#2747)

hyf0 · web-flow · commit 22c9b5bf1309 · 2023-04-13T10:38:38.000Z
* fix(css): should generate css assets even if the imported css file is empty

* Tweak
diff --git a/crates/rspack_plugin_css/src/plugin.rs b/crates/rspack_plugin_css/src/plugin.rs
@@ -701,9 +701,11 @@ impl Plugin for CssPlugin {
         output
       })
       .collect::<Vec<ConcatSource>>();
+    let is_no_sources = sources.is_empty();
+
     let source = ConcatSource::new(sources);
 
-    if source.source().is_empty() {
+    if is_no_sources {
       Ok(Default::default())
     } else {
       let filename_template = get_css_chunk_filename_template(
diff --git a/packages/playground/fixtures/import-empty-css-file/package.json b/packages/playground/fixtures/import-empty-css-file/package.json
@@ -0,0 +1,5 @@
+{
+  "name": "test-case",
+  "private": true,
+  "dependencies": {}
+}
diff --git a/packages/playground/fixtures/import-empty-css-file/rspack.config.js b/packages/playground/fixtures/import-empty-css-file/rspack.config.js
@@ -0,0 +1,27 @@
+/** @type { import('@rspack/core').RspackOptions } */
+module.exports = {
+	context: __dirname,
+	mode: "development",
+	entry: "./src/index.js",
+	devServer: {
+		hot: true
+	},
+	cache: false,
+	stats: "none",
+	infrastructureLogging: {
+		debug: false
+	},
+	builtins: {
+		html: [
+			{
+				template: "./src/index.html"
+			}
+		],
+		define: {
+			"process.env.NODE_ENV": JSON.stringify("development")
+		}
+	},
+	watchOptions: {
+		poll: 1000
+	}
+};
diff --git a/packages/playground/fixtures/import-empty-css-file/src/empty.css b/packages/playground/fixtures/import-empty-css-file/src/empty.css
diff --git a/packages/playground/fixtures/import-empty-css-file/src/empty.js b/packages/playground/fixtures/import-empty-css-file/src/empty.js
@@ -0,0 +1 @@
+import "./empty.css";
diff --git a/packages/playground/fixtures/import-empty-css-file/src/index.html b/packages/playground/fixtures/import-empty-css-file/src/index.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html lang="en">
+	<head>
+		<meta charset="UTF-8" />
+		<meta http-equiv="X-UA-Compatible" content="IE=edge" />
+		<meta name="viewport" content="width=device-width, initial-scale=1.0" />
+		<title>Document</title>
+	</head>
+	<body>
+		<div id="root"></div>
+	</body>
+</html>
diff --git a/packages/playground/fixtures/import-empty-css-file/src/index.js b/packages/playground/fixtures/import-empty-css-file/src/index.js
@@ -0,0 +1,3 @@
+import("./empty").then(() => {
+	document.getElementById("root").innerText = "ok";
+});
diff --git a/packages/playground/fixtures/import-empty-css-file/test/index.test.ts b/packages/playground/fixtures/import-empty-css-file/test/index.test.ts
@@ -0,0 +1,5 @@
+test("should not throw error for importing empty css files", async () => {
+	expect(await page.textContent("#root")).toBe("ok");
+});
+
+export {};

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import("./empty").then(() => {`
	`2`	`+ document.getElementById("root").innerText = "ok";`
	`3`	`+});`