fix(module-federation): encode runtime data URI and handle named wrappers

Author: BleedingDev

packages/rspack/src/Template.ts

@@ -14,7 +14,8 @@ const DELTA_A_TO_Z = 'z'.charCodeAt(0) - START_LOWERCASE_ALPHABET_CODE + 1;
 const NUMBER_OF_IDENTIFIER_START_CHARS = DELTA_A_TO_Z * 2 + 2; // a-z A-Z _ $
 const NUMBER_OF_IDENTIFIER_CONTINUATION_CHARS =
   NUMBER_OF_IDENTIFIER_START_CHARS + 10; // a-z A-Z _ $ 0-9
-const FUNCTION_CONTENT_REGEX = /^function\s?\(\)\s?\{\r?\n?|\r?\n?\}$/g;
+const FUNCTION_CONTENT_REGEX =
+  /^function(?:\s+[\w$]+)?\s?\(\)\s?\{\r?\n?|\r?\n?\}$/g;
 const INDENT_MULTILINE_REGEX = /^\t/gm;
 const LINE_SEPARATOR_REGEX = /\r?\n/g;
 const IDENTIFIER_NAME_REPLACE_REGEX = /^([^a-zA-Z$_])/;

packages/rspack/src/container/ModuleFederationPlugin.ts

@@ -346,5 +346,5 @@ function getDefaultEntryRuntime(
           require('./moduleFederationDefaultRuntime.js').default,
         ),
   ].join(';');
-  return `@module-federation/runtime/rspack.js!=!data:text/javascript,${content}`;
+  return `@module-federation/runtime/rspack.js!=!data:text/javascript,${encodeURIComponent(content)}`;
 }

tests/rspack-test/Template.test.js

@@ -0,0 +1,21 @@
+const { Template } = require("@rspack/core");
+
+describe("Template.getFunctionContent", () => {
+	it("should strip named function wrappers", () => {
+		const content = Template.getFunctionContent(function moduleFederationDefaultRuntime_default() {
+			return "ok";
+		});
+
+		expect(content).toContain('return "ok";');
+		expect(content).not.toContain("function moduleFederationDefaultRuntime_default");
+	});
+
+	it("should strip anonymous function wrappers", () => {
+		const content = Template.getFunctionContent(function () {
+			return "ok";
+		});
+
+		expect(content).toContain('return "ok";');
+		expect(content).not.toContain("function ()");
+	});
+});

tests/rspack-test/configCases/container-1-5/runtime-entry-data-uri-encoded/index.js

@@ -0,0 +1,7 @@
+it("should expose module with encoded mf runtime data uri entry", async () => {
+	await __webpack_init_sharing__("default");
+	const container = __non_webpack_require__("./container.js");
+	container.init(__webpack_share_scopes__.default);
+	const moduleFactory = await container.get("./module");
+	expect(moduleFactory().ok).toBe(true);
+});

tests/rspack-test/configCases/container-1-5/runtime-entry-data-uri-encoded/module.js

@@ -0,0 +1 @@
+export const ok = true;

tests/rspack-test/configCases/container-1-5/runtime-entry-data-uri-encoded/rspack.config.js

@@ -0,0 +1,43 @@
+const { ModuleFederationPlugin } = require("@rspack/core").container;
+
+class AssertEncodedMFRuntimeDataUriPlugin {
+	apply(compiler) {
+		compiler.hooks.compilation.tap(
+			"AssertEncodedMFRuntimeDataUriPlugin",
+			(_, { normalModuleFactory }) => {
+				normalModuleFactory.hooks.beforeResolve.tap(
+					"AssertEncodedMFRuntimeDataUriPlugin",
+					(resolveData) => {
+						const request = resolveData?.request;
+						const prefix =
+							"@module-federation/runtime/rspack.js!=!data:text/javascript,";
+
+						if (!request || !request.startsWith(prefix)) {
+							return;
+						}
+
+						const dataUriContent = request.slice(prefix.length);
+
+						expect(dataUriContent).toMatch(/%[0-9A-Fa-f]{2}/);
+						expect(dataUriContent).not.toContain(
+							"import __module_federation_bundler_runtime__ from",
+						);
+					},
+				);
+			},
+		);
+	}
+}
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	plugins: [
+		new ModuleFederationPlugin({
+			name: "container",
+			filename: "container.js",
+			library: { type: "commonjs-module" },
+			exposes: ["./module"],
+		}),
+		new AssertEncodedMFRuntimeDataUriPlugin(),
+	],
+};