feat: passthrough panics for parallel-running futures (#2737)

Author: h-a-n-a

crates/rspack_core/src/compiler/compilation.rs

@@ -922,11 +922,7 @@ impl Compilation {
       })
       .collect::<FuturesResults<_>>();
 
-    let chunk_ukey_and_manifest = results
-      .into_inner()
-      .into_iter()
-      .collect::<std::result::Result<Vec<_>, _>>()
-      .expect("Failed to resolve render_manifest results");
+    let chunk_ukey_and_manifest = results.into_inner();
 
     chunk_ukey_and_manifest
       .into_iter()
@@ -1169,8 +1165,7 @@ impl Compilation {
       })
       .collect::<FuturesResults<_>>()
       .into_inner();
-    for item in chunk_hash_results {
-      let (chunk_ukey, hash) = item.expect("Failed to resolve chunk_hash results");
+    for (chunk_ukey, hash) in chunk_hash_results {
       if let Some(chunk) = self.chunk_by_ukey.get_mut(&chunk_ukey) {
         hash?.hash(&mut chunk.hash);
       }
@@ -1271,8 +1266,7 @@ impl Compilation {
       .collect::<FuturesResults<_>>()
       .into_inner();
 
-    for item in hash_results {
-      let (chunk_ukey, hashes) = item.expect("Failed to resolve content_hash results");
+    for (chunk_ukey, hashes) in hash_results {
       hashes?.into_iter().for_each(|hash| {
         if let Some(chunk) = self.chunk_by_ukey.get_mut(&chunk_ukey) && let Some((source_type, hash)) = hash {
           chunk.content_hash.insert(source_type, hash);

crates/rspack_futures/src/lib.rs

@@ -4,10 +4,13 @@ use std::{
 };
 
 use async_scoped::{Scope, TokioScope};
-use tokio::task::JoinError;
-
-type FuturesResult<T> = Vec<Result<T, JoinError>>;
 
+/// Run futures in parallel.
+///
+///
+/// # Panic
+///
+/// Panics if any task panics.
 ///
 /// A rough demo of how this works:
 ///
@@ -26,11 +29,11 @@ type FuturesResult<T> = Vec<Result<T, JoinError>>;
 /// ```
 #[derive(Default)]
 pub struct FuturesResults<T> {
-  inner: FuturesResult<T>,
+  inner: Vec<T>,
 }
 
 impl<T> FuturesResults<T> {
-  pub fn into_inner(self) -> FuturesResult<T> {
+  pub fn into_inner(self) -> Vec<T> {
     self.inner
   }
 }
@@ -50,12 +53,26 @@ where
       });
     });
 
-    Self { inner }
+    Self {
+      inner: inner
+        .into_iter()
+        .map(|i| match i {
+          Ok(i) => i,
+          Err(err) => {
+            if err.is_panic() {
+              std::panic::resume_unwind(err.into_panic())
+            } else {
+              unreachable!("Error should be a panic {err}")
+            }
+          }
+        })
+        .collect(),
+    }
   }
 }
 
 impl<T> Deref for FuturesResults<T> {
-  type Target = FuturesResult<T>;
+  type Target = Vec<T>;
 
   fn deref(&self) -> &Self::Target {
     &self.inner

crates/rspack_plugin_copy/src/lib.rs

@@ -415,13 +415,7 @@ impl CopyPlugin {
           return None;
         }
 
-        Some(
-          copied_result
-            .into_inner()
-            .into_iter()
-            .flat_map(|it| it.ok())
-            .collect::<Vec<_>>(),
-        )
+        Some(copied_result.into_inner())
       }
       Err(e) => {
         if pattern.no_error_on_missing {