fix(mf): validate legacy share-scope arrays consistently

Author: ScriptedAlchemy

packages/rspack/src/container/ContainerReferencePlugin.ts

@@ -30,28 +30,43 @@ export type RemotesConfig = {
   shareScope?: string | string[];
 };
 
+function hasMultipleShareScopes(shareScope?: string | string[]) {
+  return Array.isArray(shareScope) && shareScope.filter(Boolean).length > 1;
+}
+
 export class ContainerReferencePlugin extends RspackBuiltinPlugin {
   name = BuiltinPluginName.ContainerReferencePlugin;
   _options;
 
   constructor(options: ContainerReferencePluginOptions) {
     super();
+    const enhanced = options.enhanced ?? false;
+    const remotes = parseOptions(
+      options.remotes,
+      (item) => ({
+        external: Array.isArray(item) ? item : [item],
+        shareScope: options.shareScope || 'default',
+      }),
+      (item) => ({
+        external: Array.isArray(item.external)
+          ? item.external
+          : [item.external],
+        shareScope: item.shareScope || options.shareScope || 'default',
+      }),
+    );
+    if (
+      !enhanced &&
+      (hasMultipleShareScopes(options.shareScope) ||
+        remotes.some(([, config]) => hasMultipleShareScopes(config.shareScope)))
+    ) {
+      throw new Error(
+        '[ContainerReferencePlugin] Multiple share scopes are only supported in enhanced mode. Set `enhanced: true` or provide a single `shareScope`.',
+      );
+    }
     this._options = {
       remoteType: options.remoteType,
-      remotes: parseOptions(
-        options.remotes,
-        (item) => ({
-          external: Array.isArray(item) ? item : [item],
-          shareScope: options.shareScope || 'default',
-        }),
-        (item) => ({
-          external: Array.isArray(item.external)
-            ? item.external
-            : [item.external],
-          shareScope: item.shareScope || options.shareScope || 'default',
-        }),
-      ),
-      enhanced: options.enhanced ?? false,
+      remotes,
+      enhanced,
     };
   }
 

packages/rspack/src/sharing/SharePlugin.ts

@@ -38,6 +38,10 @@ export type SharedConfig = {
 
 export type NormalizedSharedOptions = [string, SharedConfig][];
 
+function hasMultipleShareScopes(shareScope?: string | string[]) {
+  return Array.isArray(shareScope) && shareScope.filter(Boolean).length > 1;
+}
+
 export function normalizeSharedOptions(
   shared: Shared,
 ): NormalizedSharedOptions {
@@ -114,6 +118,17 @@ export class SharePlugin {
   constructor(options: SharePluginOptions) {
     const enhanced = options.enhanced ?? false;
     const sharedOptions = normalizeSharedOptions(options.shared);
+    if (
+      !enhanced &&
+      (hasMultipleShareScopes(options.shareScope) ||
+        sharedOptions.some(([, config]) =>
+          hasMultipleShareScopes(config.shareScope),
+        ))
+    ) {
+      throw new Error(
+        '[SharePlugin] Multiple share scopes are only supported in enhanced mode. Set `enhanced: true` or provide a single `shareScope`.',
+      );
+    }
     const consumes = createConsumeShareOptions(sharedOptions, enhanced);
     const provides = createProvideShareOptions(sharedOptions, enhanced);
     this._shareScope = options.shareScope;

tests/rspack-test/configCases/container-1-0/share-scope-array-legacy-validation-remotes/errors.js

@@ -0,0 +1,3 @@
+module.exports = [
+  /\[ContainerReferencePlugin\] Multiple share scopes are only supported in enhanced mode\./,
+];

tests/rspack-test/configCases/container-1-0/share-scope-array-legacy-validation-remotes/index.js

@@ -0,0 +1,3 @@
+it('should fail before build for legacy multi-scope remote shareScope', () => {
+  expect(true).toBe(true);
+});

tests/rspack-test/configCases/container-1-0/share-scope-array-legacy-validation-remotes/rspack.config.js

@@ -0,0 +1,19 @@
+const { ModuleFederationPluginV1: ModuleFederationPlugin } =
+  require('@rspack/core').container;
+
+/** @type {import('@rspack/core').Configuration} */
+module.exports = {
+  mode: 'development',
+  entry: './index.js',
+  plugins: [
+    new ModuleFederationPlugin({
+      name: 'legacy_multi_scope_validation_remotes',
+      remotes: {
+        remote: {
+          external: 'remote@http://localhost:3000/remoteEntry.js',
+          shareScope: ['default', 'ssr'],
+        },
+      },
+    }),
+  ],
+};

tests/rspack-test/configCases/container-1-0/share-scope-array-legacy-validation-shared/errors.js

@@ -0,0 +1,3 @@
+module.exports = [
+  /\[SharePlugin\] Multiple share scopes are only supported in enhanced mode\./,
+];

tests/rspack-test/configCases/container-1-0/share-scope-array-legacy-validation-shared/index.js

@@ -0,0 +1,3 @@
+it('should fail before build for legacy multi-scope shared shareScope', () => {
+  expect(true).toBe(true);
+});

tests/rspack-test/configCases/container-1-0/share-scope-array-legacy-validation-shared/rspack.config.js

@@ -0,0 +1,19 @@
+const { ModuleFederationPluginV1: ModuleFederationPlugin } =
+  require('@rspack/core').container;
+
+/** @type {import('@rspack/core').Configuration} */
+module.exports = {
+  mode: 'development',
+  entry: './index.js',
+  plugins: [
+    new ModuleFederationPlugin({
+      name: 'legacy_multi_scope_validation_shared',
+      shared: {
+        react: {
+          import: 'react',
+          shareScope: ['default', 'ssr'],
+        },
+      },
+    }),
+  ],
+};