refactor: use read only compilation reference in after process assets hook (#12615)

* refactor: use RO compilation ref in after process assets

* Update crates/rspack_plugin_progress/src/lib.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: stormslowly

crates/rspack_binding_api/src/plugins/interceptor.rs

@@ -44,6 +44,7 @@ use rspack_core::{
   Scheme, build_module_graph::BuildModuleGraphArtifact, parse_resource,
   rspack_sources::RawStringSource,
 };
+use rspack_error::Diagnostic;
 use rspack_hash::RspackHash;
 use rspack_hook::{Hook, Interceptor};
 use rspack_napi::threadsafe_function::ThreadsafeFunction;
@@ -1441,7 +1442,11 @@ impl CompilationProcessAssets for CompilationProcessAssetsTap {
 
 #[async_trait]
 impl CompilationAfterProcessAssets for CompilationAfterProcessAssetsTap {
-  async fn run(&self, compilation: &mut Compilation) -> rspack_error::Result<()> {
+  async fn run(
+    &self,
+    compilation: &Compilation,
+    _diagnostics: &mut Vec<Diagnostic>,
+  ) -> rspack_error::Result<()> {
     let compilation = JsCompilationWrapper::new(compilation);
     self.function.call_with_sync(compilation).await
   }

crates/rspack_core/src/compilation/mod.rs

@@ -101,7 +101,7 @@ define_hook!(CompilationDependentFullHash: SeriesBail(compilation: &Compilation,
 define_hook!(CompilationRenderManifest: Series(compilation: &Compilation, chunk_ukey: &ChunkUkey, manifest: &mut Vec<RenderManifestEntry>, diagnostics: &mut Vec<Diagnostic>),tracing=false);
 define_hook!(CompilationChunkAsset: Series(compilation: &Compilation, chunk_ukey: &ChunkUkey, filename: &str));
 define_hook!(CompilationProcessAssets: Series(compilation: &mut Compilation));
-define_hook!(CompilationAfterProcessAssets: Series(compilation: &mut Compilation));
+define_hook!(CompilationAfterProcessAssets: Series(compilation: &Compilation, diagnostics: &mut Vec<Diagnostic>));
 define_hook!(CompilationAfterSeal: Series(compilation: &Compilation),tracing=true);
 
 #[derive(Debug, Default)]
@@ -1383,11 +1383,16 @@ impl Compilation {
 
   #[instrument("Compilation:after_process_assets", skip_all)]
   async fn after_process_assets(&mut self, plugin_driver: SharedPluginDriver) -> Result<()> {
-    plugin_driver
+    let mut diagnostics: Vec<Diagnostic> = vec![];
+
+    let res = plugin_driver
       .compilation_hooks
       .after_process_assets
-      .call(self)
-      .await
+      .call(self, &mut diagnostics)
+      .await;
+
+    self.extend_diagnostics(diagnostics);
+    res
   }
 
   #[instrument("Compilation:after_seal", target=TRACING_BENCH_TARGET,skip_all)]

crates/rspack_plugin_progress/src/lib.rs

@@ -519,7 +519,11 @@ async fn process_assets(&self, _compilation: &mut Compilation) -> Result<()> {
 }
 
 #[plugin_hook(CompilationAfterProcessAssets for ProgressPlugin)]
-async fn after_process_assets(&self, _compilation: &mut Compilation) -> Result<()> {
+async fn after_process_assets(
+  &self,
+  _compilation: &Compilation,
+  _diagnostics: &mut Vec<Diagnostic>,
+) -> Result<()> {
   self
     .sealing_hooks_report("after asset optimization", 36)
     .await

crates/rspack_plugin_rsdoctor/src/plugin.rs

@@ -452,7 +452,11 @@ async fn after_code_generation(&self, compilation: &mut Compilation) -> Result<(
 }
 
 #[plugin_hook(CompilationAfterProcessAssets for RsdoctorPlugin, stage = 9999)]
-async fn after_process_assets(&self, compilation: &mut Compilation) -> Result<()> {
+async fn after_process_assets(
+  &self,
+  compilation: &Compilation,
+  _diagnostics: &mut Vec<Diagnostic>,
+) -> Result<()> {
   if !self.has_chunk_graph_feature(RsdoctorPluginChunkGraphFeature::Assets) {
     return Ok(());
   }

crates/rspack_plugin_sri/src/asset.rs

@@ -293,7 +293,11 @@ pub async fn handle_assets(&self, compilation: &mut Compilation) -> Result<()> {
 }
 
 #[plugin_hook(CompilationAfterProcessAssets for SubresourceIntegrityPlugin)]
-pub async fn detect_unresolved_integrity(&self, compilation: &mut Compilation) -> Result<()> {
+pub async fn detect_unresolved_integrity(
+  &self,
+  compilation: &Compilation,
+  diagnostics: &mut Vec<Diagnostic>,
+) -> Result<()> {
   let mut contain_unresolved_files = vec![];
   for chunk in compilation.chunk_by_ukey.values() {
     for file in chunk.files() {
@@ -309,7 +313,7 @@ pub async fn detect_unresolved_integrity(&self, compilation: &mut Compilation) -
   }
 
   for file in contain_unresolved_files {
-    compilation.push_diagnostic(Diagnostic::error(
+    diagnostics.push(Diagnostic::error(
       "SubresourceIntegrity".to_string(),
       format!("Asset {file} contains unresolved integrity placeholders"),
     ));