add test

Author: ahabhgk

crates/node_binding/src/compilation/mod.rs

@@ -767,24 +767,15 @@ impl JsCompilation {
         .into_iter()
         .map(|dependency_id| {
           let module_graph = compilation.get_module_graph();
-          match module_graph.module_graph_module_by_dependency_id(&dependency_id) {
-            Some(module) => match module_graph.module_by_identifier(&module.module_identifier) {
-              Some(module) => {
-                let js_module =
-                  JsModuleWrapper::new(module.identifier(), None, compilation.compiler_id());
-                (Either::B(()), Either::B(js_module))
-              }
-              None => (
-                Either::A(format!(
-                  "Module created by {:#?} cannot be found",
-                  dependency_id
-                )),
-                Either::A(()),
-              ),
-            },
+          match module_graph.get_module_by_dependency_id(&dependency_id) {
+            Some(module) => {
+              let js_module =
+                JsModuleWrapper::new(module.identifier(), None, compilation.compiler_id());
+              (Either::B(()), Either::B(js_module))
+            }
             None => (
               Either::A(format!(
-                "Module created by {:#?} cannot be found",
+                "Module created by {:?} cannot be found",
                 dependency_id
               )),
               Either::A(()),

packages/rspack-test-tools/tests/watchCases/add-include/reuse-deps-for-incremental-make/0/foo.js

@@ -0,0 +1 @@
+STATE.foo = 42;

packages/rspack-test-tools/tests/watchCases/add-include/reuse-deps-for-incremental-make/0/index.js

@@ -0,0 +1,7 @@
+__webpack_require__("./foo.js");
+
+it("should addInclude foo.js", () => {
+  expect(STATE.foo).toBe(42);
+  const builtModules = Object.fromEntries(__STATS__.modules.map(m => [m.name, m.built]));
+  expect(builtModules).toEqual({ "./index.js": true, "./foo.js": true });
+});

packages/rspack-test-tools/tests/watchCases/add-include/reuse-deps-for-incremental-make/1/index.js

@@ -0,0 +1,7 @@
+__webpack_require__("./foo.js");
+
+it("should addInclude foo.js", () => {
+  expect(STATE.foo).toBe(42);
+  const builtModules = Object.fromEntries(__STATS__.modules.map(m => [m.name, m.built]));
+  expect(builtModules).toEqual({ "./index.js": true, "./foo.js": false });
+});

packages/rspack-test-tools/tests/watchCases/add-include/reuse-deps-for-incremental-make/rspack.config.js

@@ -0,0 +1,48 @@
+let step = 0;
+let factorizeRequests = [];
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	plugins: [
+		function (compiler) {
+			const PLUGIN_NAME = "TEST_PLUGIN";
+			const { EntryPlugin } = compiler.webpack;
+			compiler.hooks.finishMake.tapPromise(PLUGIN_NAME, compilation => {
+				return new Promise((resolve, reject) => {
+					compilation.addInclude(
+						compiler.context,
+						EntryPlugin.createDependency("./foo.js"),
+						{},
+						err => {
+							if (err) return reject(err);
+							return resolve();
+						}
+					);
+				});
+			});
+
+			compiler.hooks.compilation.tap(
+				PLUGIN_NAME,
+				(compilation, { normalModuleFactory }) => {
+					normalModuleFactory.hooks.factorize.tap(PLUGIN_NAME, data => {
+						factorizeRequests.push(data.request);
+					});
+				}
+			);
+			compiler.hooks.done.tap(PLUGIN_NAME, () => {
+				if (step === 0) {
+					expect(factorizeRequests.length).toBe(2);
+					expect(factorizeRequests.includes("./index.js")).toBe(true);
+					expect(factorizeRequests.includes("./foo.js")).toBe(true);
+				} else if (step === 1) {
+					expect(factorizeRequests.length).toBe(1);
+					expect(factorizeRequests.includes("./index.js")).toBe(true);
+				} else {
+					throw new Error("Unexpected step");
+				}
+				step += 1;
+				factorizeRequests = [];
+			});
+		}
+	]
+};