feat: support enabling builtin loaders in compiler builder (#9262)

* feat: support enabling builtin loaders in compiler builder

* chore: lint

Author: h-a-n-a

.github/workflows/ci.yml

@@ -328,7 +328,10 @@ jobs:
 
       - name: Run test
         # reason for excluding https://github.com/napi-rs/napi-rs/issues/2200
-        run: cargo test --workspace --exclude rspack_node -- --nocapture
+        run: cargo test --workspace --exclude rspack_node --exclude rspack -- --nocapture
+
+      - name: Run rspack test
+        run: cargo test --package rspack --all-features -- --nocapture
 
   rust_test_miri:
     name: Rust test miri

Cargo.lock

@@ -6,6 +6,15 @@ name        = "rspack"
 repository  = "https://github.com/web-infra-dev/rspack"
 version     = "0.2.0"
 
+[features]
+full = ["loaders"]
+
+loader_lightningcss   = ["rspack_loader_lightningcss"]
+loader_preact_refresh = ["rspack_loader_preact_refresh"]
+loader_react_refresh  = ["rspack_loader_react_refresh"]
+loader_swc            = ["rspack_loader_swc"]
+loaders               = ["loader_lightningcss", "loader_preact_refresh", "loader_react_refresh", "loader_swc"]
+
 [dependencies]
 bitflags     = { workspace = true }
 enum-tag     = { workspace = true }
@@ -20,6 +29,7 @@ rspack_regex = { workspace = true }
 rustc-hash   = { workspace = true }
 serde_json   = { workspace = true }
 
+# Plugins
 rspack_plugin_asset                   = { workspace = true }
 rspack_plugin_css                     = { workspace = true }
 rspack_plugin_devtool                 = { workspace = true }
@@ -40,6 +50,12 @@ rspack_plugin_swc_js_minimizer        = { workspace = true }
 rspack_plugin_wasm                    = { workspace = true }
 rspack_plugin_worker                  = { workspace = true }
 
+# Loaders
+rspack_loader_lightningcss   = { workspace = true, optional = true }
+rspack_loader_preact_refresh = { workspace = true, optional = true }
+rspack_loader_react_refresh  = { workspace = true, optional = true }
+rspack_loader_swc            = { workspace = true, optional = true }
+
 [dev-dependencies]
 insta = { workspace = true, features = ["filters"] }
 tokio = { workspace = true }

crates/rspack/Cargo.toml

@@ -431,6 +431,7 @@ impl CompilerBuilder {
   }
 
   /// Build [`Compiler`] from options and plugins.
+  #[must_use]
   pub fn build(&mut self) -> Compiler {
     let mut builder_context = BuilderContext::default();
     let compiler_options = self.options_builder.build(&mut builder_context);
@@ -455,6 +456,44 @@ impl CompilerBuilder {
   }
 }
 
+#[cfg(feature = "loader_lightningcss")]
+impl CompilerBuilder {
+  /// Enable support for builtin:lightningcss-loader.
+  pub fn enable_loader_lightningcss(&mut self) -> &mut Self {
+    self.plugin(Box::new(
+      rspack_loader_lightningcss::LightningcssLoaderPlugin::new(),
+    ))
+  }
+}
+
+#[cfg(feature = "loader_swc")]
+impl CompilerBuilder {
+  /// Enable support for builtin:swc-loader.
+  pub fn enable_loader_swc(&mut self) -> &mut Self {
+    self.plugin(Box::new(rspack_loader_swc::SwcLoaderPlugin::new()))
+  }
+}
+
+#[cfg(feature = "loader_react_refresh")]
+impl CompilerBuilder {
+  /// Enable support for builtin:react-refresh-loader.
+  pub fn enable_loader_react_refresh(&mut self) -> &mut Self {
+    self.plugin(Box::new(
+      rspack_loader_react_refresh::ReactRefreshLoaderPlugin::new(),
+    ))
+  }
+}
+
+#[cfg(feature = "loader_preact_refresh")]
+impl CompilerBuilder {
+  /// Enable support for builtin:preact-refresh-loader.
+  pub fn enable_loader_preact_refresh(&mut self) -> &mut Self {
+    self.plugin(Box::new(
+      rspack_loader_preact_refresh::PreactRefreshLoaderPlugin::new(),
+    ))
+  }
+}
+
 impl Builder for CompilerOptions {
   type Item = CompilerOptionsBuilder;
 
@@ -838,6 +877,7 @@ impl CompilerOptionsBuilder {
   ///
   /// [`BuilderContext`]: crate::builder::BuilderContext
   /// [`CompilerOptions`]: rspack_core::options::CompilerOptions
+  #[must_use]
   pub fn build(&mut self, builder_context: &mut BuilderContext) -> CompilerOptions {
     let name = self.name.take();
     let context = f!(self.context.take(), || {
@@ -1480,6 +1520,7 @@ impl NodeOptionBuilder {
   /// Build [`NodeOption`] from options.
   ///
   /// [`NodeOption`]: rspack_core::options::NodeOption
+  #[must_use]
   fn build(
     &mut self,
     target_properties: &TargetProperties,
@@ -1606,6 +1647,7 @@ impl ModuleOptionsBuilder {
   /// Normally, you don't need to call this function, it's used internally by [`CompilerBuilder::build`].
   ///
   /// [`ModuleOptions`]: rspack_core::options::ModuleOptions
+  #[must_use]
   fn build(
     &mut self,
     _builder_context: &mut BuilderContext,
@@ -2566,6 +2608,7 @@ impl OutputOptionsBuilder {
   ///
   /// [`OutputOptions`]: rspack_core::options::OutputOptions
   #[allow(clippy::too_many_arguments, clippy::fn_params_excessive_bools)]
+  #[must_use]
   fn build(
     &mut self,
     builder_context: &mut BuilderContext,
@@ -3322,6 +3365,7 @@ impl OptimizationOptionsBuilder {
   /// Build [`Optimization`] from options.
   ///
   /// [`Optimization`]: rspack_core::options::Optimization
+  #[must_use]
   fn build(
     &mut self,
     builder_context: &mut BuilderContext,
@@ -3669,6 +3713,7 @@ impl ExperimentsBuilder {
   /// Build [`Experiments`] from options.
   ///
   /// [`Experiments`]: rspack_core::options::Experiments
+  #[must_use]
   fn build(
     &mut self,
     _builder_context: &mut BuilderContext,
@@ -3759,7 +3804,7 @@ mod test {
 
   #[test]
   fn mutable_builder_into_owned_builder() {
-    CompilerOptions::builder()
+    let _ = CompilerOptions::builder()
       .optimization(OptimizationOptionsBuilder::default().node_env("development".to_string()))
       .output(OutputOptionsBuilder::default().charset(true))
       .experiments(ExperimentsBuilder::default().future_defaults(true))

crates/rspack/src/builder/mod.rs

@@ -0,0 +1,9 @@
+body {
+  .a {
+    color: blue
+  }
+
+  .b {
+    color: red
+  }
+}

crates/rspack/tests/fixtures/lightningcss/src/index.css

@@ -0,0 +1 @@
+import "./index.css";

crates/rspack/tests/fixtures/lightningcss/src/index.js

@@ -0,0 +1,5 @@
+function Foo() {
+  return <div>Foo</div>;
+}
+
+eval(Foo);

crates/rspack/tests/fixtures/preact-refresh/src/index.jsx

@@ -0,0 +1,5 @@
+function Foo() {
+  return <div>Foo</div>;
+}
+
+eval(Foo);

crates/rspack/tests/fixtures/react-refresh/src/index.jsx

@@ -0,0 +1,5 @@
+function Foo() {
+  return <div>Foo</div>;
+}
+
+eval(Foo);