docs: add docs for NO_SIDE_EFFECTS notation

Author: JSerFeng

crates/rspack_core/src/dependency/mod.rs

@@ -198,7 +198,7 @@ impl std::fmt::Debug for DependencyCondition {
 }
 
 #[rspack_cacheable::cacheable]
-#[derive(Debug, Clone, Serialize, Default)]
+#[derive(Debug, Clone, Serialize, Default, PartialEq, Eq)]
 pub struct ImportAttributes(FxHashMap<String, String>);
 
 impl FromIterator<(String, String)> for ImportAttributes {

crates/rspack_core/src/module.rs

@@ -68,6 +68,7 @@ pub struct BuildInfo {
   pub need_create_require: bool,
   #[cacheable(with=AsOption<AsPreset>)]
   pub json_data: Option<JsonValue>,
+  #[cacheable(with=AsOption<AsVec<AsPreset>>)]
   pub pure_functions: Option<FxHashSet<Atom>>,
   #[cacheable(with=AsOption<AsVec<AsPreset>>)]
   pub top_level_declarations: Option<HashSet<Atom>>,
@@ -167,8 +168,8 @@ pub enum BuildMetaDefaultObject {
 #[cacheable]
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct DeferredPureCheck {
-  pub import_request: String,
   pub atom: Atom,
+  pub dep_id: DependencyId,
   pub start: u32,
   pub end: u32,
 }

crates/rspack_plugin_javascript/src/dependency/esm/esm_import_specifier_dependency.rs

@@ -107,6 +107,10 @@ impl ESMImportSpecifierDependency {
       .unwrap_or_else(|| self.ids.as_slice())
   }
 
+  pub fn get_name(&self) -> &Atom {
+    &self.name
+  }
+
   pub fn get_referenced_exports_in_destructuring(
     &self,
     ids: Option<&[Atom]>,

crates/rspack_plugin_javascript/src/parser_plugin/inner_graph/plugin.rs

@@ -104,7 +104,8 @@ impl InnerGraphPlugin {
   pub fn new(unresolved_mark: Mark) -> Self {
     Self {
       unresolved_context: SyntaxContext::empty().apply_mark(unresolved_mark),
-      analyze_pure_annotation: true,
+      // TODO: optimize inner graph
+      analyze_pure_annotation: false,
     }
   }
 

crates/rspack_plugin_javascript/src/parser_plugin/side_effects_parser_plugin.rs

@@ -1,4 +1,7 @@
-use rspack_core::{DeferredPureCheck, SideEffectsBailoutItemWithSpan};
+use rspack_core::{
+  DeferredPureCheck, Dependency, ModuleDependency, SideEffectsBailoutItemWithSpan,
+};
+use rspack_util::SpanExt;
 use rustc_hash::FxHashSet;
 use swc_core::{
   atoms::Atom,
@@ -15,6 +18,7 @@ use swc_core::{
 
 use crate::{
   ClassExt, JavascriptParserPlugin,
+  dependency::ESMImportSideEffectDependency,
   parser_plugin::esm_import_dependency_parser_plugin::{ESM_SPECIFIER_TAG, ESMSpecifierData},
   visitors::{JavascriptParser, Statement, TagInfoData, VariableDeclaration},
 };
@@ -154,7 +158,7 @@ impl JavascriptParserPlugin for SideEffectsParserPlugin {
       };
       ast.visit_with(&mut pure_annotation);
       let detected_pure_functions = pure_annotation.pure_functions;
-      if detected_pure_functions.len() > 0 {
+      if !detected_pure_functions.is_empty() {
         let pure_functions = parser.build_info.pure_functions.get_or_insert_default();
         pure_functions.extend(detected_pure_functions);
       }
@@ -227,7 +231,7 @@ impl JavascriptParserPlugin for SideEffectsParserPlugin {
       }
     }
 
-    if not_defined.len() > 0 {
+    if !not_defined.is_empty() {
       let resource = parser.resource_data.resource();
       parser.add_warning(
         rspack_error::Diagnostic::warn("PURE_FUNCTION_NOT_FOUND".into(), format!("Following pure functions are not found in {resource}:\n[{}]\nRemove it from `module.rules[{{index}}].pureFunctions`", not_defined.iter().map(|atom| format!("`{atom}`")).collect::<Vec<_>>().join(", ")))
@@ -254,7 +258,7 @@ fn is_pure_call_expr(
     .unwrap_or(false);
 
   if pure_flag {
-    call_expr.args.iter().all(|arg| {
+    return call_expr.args.iter().all(|arg| {
       if arg.spread.is_some() {
         false
       } else {
@@ -266,8 +270,8 @@ fn is_pure_call_expr(
           comments,
         )
       }
-    })
-  } else {
+    });
+  } else if analyze_pure_notation {
     if let Some(Expr::Ident(ident)) = callee.as_expr().map(|expr| expr.as_ref())
       && parser
         .build_info
@@ -296,14 +300,14 @@ fn is_pure_call_expr(
         }
       });
     }
-
-    !expr.may_have_side_effects(ExprCtx {
-      unresolved_ctxt,
-      in_strict: false,
-      is_unresolved_ref_safe: false,
-      remaining_depth: 4,
-    })
   }
+
+  !expr.may_have_side_effects(ExprCtx {
+    unresolved_ctxt,
+    in_strict: false,
+    is_unresolved_ref_safe: false,
+    remaining_depth: 4,
+  })
 }
 
 fn try_extract_deferred_check(
@@ -328,12 +332,25 @@ fn try_extract_deferred_check(
 
   let data = ESMSpecifierData::downcast(tag_info.data.clone()?);
 
-  Some(DeferredPureCheck {
-    import_request: data.source.to_string(),
-    atom: data.name.clone(),
-    start: callee.span().lo.0,
-    end: callee.span().hi.0,
-  })
+  parser
+    .get_dependencies()
+    .iter()
+    .find(|dep| {
+      let Some(dep) = dep.downcast_ref::<ESMImportSideEffectDependency>() else {
+        return false;
+      };
+
+      let request_eq = dep.request() == &data.source;
+      let attributes: Option<&rspack_core::ImportAttributes> = data.attributes.as_ref();
+      let attributes_eq = attributes == dep.get_attributes();
+      request_eq && attributes_eq
+    })
+    .map(|dep| DeferredPureCheck {
+      atom: data.name.clone(),
+      dep_id: *dep.id(),
+      start: callee.span().real_lo(),
+      end: callee.span().real_hi(),
+    })
 }
 
 impl SideEffectsParserPlugin {