perf: IndexSet for ArcPath (#11727)

Author: SyMind

Cargo.lock

@@ -5,10 +5,9 @@ use std::{
   time::{SystemTime, UNIX_EPOCH},
 };
 
-use dashmap::DashMap;
 use rspack_cacheable::cacheable;
 use rspack_fs::ReadableFileSystem;
-use rspack_paths::{ArcPath, AssertUtf8};
+use rspack_paths::{ArcPath, ArcPathDashMap, AssertUtf8};
 use rustc_hash::FxHasher;
 
 /// Snapshot check strategy
@@ -46,7 +45,7 @@ pub enum ValidateResult {
 
 pub struct StrategyHelper {
   fs: Arc<dyn ReadableFileSystem>,
-  package_version_cache: DashMap<ArcPath, Option<String>>,
+  package_version_cache: ArcPathDashMap<Option<String>>,
   compile_time: u64,
 }
 

crates/rspack_core/src/cache/persistent/snapshot/strategy.rs

@@ -10,7 +10,7 @@ use std::{
 
 use dashmap::DashSet;
 use futures::future::BoxFuture;
-use indexmap::{IndexMap, IndexSet};
+use indexmap::IndexMap;
 use itertools::Itertools;
 use rayon::prelude::*;
 use rspack_cacheable::{
@@ -24,7 +24,7 @@ use rspack_error::{Diagnostic, Result, ToStringResultToRspackResultExt};
 use rspack_fs::{IntermediateFileSystem, ReadableFileSystem, WritableFileSystem};
 use rspack_hash::{RspackHash, RspackHashDigest};
 use rspack_hook::define_hook;
-use rspack_paths::{ArcPath, ArcPathSet};
+use rspack_paths::{ArcPath, ArcPathIndexSet, ArcPathSet};
 use rspack_sources::{BoxSource, CachedSource, SourceExt};
 use rspack_tasks::CompilerContext;
 use rspack_util::{itoa, tracing_preset::TRACING_BENCH_TARGET};
@@ -268,10 +268,10 @@ pub struct Compilation {
 
   pub hash: Option<RspackHashDigest>,
 
-  pub file_dependencies: IndexSet<ArcPath, BuildHasherDefault<FxHasher>>,
-  pub context_dependencies: IndexSet<ArcPath, BuildHasherDefault<FxHasher>>,
-  pub missing_dependencies: IndexSet<ArcPath, BuildHasherDefault<FxHasher>>,
-  pub build_dependencies: IndexSet<ArcPath, BuildHasherDefault<FxHasher>>,
+  pub file_dependencies: ArcPathIndexSet,
+  pub context_dependencies: ArcPathIndexSet,
+  pub missing_dependencies: ArcPathIndexSet,
+  pub build_dependencies: ArcPathIndexSet,
 
   pub value_cache_versions: ValueCacheVersions,
 

crates/rspack_core/src/compiler/compilation.rs

@@ -11,6 +11,7 @@ version.workspace = true
 [dependencies]
 camino           = { workspace = true }
 dashmap          = { workspace = true }
+indexmap         = { workspace = true }
 rspack_cacheable = { workspace = true }
 rustc-hash       = { workspace = true }
 ustr             = { workspace = true }

crates/rspack_paths/Cargo.toml

@@ -8,6 +8,7 @@ use std::{
 
 pub use camino::{Utf8Component, Utf8Components, Utf8Path, Utf8PathBuf, Utf8Prefix};
 use dashmap::{DashMap, DashSet};
+use indexmap::IndexSet;
 use rspack_cacheable::{
   cacheable,
   with::{AsRefStr, AsRefStrConverter},
@@ -143,3 +144,7 @@ pub type ArcPathDashMap<V> = DashMap<ArcPath, V, BuildHasherDefault<IdentityHash
 /// A standard `DashSet` using `ArcPath` as the key type with a custom `Hasher`
 /// that just uses the precomputed hash for speed instead of calculating it.
 pub type ArcPathDashSet = DashSet<ArcPath, BuildHasherDefault<IdentityHasher>>;
+
+/// A standard `IndexSet` using `ArcPath` as the key type with a custom `Hasher`
+/// that just uses the precomputed hash for speed instead of calculating it.
+pub type ArcPathIndexSet = IndexSet<ArcPath, BuildHasherDefault<IdentityHasher>>;