perf: merge HarmonyImportSideEffectDependency into HarmonyImportDependency (#4037)

Author: underfin

crates/rspack_core/src/dependency/mod.rs

@@ -44,7 +44,6 @@ pub enum DependencyType {
   // Harmony import
   EsmImport,
   EsmImportSpecifier,
-  EsmImportSideEffect,
   // Harmony export
   EsmExport,
   EsmExportImportedSpecifier,
@@ -96,7 +95,6 @@ impl Display for DependencyType {
       DependencyType::Unknown => write!(f, "unknown"),
       DependencyType::Entry => write!(f, "entry"),
       DependencyType::EsmImport => write!(f, "esm import"),
-      DependencyType::EsmImportSideEffect => write!(f, "esm import side effect"),
       DependencyType::EsmExport => write!(f, "esm export"),
       DependencyType::EsmExportSpecifier => write!(f, "esm export specifier"),
       DependencyType::EsmExportImportedSpecifier => write!(f, "esm export import specifier"),

crates/rspack_plugin_javascript/src/dependency/esm/harmony_import_dependency.rs

@@ -1,11 +1,12 @@
 use rspack_core::tree_shaking::symbol::{self, IndirectTopLevelSymbol};
 use rspack_core::tree_shaking::visitor::SymbolRef;
 use rspack_core::{
-  import_statement, Dependency, DependencyCategory, DependencyId, DependencyTemplate,
-  DependencyType, ErrorSpan, InitFragment, InitFragmentStage, ModuleDependency, RuntimeGlobals,
-  TemplateContext, TemplateReplaceSource,
+  import_statement, ConnectionState, Dependency, DependencyCategory, DependencyCondition,
+  DependencyId, DependencyTemplate, DependencyType, ErrorSpan, InitFragment, InitFragmentStage,
+  ModuleDependency, ModuleIdentifier, RuntimeGlobals, TemplateContext, TemplateReplaceSource,
 };
 use rspack_core::{ExportsReferencedType, ModuleGraph, RuntimeSpec};
+use rustc_hash::FxHashSet as HashSet;
 use swc_core::ecma::atoms::JsWord;
 
 use super::create_resource_identifier_for_esm_dependency;
@@ -17,6 +18,7 @@ pub enum Specifier {
   Named(JsWord, Option<JsWord>),
 }
 
+// HarmonyImportDependency is merged HarmonyImportSideEffectDependency.
 #[derive(Debug, Clone)]
 pub struct HarmonyImportDependency {
   pub request: JsWord,
@@ -236,4 +238,37 @@ impl ModuleDependency for HarmonyImportDependency {
   ) -> ExportsReferencedType {
     ExportsReferencedType::No
   }
+
+  // It's from HarmonyImportSideEffectDependency.
+  fn get_condition(&self, _module_graph: &ModuleGraph) -> Option<DependencyCondition> {
+    let id = self.id;
+    Some(DependencyCondition::Fn(Box::new(
+      move |_, _, module_graph| {
+        if let Some(module) = module_graph
+          .parent_module_by_dependency_id(&id)
+          .and_then(|module_identifier| module_graph.module_by_identifier(&module_identifier))
+        {
+          module.get_side_effects_connection_state(module_graph, &mut HashSet::default())
+        } else {
+          ConnectionState::Bool(true)
+        }
+      },
+    )))
+  }
+
+  // It's from HarmonyImportSideEffectDependency.
+  fn get_module_evaluation_side_effects_state(
+    &self,
+    module_graph: &ModuleGraph,
+    module_chain: &mut HashSet<ModuleIdentifier>,
+  ) -> ConnectionState {
+    if let Some(module) = module_graph
+      .parent_module_by_dependency_id(&self.id)
+      .and_then(|module_identifier| module_graph.module_by_identifier(&module_identifier))
+    {
+      module.get_side_effects_connection_state(module_graph, module_chain)
+    } else {
+      ConnectionState::Bool(true)
+    }
+  }
 }

crates/rspack_plugin_javascript/src/dependency/esm/harmony_import_side_effect_dependency.rs

@@ -17,8 +17,6 @@ pub use harmony_import_specifier_dependency::*;
 mod import_dependency;
 pub use import_dependency::*;
 use rspack_core::DependencyCategory;
-mod harmony_import_side_effect_dependency;
-pub use harmony_import_side_effect_dependency::*;
 pub fn create_resource_identifier_for_esm_dependency(request: &str) -> String {
   format!("{}|{}", DependencyCategory::Esm, &request)
 }

crates/rspack_plugin_javascript/src/dependency/esm/mod.rs

@@ -18,7 +18,7 @@ use swc_core::{
 
 use crate::dependency::{
   HarmonyExportImportedSpecifierDependency, HarmonyImportDependency,
-  HarmonyImportSideEffectDependency, HarmonyImportSpecifierDependency, Specifier,
+  HarmonyImportSpecifierDependency, Specifier,
 };
 
 pub struct ImporterReferenceInfo {
@@ -120,10 +120,6 @@ impl Visit for HarmonyImportDependencyScanner<'_> {
           dependency_type,
           importer_info.exports_all,
         )));
-      // TODO merge HarmonyImportSideEffectDependency and HarmonyImportDependency
-      self
-        .dependencies
-        .push(Box::new(HarmonyImportSideEffectDependency::new(request)));
     }
 
     // collect import reference info