fix(mf): preserve aliased remote and shared manifest links

Author: ScriptedAlchemy

crates/rspack_plugin_mf/src/manifest/mod.rs

@@ -527,7 +527,7 @@ async fn process_assets(&self, compilation: &mut Compilation) -> Result<()> {
           }
           record_shared_usage(
             &mut shared_usage_links,
-            &pkg,
+            &manifest_name,
             &module_identifier,
             module_graph,
             compilation,
@@ -811,7 +811,7 @@ async fn process_assets(&self, compilation: &mut Compilation) -> Result<()> {
       }
       let rsc = build_rsc_reference_meta_from_modules(
         compilation,
-        compose_remote_lookup(&federation_container_name, &module_name),
+        compose_remote_lookup(&alias, &module_name),
         remote_usage_module_ids.into_iter(),
       );
       remote_list.push(StatsRemote {

crates/rspack_plugin_mf/src/manifest/utils.rs

@@ -139,11 +139,11 @@ pub fn compose_expose_lookup(container: &str, expose_path: &str) -> String {
   format!("{container}/{expose_key}")
 }
 
-pub fn compose_remote_lookup(federation_container_name: &str, module_name: &str) -> String {
+pub fn compose_remote_lookup(remote_alias: &str, module_name: &str) -> String {
   if module_name.is_empty() || module_name == "." {
-    federation_container_name.to_string()
+    remote_alias.to_string()
   } else {
-    format!("{federation_container_name}/{module_name}")
+    format!("{remote_alias}/{module_name}")
   }
 }
 

tests/rspack-test/configCases/container-1-5/manifest-rsc-references/exposed-client.js

@@ -1,6 +1,6 @@
 "use client";
 
-import remoteButton from "remote/Button";
+import remoteButton from "@remote/alias/Button";
 import { SharedClientComponent, sharedAction, sharedValue } from "shared-rsc";
 
 export default function ExposedButton() {

tests/rspack-test/configCases/container-1-5/manifest-rsc-references/index.js

@@ -12,6 +12,9 @@ it("should capture RSC references for shared modules by package key", () => {
 	expect(shared.shareKey).toBe("rsc-shared-key");
 	expect(shared.rsc).toBeDefined();
 	expect(shared.rsc.lookup).toBe(shared.shareKey);
+	expect(shared.usedIn).toEqual(
+		expect.arrayContaining(["exposed-client.js", "rsc-consumer.js"])
+	);
 	expect(shared.rsc.moduleType).toBe("client");
 	expect(shared.rsc.clientReferences).toEqual(
 		expect.arrayContaining(["SharedClientComponent", "sharedAction", "sharedValue"])
@@ -28,16 +31,17 @@ it("should capture RSC references for exposes by remoteName/exposeKey", () => {
 	expect(expose.rsc.clientReferences).toEqual(
 		expect.arrayContaining(["default", "exposedAction"])
 	);
+	expect(expose.requires).toContain("shared-rsc");
 	expect(expose.rsc.serverActions.length).toBeGreaterThan(0);
 });
 
 it("should capture RSC context for remote module consumption", () => {
 	const remoteButton = stats.remotes.find(
-		item => item.alias === "remote" && item.moduleName === "Button"
+		item => item.alias === "@remote/alias" && item.moduleName === "Button"
 	);
 	expect(remoteButton).toBeDefined();
 	expect(remoteButton.rsc).toBeDefined();
-	expect(remoteButton.rsc.lookup).toBe("remote/Button");
+	expect(remoteButton.rsc.lookup).toBe("@remote/alias/Button");
 	expect(remoteButton.rsc.moduleType).toBe("server");
 });
 
@@ -66,10 +70,10 @@ it("should persist RSC metadata in mf-manifest.json", () => {
 	expect(manifest.remotes).toEqual(
 		expect.arrayContaining([
 			expect.objectContaining({
-				alias: "remote",
+				alias: "@remote/alias",
 				moduleName: "Button",
 				rsc: expect.objectContaining({
-					lookup: "remote/Button"
+					lookup: "@remote/alias/Button"
 				})
 			})
 		])

tests/rspack-test/configCases/container-1-5/manifest-rsc-references/rsc-consumer.js

@@ -1,6 +1,6 @@
 "use server";
 
-import remoteButton from "remote/Button";
+import remoteButton from "@remote/alias/Button";
 import { sharedAction, sharedValue } from "shared-rsc";
 
 export async function consumeRemoteAndShared() {

tests/rspack-test/configCases/container-1-5/manifest-rsc-references/rspack.config.js

@@ -67,7 +67,7 @@ module.exports = {
 			},
 			remoteType: "script",
 			remotes: {
-				remote: "remote@http://localhost:8000/remoteEntry.js"
+				"@remote/alias": "remote@http://localhost:8000/remoteEntry.js"
 			},
 			shared: {
 				"shared-rsc": {