Skip to content

Commit 856ac99

Browse files
committed
refactor: merge binding crates into rspack_binding_values
1 parent 27aed6f commit 856ac99

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+1133
-185
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ pnpm-lock.yaml
2828
/crates/node_binding
2929
/crates/rspack_ast_viewer
3030
/crates/rspack_base64
31-
/crates/rspack_binding_options
3231
/crates/rspack_core
3332
/crates/rspack_core/src/compiler/make @jerrykingxyz
3433
/crates/rspack_error

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ jobs:
319319
320320
- name: Run test
321321
# reason for excluding https://github.com/napi-rs/napi-rs/issues/2200
322-
run: cargo test --workspace --exclude rspack_binding_options --exclude rspack_node -- --nocapture
322+
run: cargo test --workspace --exclude rspack_node -- --nocapture
323323

324324
rust_test_miri:
325325
name: Rust test miri
@@ -350,7 +350,7 @@ jobs:
350350
env:
351351
MIRIFLAGS: -Zmiri-tree-borrows -Zmiri-disable-isolation
352352
# reason for excluding https://github.com/napi-rs/napi-rs/issues/2200
353-
run: cargo miri test --workspace --exclude rspack_binding_options --exclude rspack_node -- --nocapture
353+
run: cargo miri test --workspace --exclude rspack_node -- --nocapture
354354

355355
run_rust_benchmark:
356356
name: Run rust benchmark

Cargo.lock

Lines changed: 4 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ rspack_allocator = { version = "0.2.0", path = "crates/rsp
110110
rspack_ast = { version = "0.2.0", path = "crates/rspack_ast" }
111111
rspack_base64 = { version = "0.2.0", path = "crates/rspack_base64" }
112112
rspack_binding = { version = "0.2.0", path = "crates/rspack_binding" }
113-
rspack_binding_options = { version = "0.2.0", path = "crates/rspack_binding_options" }
114113
rspack_binding_values = { version = "0.2.0", path = "crates/rspack_binding_values" }
115114
rspack_builtin = { version = "0.2.0", path = "crates/rspack_builtin" }
116115
rspack_cacheable = { version = "0.2.0", path = "crates/rspack_cacheable" }

crates/node_binding/Cargo.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,11 @@ version = "0.2.0"
1010
crate-type = ["cdylib"]
1111

1212
[features]
13-
default = []
14-
plugin = ["rspack_binding_options/plugin"]
13+
plugin = ["rspack_binding_values/plugin"]
1514

1615
[dependencies]
1716
ropey = { workspace = true }
1817
rspack_allocator = { workspace = true }
19-
rspack_binding_options = { workspace = true }
2018
rspack_binding_values = { workspace = true }
2119
rspack_collections = { workspace = true }
2220
rspack_core = { workspace = true }

0 commit comments

Comments
 (0)