refactor: remove unused parameters and clean up code (#11756)

chenjiahan · web-flow · commit 9d1fe87b0f82 · 2025-09-25T14:12:34.000+08:00
diff --git a/packages/rspack/etc/core.api.md b/packages/rspack/etc/core.api.md
@@ -6916,7 +6916,7 @@ export const RuntimeGlobals: {
 export class RuntimeModule {
     constructor(name: string, stage?: RuntimeModuleStage);
     // (undocumented)
-    static __to_binding(compilation: Compilation, module: RuntimeModule): JsAddingRuntimeModule;
+    static __to_binding(module: RuntimeModule): JsAddingRuntimeModule;
     // (undocumented)
     attach(compilation: Compilation, chunk: Chunk, chunkGraph: ChunkGraph): void;
     // (undocumented)
diff --git a/packages/rspack/src/Compilation.ts b/packages/rspack/src/Compilation.ts
@@ -302,8 +302,7 @@ export class Compilation {
 		const createProcessAssetsHook = <T>(
 			name: string,
 			stage: number,
-			getArgs: () => liteTapable.AsArray<T>,
-			code?: string
+			getArgs: () => liteTapable.AsArray<T>
 		) => {
 			const errorMessage = (
 				reason: string
@@ -977,7 +976,7 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
 		runtimeModule.attach(this, chunk, this.chunkGraph);
 		this.#inner.addRuntimeModule(
 			chunk,
-			RuntimeModule.__to_binding(this, runtimeModule)
+			RuntimeModule.__to_binding(runtimeModule)
 		);
 	}
 
diff --git a/packages/rspack/src/ExecuteModulePlugin.ts b/packages/rspack/src/ExecuteModulePlugin.ts
@@ -52,10 +52,9 @@ const printGeneratedCodeForStack = (moduleId: string, code: string) => {
 			/**
 			 * @param {string} line the line
 			 * @param {number} i the index
-			 * @param {string[]} lines the lines
 			 * @returns {string} the line with line number
 			 */
-			(line, i, lines) => {
+			(line, i) => {
 				const iStr = `${i + 1}`;
 				return `${" ".repeat(n - iStr.length)}${iStr} | ${line}`;
 			}
diff --git a/packages/rspack/src/RuntimeModule.ts b/packages/rspack/src/RuntimeModule.ts
@@ -16,10 +16,7 @@ export class RuntimeModule {
 	static STAGE_ATTACH = RuntimeModuleStage.ATTACH;
 	static STAGE_TRIGGER = RuntimeModuleStage.TRIGGER;
 
-	static __to_binding(
-		compilation: Compilation,
-		module: RuntimeModule
-	): JsAddingRuntimeModule {
+	static __to_binding(module: RuntimeModule): JsAddingRuntimeModule {
 		return {
 			name: module.name,
 			stage: module.stage,
diff --git a/packages/rspack/src/builtin-plugin/DeterministicChunkIdsPlugin.ts b/packages/rspack/src/builtin-plugin/DeterministicChunkIdsPlugin.ts
@@ -1,12 +1,11 @@
 import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";
-import type { Compiler } from "../Compiler";
 import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";
 
 export class DeterministicChunkIdsPlugin extends RspackBuiltinPlugin {
 	name = BuiltinPluginName.DeterministicChunkIdsPlugin;
 	affectedHooks = "compilation" as const;
 
-	raw(compiler: Compiler): BuiltinPlugin {
+	raw(): BuiltinPlugin {
 		return createBuiltinPlugin(this.name, undefined);
 	}
 }
diff --git a/packages/rspack/src/builtin-plugin/DeterministicModuleIdsPlugin.ts b/packages/rspack/src/builtin-plugin/DeterministicModuleIdsPlugin.ts
@@ -1,12 +1,11 @@
 import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";
-import type { Compiler } from "../Compiler";
 import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";
 
 export class DeterministicModuleIdsPlugin extends RspackBuiltinPlugin {
 	name = BuiltinPluginName.DeterministicModuleIdsPlugin;
 	affectedHooks = "compilation" as const;
 
-	raw(compiler: Compiler): BuiltinPlugin {
+	raw(): BuiltinPlugin {
 		return createBuiltinPlugin(this.name, undefined);
 	}
 }
diff --git a/packages/rspack/src/builtin-plugin/FlagDependencyUsagePlugin.ts b/packages/rspack/src/builtin-plugin/FlagDependencyUsagePlugin.ts
@@ -1,5 +1,4 @@
 import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";
-import type { Compiler } from "../Compiler";
 import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";
 
 export class FlagDependencyUsagePlugin extends RspackBuiltinPlugin {
@@ -10,7 +9,7 @@ export class FlagDependencyUsagePlugin extends RspackBuiltinPlugin {
 		super();
 	}
 
-	raw(compiler: Compiler): BuiltinPlugin {
+	raw(): BuiltinPlugin {
 		return createBuiltinPlugin(this.name, this.global);
 	}
 }
diff --git a/packages/rspack/src/builtin-plugin/MangleExportsPlugin.ts b/packages/rspack/src/builtin-plugin/MangleExportsPlugin.ts
@@ -1,5 +1,4 @@
 import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";
-import type { Compiler } from "../Compiler";
 import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";
 
 export class MangleExportsPlugin extends RspackBuiltinPlugin {
@@ -10,7 +9,7 @@ export class MangleExportsPlugin extends RspackBuiltinPlugin {
 		super();
 	}
 
-	raw(compiler: Compiler): BuiltinPlugin {
+	raw(): BuiltinPlugin {
 		return createBuiltinPlugin(this.name, this.deterministic);
 	}
 }
diff --git a/packages/rspack/src/builtin-plugin/ModuleConcatenationPlugin.ts b/packages/rspack/src/builtin-plugin/ModuleConcatenationPlugin.ts
@@ -1,12 +1,11 @@
 import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";
-import type { Compiler } from "../Compiler";
 import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";
 
 export class ModuleConcatenationPlugin extends RspackBuiltinPlugin {
 	name = BuiltinPluginName.ModuleConcatenationPlugin;
 	affectedHooks = "compilation" as const;
 
-	raw(compiler: Compiler): BuiltinPlugin {
+	raw(): BuiltinPlugin {
 		return createBuiltinPlugin(this.name, undefined);
 	}
 }
diff --git a/packages/rspack/src/builtin-plugin/NaturalChunkIdsPlugin.ts b/packages/rspack/src/builtin-plugin/NaturalChunkIdsPlugin.ts
@@ -1,12 +1,11 @@
 import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";
-import type { Compiler } from "../Compiler";
 import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";
 
 export class NaturalChunkIdsPlugin extends RspackBuiltinPlugin {
 	name = BuiltinPluginName.NaturalChunkIdsPlugin;
 	affectedHooks = "compilation" as const;
 
-	raw(compiler: Compiler): BuiltinPlugin {
+	raw(): BuiltinPlugin {
 		return createBuiltinPlugin(this.name, undefined);
 	}
 }
diff --git a/packages/rspack/src/builtin-plugin/NaturalModuleIdsPlugin.ts b/packages/rspack/src/builtin-plugin/NaturalModuleIdsPlugin.ts
@@ -1,12 +1,11 @@
 import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";
-import type { Compiler } from "../Compiler";
 import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";
 
 export class NaturalModuleIdsPlugin extends RspackBuiltinPlugin {
 	name = BuiltinPluginName.NaturalModuleIdsPlugin;
 	affectedHooks = "compilation" as const;
 
-	raw(compiler: Compiler): BuiltinPlugin {
+	raw(): BuiltinPlugin {
 		return createBuiltinPlugin(this.name, undefined);
 	}
 }
diff --git a/packages/rspack/src/builtin-plugin/RsdoctorPlugin.ts b/packages/rspack/src/builtin-plugin/RsdoctorPlugin.ts
@@ -153,7 +153,7 @@ RsdoctorPlugin.getHooks = RsdoctorPlugin.getCompilationHooks = (
 
 export const createRsdoctorPluginHooksRegisters: CreatePartialRegisters<
 	`RsdoctorPlugin`
-> = (getCompiler, createTap, createMapTap) => {
+> = (getCompiler, createTap) => {
 	return {
 		registerRsdoctorPluginModuleGraphTaps: createTap(
 			RegisterJsTapKind.RsdoctorPluginModuleGraph,
diff --git a/packages/rspack/src/builtin-plugin/RuntimePlugin.ts b/packages/rspack/src/builtin-plugin/RuntimePlugin.ts
@@ -48,7 +48,7 @@ RuntimePlugin.getHooks = RuntimePlugin.getCompilationHooks = (
 
 export const createRuntimePluginHooksRegisters: CreatePartialRegisters<
 	`RuntimePlugin`
-> = (getCompiler, createTap, createMapTap) => {
+> = (getCompiler, createTap) => {
 	return {
 		registerRuntimePluginCreateScriptTaps: createTap(
 			binding.RegisterJsTapKind.RuntimePluginCreateScript,
diff --git a/packages/rspack/src/builtin-plugin/html-plugin/taps.ts b/packages/rspack/src/builtin-plugin/html-plugin/taps.ts
@@ -5,7 +5,7 @@ import { HtmlRspackPlugin } from "./plugin";
 
 export const createHtmlPluginHooksRegisters: CreatePartialRegisters<
 	`HtmlPlugin`
-> = (getCompiler, createTap, createMapTap) => {
+> = (getCompiler, createTap) => {
 	const getOptions = (uid: number): HtmlRspackPluginOptions => {
 		return getPluginOptions(getCompiler().__internal__get_compilation()!, uid)!;
 	};
diff --git a/packages/rspack/src/config/defaults.ts b/packages/rspack/src/config/defaults.ts
@@ -95,7 +95,6 @@ export const applyRspackOptionsDefaults = (
 	}
 
 	applyExperimentsDefaults(options.experiments, {
-		production,
 		development
 	});
 
@@ -208,7 +207,7 @@ const applyInfrastructureLoggingDefaults = (
 
 const applyExperimentsDefaults = (
 	experiments: ExperimentsNormalized,
-	{ production, development }: { production: boolean; development: boolean }
+	{ development }: { development: boolean }
 ) => {
 	// IGNORE(experiments.cache): In webpack, cache is undefined by default
 	F(experiments, "cache", () => development);
diff --git a/packages/rspack/src/stats/DefaultStatsFactoryPlugin.ts b/packages/rspack/src/stats/DefaultStatsFactoryPlugin.ts
@@ -1022,7 +1022,7 @@ const SIMPLE_EXTRACTORS: SimpleExtractors = {
 			object,
 			compilation,
 			context: KnownStatsFactoryContext,
-			{ chunkGroupAuxiliary, chunkGroupChildren },
+			_,
 			factory
 		) => {
 			const { type, getStatsCompilation } = context;
@@ -1465,13 +1465,7 @@ const SIMPLE_EXTRACTORS: SimpleExtractors = {
 	error: EXTRACT_ERROR,
 	warning: EXTRACT_ERROR,
 	moduleTraceItem: {
-		_: (
-			object,
-			{ origin, module, dependencies },
-			context,
-			{ requestShortener },
-			factory
-		) => {
+		_: (object, { origin, module, dependencies }, context, _, factory) => {
 			const { type } = context;
 			if (origin.moduleDescriptor) {
 				object.originIdentifier = origin.moduleDescriptor.identifier;
diff --git a/packages/rspack/src/stats/DefaultStatsPresetPlugin.ts b/packages/rspack/src/stats/DefaultStatsPresetPlugin.ts
@@ -168,7 +168,7 @@ const DEFAULTS: StatsDefault = {
 	chunkGroups: OFF_FOR_TO_STRING,
 	chunkGroupAuxiliary: OFF_FOR_TO_STRING,
 	chunkGroupChildren: OFF_FOR_TO_STRING,
-	chunkGroupMaxAssets: (o, { forToString }) =>
+	chunkGroupMaxAssets: (_, { forToString }) =>
 		forToString ? 5 : Number.POSITIVE_INFINITY,
 	chunks: OFF_FOR_TO_STRING,
 	chunkRelations: OFF_FOR_TO_STRING,
@@ -194,19 +194,19 @@ const DEFAULTS: StatsDefault = {
 	groupModulesByAttributes: ON_FOR_TO_STRING,
 	groupModulesByPath: ON_FOR_TO_STRING,
 	groupModulesByExtension: ON_FOR_TO_STRING,
-	modulesSpace: (o, { forToString }) =>
+	modulesSpace: (_, { forToString }) =>
 		forToString ? 15 : Number.POSITIVE_INFINITY,
-	chunkModulesSpace: (o, { forToString }) =>
+	chunkModulesSpace: (_, { forToString }) =>
 		forToString ? 10 : Number.POSITIVE_INFINITY,
-	nestedModulesSpace: (o, { forToString }) =>
+	nestedModulesSpace: (_, { forToString }) =>
 		forToString ? 10 : Number.POSITIVE_INFINITY,
 	relatedAssets: OFF_FOR_TO_STRING,
 	groupAssetsByEmitStatus: ON_FOR_TO_STRING,
 	groupAssetsByInfo: ON_FOR_TO_STRING,
 	groupAssetsByPath: ON_FOR_TO_STRING,
 	groupAssetsByExtension: ON_FOR_TO_STRING,
 	groupAssetsByChunk: ON_FOR_TO_STRING,
-	assetsSpace: (o, { forToString }) =>
+	assetsSpace: (_, { forToString }) =>
 		forToString ? 15 : Number.POSITIVE_INFINITY,
 	orphanModules: OFF_FOR_TO_STRING,
 	runtimeModules: ({ all, runtime }, { forToString }) =>
@@ -221,7 +221,7 @@ const DEFAULTS: StatsDefault = {
 	depth: OFF_FOR_TO_STRING,
 	cachedAssets: OFF_FOR_TO_STRING,
 	reasons: OFF_FOR_TO_STRING,
-	reasonsSpace: (o, { forToString }) =>
+	reasonsSpace: (_, { forToString }) =>
 		forToString ? 15 : Number.POSITIVE_INFINITY,
 	groupReasonsByOrigin: ON_FOR_TO_STRING,
 	usedExports: OFF_FOR_TO_STRING,
@@ -322,7 +322,7 @@ export class DefaultStatsPresetPlugin {
 				const defaults = NAMED_PRESETS[key as keyof typeof NAMED_PRESETS];
 				compilation.hooks.statsPreset
 					.for(key)
-					.tap("DefaultStatsPresetPlugin", (options, context) => {
+					.tap("DefaultStatsPresetPlugin", options => {
 						applyDefaults(options, defaults);
 					});
 			}
diff --git a/packages/rspack/src/stats/DefaultStatsPrinterPlugin.ts b/packages/rspack/src/stats/DefaultStatsPrinterPlugin.ts
@@ -287,10 +287,8 @@ const SIMPLE_PRINTERS: Record<
 	"asset.type": type => type,
 	"asset.name": (name, { formatFilename, asset: { isOverSizeLimit } }) =>
 		formatFilename(name, isOverSizeLimit),
-	"asset.size": (
-		size,
-		{ asset: { isOverSizeLimit }, yellow, green, formatSize }
-	) => (isOverSizeLimit ? yellow(formatSize(size)) : formatSize(size)),
+	"asset.size": (size, { asset: { isOverSizeLimit }, yellow, formatSize }) =>
+		isOverSizeLimit ? yellow(formatSize(size)) : formatSize(size),
 	"asset.emitted": (emitted, { green, formatFlag }) =>
 		emitted ? green(formatFlag("emitted")) : undefined,
 	"asset.comparedForEmit": (comparedForEmit, { yellow, formatFlag }) =>
diff --git a/packages/rspack/src/taps/compiler.ts b/packages/rspack/src/taps/compiler.ts
@@ -3,7 +3,7 @@ import type { CreatePartialRegisters } from "./types";
 
 export const createCompilerHooksRegisters: CreatePartialRegisters<
 	`Compiler`
-> = (getCompiler, createTap, createMapTap) => {
+> = (getCompiler, createTap) => {
 	return {
 		registerCompilerThisCompilationTaps: createTap(
 			binding.RegisterJsTapKind.CompilerThisCompilation,
diff --git a/packages/rspack/src/taps/contextModuleFactory.ts b/packages/rspack/src/taps/contextModuleFactory.ts
@@ -7,7 +7,7 @@ import type { CreatePartialRegisters } from "./types";
 
 export const createContextModuleFactoryHooksRegisters: CreatePartialRegisters<
 	`ContextModuleFactory`
-> = (getCompiler, createTap, createMapTap) => {
+> = (getCompiler, createTap) => {
 	return {
 		registerContextModuleFactoryBeforeResolveTaps: createTap(
 			binding.RegisterJsTapKind.ContextModuleFactoryBeforeResolve,
diff --git a/packages/rspack/src/taps/javascriptModules.ts b/packages/rspack/src/taps/javascriptModules.ts
@@ -5,7 +5,7 @@ import type { CreatePartialRegisters } from "./types";
 
 export const createJavaScriptModulesHooksRegisters: CreatePartialRegisters<
 	`JavascriptModules`
-> = (getCompiler, createTap, createMapTap) => {
+> = (getCompiler, createTap) => {
 	return {
 		registerJavascriptModulesChunkHashTaps: createTap(
 			binding.RegisterJsTapKind.JavascriptModulesChunkHash,
diff --git a/packages/rspack/src/util/createHash.ts b/packages/rspack/src/util/createHash.ts
@@ -119,7 +119,6 @@ class BulkUpdateDecorator extends Hash {
 	}
 }
 
-/* istanbul ignore next */
 class DebugHash extends Hash {
 	string: string;
 
@@ -136,7 +135,7 @@ class DebugHash extends Hash {
 	 */
 	update(data: string, inputEncoding: string): this;
 	update(data: Buffer): this;
-	update(data: string | Buffer, inputEncoding?: string): this {
+	update(data: string | Buffer): this {
 		let normalizedData: string;
 		if (Buffer.isBuffer(data)) {
 			normalizedData = data.toString("utf-8");
diff --git a/packages/rspack/src/util/hash/index.ts b/packages/rspack/src/util/hash/index.ts
@@ -10,42 +10,37 @@
 import { AbstractMethodError } from "../../lib/AbstractMethodError";
 
 export default class Hash {
-	/* istanbul ignore next */
 	/**
 	 * @param data data
 	 * @param inputEncoding data encoding
 	 * @returns updated hash
 	 */
 	update(data: string, inputEncoding: string): this;
 
-	/* istanbul ignore next */
 	/**
 	 * @param data data
 	 * @returns updated hash
 	 */
 	update(data: Buffer): this;
 
-	/* istanbul ignore next */
 	/**
 	 * Update hash {@link https://nodejs.org/api/crypto.html#crypto_hash_update_data_inputencoding}
 	 * @abstract
 	 * @param data data
 	 * @param inputEncoding data encoding
 	 * @returns updated hash
 	 */
-	update(data: string | Buffer, inputEncoding?: string): this {
+	update(): this {
 		throw new AbstractMethodError();
 	}
 
-	/* istanbul ignore next */
 	/**
 	 * Calculates the digest without encoding
 	 * @abstract
 	 * @returns {Buffer} digest
 	 */
 	digest(): Buffer;
 
-	/* istanbul ignore next */
 	/**
 	 * Calculates the digest with encoding
 	 * @abstract
@@ -54,13 +49,12 @@ export default class Hash {
 	 */
 	digest(encoding: string): string;
 
-	/* istanbul ignore next */
 	/**
 	 * Calculates the digest {@link https://nodejs.org/api/crypto.html#crypto_hash_digest_encoding}
 	 * @param {string=} encoding encoding of the return value
 	 * @returns {string|Buffer} digest
 	 */
-	digest(encoding?: string): string | Buffer {
+	digest(): string | Buffer {
 		throw new AbstractMethodError();
 	}
 }
diff --git a/website/components/CompatibleCard.scss b/website/components/CompatibleCard.scss
diff --git a/website/components/RspackCompatible.tsx b/website/components/RspackCompatible.tsx

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,11 @@`
`1`	`1`	`import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";`
`2`		`-import type { Compiler } from "../Compiler";`
`3`	`2`	`import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";`
`4`	`3`
`5`	`4`	`export class DeterministicChunkIdsPlugin extends RspackBuiltinPlugin {`
`6`	`5`	`name = BuiltinPluginName.DeterministicChunkIdsPlugin;`
`7`	`6`	`affectedHooks = "compilation" as const;`
`8`	`7`
`9`		`- raw(compiler: Compiler): BuiltinPlugin {`
	`8`	`+ raw(): BuiltinPlugin {`
`10`	`9`	`return createBuiltinPlugin(this.name, undefined);`
`11`	`10`	`}`
`12`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import { type BuiltinPlugin, BuiltinPluginName } from "@rspack/binding";`
`2`		`-import type { Compiler } from "../Compiler";`
`3`	`2`	`import { createBuiltinPlugin, RspackBuiltinPlugin } from "./base";`
`4`	`3`
`5`	`4`	`export class FlagDependencyUsagePlugin extends RspackBuiltinPlugin {`
`@@ -10,7 +9,7 @@ export class FlagDependencyUsagePlugin extends RspackBuiltinPlugin {`
`10`	`9`	`super();`
`11`	`10`	`}`
`12`	`11`
`13`		`- raw(compiler: Compiler): BuiltinPlugin {`
	`12`	`+ raw(): BuiltinPlugin {`
`14`	`13`	`return createBuiltinPlugin(this.name, this.global);`
`15`	`14`	`}`
`16`	`15`	`}`