fix: cjs export require tree shaking (#11758)

Author: ahabhgk

crates/rspack_plugin_javascript/src/dependency/commonjs/common_js_export_require_dependency.rs

@@ -10,7 +10,8 @@ use rspack_core::{
   ExtendedReferencedExport, FactorizeInfo, GetUsedNameParam, ModuleDependency, ModuleGraph,
   ModuleGraphCacheArtifact, ModuleIdentifier, Nullable, PrefetchExportsInfoMode, ReferencedExport,
   RuntimeGlobals, RuntimeSpec, TemplateContext, TemplateReplaceSource, UsageState, UsedName,
-  collect_referenced_export_items, module_raw, property_access, to_normal_comment,
+  collect_referenced_export_items, create_exports_object_referenced, create_no_exports_referenced,
+  module_raw, property_access, to_normal_comment,
 };
 use rustc_hash::FxHashSet;
 use swc_core::atoms::Atom;
@@ -41,6 +42,7 @@ impl CommonJsExportRequireDependency {
     range: DependencyRange,
     base: ExportsBase,
     names: Vec<Atom>,
+    ids: Vec<Atom>,
     result_used: bool,
   ) -> Self {
     Self {
@@ -50,7 +52,7 @@ impl CommonJsExportRequireDependency {
       range,
       base,
       names,
-      ids: vec![],
+      ids,
       result_used,
       factorize_info: Default::default(),
     }
@@ -296,7 +298,7 @@ impl Dependency for CommonJsExportRequireDependency {
     let ids = self.get_ids(mg);
     let get_full_result = || {
       if ids.is_empty() {
-        vec![ExtendedReferencedExport::Array(vec![])]
+        create_exports_object_referenced()
       } else {
         vec![ExtendedReferencedExport::Export(ReferencedExport {
           name: ids.to_vec(),
@@ -318,7 +320,7 @@ impl Dependency for CommonJsExportRequireDependency {
       let export_info = exports_info.get_read_only_export_info(name);
       let used = export_info.get_used(runtime);
       if matches!(used, UsageState::Unused) {
-        return vec![ExtendedReferencedExport::Array(vec![])];
+        return create_no_exports_referenced();
       }
       if !matches!(used, UsageState::OnlyPropertiesUsed) {
         return get_full_result();

crates/rspack_plugin_javascript/src/parser_plugin/common_js_exports_parse_plugin.rs

@@ -128,22 +128,22 @@ impl JavascriptParser<'_> {
 
 fn parse_require_call<'a>(
   parser: &mut JavascriptParser,
-  expr: &'a Expr,
+  mut expr: &'a Expr,
 ) -> Option<(BasicEvaluatedExpression<'a>, Vec<Atom>)> {
   let mut ids = Vec::new();
-  // while let Some(member) = expr.as_member() {
-  //   if let Some(prop) = member.prop.as_ident() {
-  //     ids.push(prop.sym.clone());
-  //   } else if let Some(prop) = member.prop.as_computed()
-  //     && let prop = parser.evaluate_expression(&*prop.expr)
-  //     && let Some(prop) = prop.as_string()
-  //   {
-  //     ids.push(prop.into());
-  //   } else {
-  //     return None;
-  //   }
-  //   expr = &*member.obj;
-  // }
+  while let Some(member) = expr.as_member() {
+    if let Some(prop) = member.prop.as_ident() {
+      ids.push(prop.sym.clone());
+    } else if let Some(prop) = member.prop.as_computed()
+      && let prop = parser.evaluate_expression(&prop.expr)
+      && let Some(prop) = prop.as_string()
+    {
+      ids.push(prop.into());
+    } else {
+      return None;
+    }
+    expr = &*member.obj;
+  }
   if let Some(call) = expr.as_call()
     && call.args.len() == 1
     && let Some(callee) = call.callee.as_expr()
@@ -172,7 +172,7 @@ fn handle_assign_export(
     return None;
   }
   if (remaining.is_empty() || remaining.first().is_some_and(|i| i != "__esModule"))
-    && let Some((arg, _ids)) = parse_require_call(parser, &assign_expr.right)
+    && let Some((arg, ids)) = parse_require_call(parser, &assign_expr.right)
     && arg.is_string()
   {
     parser.enable();
@@ -193,6 +193,7 @@ fn handle_assign_export(
       range,
       base,
       remaining.to_vec(),
+      ids,
       !parser.is_statement_level_expression(assign_expr.span()),
     )));
     return Some(true);

tests/rspack-test/normalCases/cjs-tree-shaking/reexports-check-used/exports-property-assign-require-chain.js

@@ -0,0 +1,3 @@
+exports.abc = require("./module?exports-property-assign-require-chain").abc;
+exports.def = require("./module?exports-property-assign-require-chain").def;
+exports.usedExports = require("./module?exports-property-assign-require-chain").usedExports;

tests/rspack-test/normalCases/cjs-tree-shaking/reexports-check-used/index.js

@@ -0,0 +1,4 @@
+it("should allow to reexport a imported property (exports)", () => {
+	expect(require("./exports-property-assign-require-chain").abc).toBe("abc");
+	expect(require("./exports-property-assign-require-chain").usedExports).toEqual(["abc", "usedExports"]);
+});

tests/rspack-test/normalCases/cjs-tree-shaking/reexports-check-used/module.js

@@ -0,0 +1,3 @@
+exports.abc = "abc";
+exports.def = "def";
+exports.usedExports = __webpack_exports_info__.usedExports;