fix: add unknown_context_critical option for unknown require as expression (#10329)

fix: add unknown_context_critical option for unknown require as expression (#10329)

---------

Co-authored-by: ahabhgk <[email protected]>

Author: PeterCardenas

crates/node_binding/napi-binding.d.ts

@@ -2305,6 +2305,7 @@ export interface RawJavascriptParserOptions {
   dynamicImportFetchPriority?: string
   url?: string
   exprContextCritical?: boolean
+  unknownContextCritical?: boolean
   wrappedContextCritical?: boolean
   wrappedContextRegExp?: RegExp
   exportsPresence?: string

crates/rspack/src/builder/mod.rs

@@ -1699,6 +1699,7 @@ impl ModuleOptionsBuilder {
           dynamic_import_fetch_priority: None,
           url: Some(JavascriptParserUrl::Enable),
           expr_context_critical: Some(true),
+          unknown_context_critical: Some(true),
           wrapped_context_critical: Some(false),
           wrapped_context_reg_exp: Some(RspackRegex::new(".*").expect("should initialize `Regex`")),
           strict_export_presence: Some(false),

crates/rspack/tests/snapshots/defaults__default_options.snap

@@ -1,6 +1,5 @@
 ---
 source: crates/rspack/tests/defaults.rs
-assertion_line: 16
 expression: options
 ---
 CompilerOptions {
@@ -1396,6 +1395,9 @@ CompilerOptions {
                             url: Some(
                                 Enable,
                             ),
+                            unknown_context_critical: Some(
+                                true,
+                            ),
                             expr_context_critical: Some(
                                 true,
                             ),

crates/rspack_binding_api/src/raw_options/raw_module/mod.rs

@@ -268,6 +268,7 @@ pub struct RawJavascriptParserOptions {
   pub dynamic_import_fetch_priority: Option<String>,
   pub url: Option<String>,
   pub expr_context_critical: Option<bool>,
+  pub unknown_context_critical: Option<bool>,
   pub wrapped_context_critical: Option<bool>,
   #[napi(ts_type = "RegExp")]
   pub wrapped_context_reg_exp: Option<RspackRegex>,
@@ -315,6 +316,7 @@ impl From<RawJavascriptParserOptions> for JavascriptParserOptions {
         .map(|x| DynamicImportFetchPriority::from(x.as_str())),
       url: value.url.map(|v| JavascriptParserUrl::from(v.as_str())),
       expr_context_critical: value.expr_context_critical,
+      unknown_context_critical: value.unknown_context_critical,
       wrapped_context_reg_exp: value.wrapped_context_reg_exp,
       wrapped_context_critical: value.wrapped_context_critical,
       exports_presence: value

crates/rspack_core/src/options/module.rs

@@ -266,6 +266,7 @@ pub struct JavascriptParserOptions {
   pub dynamic_import_prefetch: Option<JavascriptParserOrder>,
   pub dynamic_import_fetch_priority: Option<DynamicImportFetchPriority>,
   pub url: Option<JavascriptParserUrl>,
+  pub unknown_context_critical: Option<bool>,
   pub expr_context_critical: Option<bool>,
   pub wrapped_context_critical: Option<bool>,
   pub wrapped_context_reg_exp: Option<RspackRegex>,

crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs

@@ -363,18 +363,20 @@ impl CommonJsImportsParserPlugin {
       None,
       parser.in_try,
     );
-    *dep.critical_mut() = Some(
-      create_traceable_error(
-        "Critical dependency".into(),
-        "require function is used in a way in which dependencies cannot be statically extracted"
-          .to_string(),
-        parser.source_file,
-        ident.span().into(),
-      )
-      .with_severity(Severity::Warn)
-      .boxed()
-      .into(),
-    );
+    if let Some(true) = parser.javascript_options.unknown_context_critical {
+      *dep.critical_mut() = Some(
+        create_traceable_error(
+          "Critical dependency".into(),
+          "require function is used in a way in which dependencies cannot be statically extracted"
+            .to_string(),
+          parser.source_file,
+          ident.span().into(),
+        )
+        .with_severity(Severity::Warn)
+        .boxed()
+        .into(),
+      );
+    }
     parser.dependencies.push(Box::new(dep));
     Some(true)
   }

packages/rspack-test-tools/tests/__snapshots__/Defaults.test.js.snap

@@ -202,6 +202,7 @@ Object {
         requireResolve: true,
         strictExportPresence: false,
         typeReexportsPresence: no-tolerant,
+        unknownContextCritical: true,
         url: true,
         worker: Array [
           ...,

packages/rspack-test-tools/tests/configCases/context-module/unknown-context-critical-disabled/index.js

@@ -0,0 +1,8 @@
+it("should import context module", async () => {
+	try {
+		require(["unknown/a"], function (a) {
+			expect(a.default).toBe("a")
+		})
+	} catch (e) {
+	}
+})

packages/rspack-test-tools/tests/configCases/context-module/unknown-context-critical-disabled/rspack.config.js

@@ -0,0 +1,10 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	module: {
+		parser: {
+			javascript: {
+				unknownContextCritical: false
+			}
+		}
+	}
+};

packages/rspack-test-tools/tests/configCases/context-module/unknown-context-critical-disabled/warnings.js

@@ -0,0 +1 @@
+module.exports = []