refactor: update type definitions to fix Rslint issues (#11798)

* refactor: update type definitions to fix Rslint issues

* fix

* fix

Author: chenjiahan

package.json

@@ -33,7 +33,7 @@
     "lint:js": "pnpm run lint-ci:js --write",
     "lint-ci:js": "biome check --diagnostic-level=warn --no-errors-on-unmatched --max-diagnostics=none --error-on-warnings",
     "lint:rs": "node ./scripts/check_rust_dependency.cjs",
-    "lint:type": "rslint --config rslint.json --max-warnings=2602",
+    "lint:type": "rslint --config rslint.json --max-warnings=2486",
     "build:binding:dev": "pnpm --filter @rspack/binding run build:dev",
     "build:binding:debug": "pnpm --filter @rspack/binding run build:debug",
     "build:binding:ci": "pnpm --filter @rspack/binding run build:ci",

packages/rspack/etc/core.api.md

@@ -583,7 +583,7 @@ type CacheHookMap = Map<string, SyncBailHook<[any[], StatsFactoryContext], any>[
 export type CacheOptions = boolean;
 
 // @public (undocumented)
-type Callback_2 = (stats?: Stats | MultiStats | undefined) => any;
+type Callback_2 = (stats?: Stats | MultiStats) => any;
 
 // @public (undocumented)
 type CallbackCache<T> = (err?: WebpackError_2 | null, result?: T) => void;
@@ -671,7 +671,7 @@ export type CircularDependencyRspackPluginOptions = {
     failOnError?: boolean;
     allowAsyncCycles?: boolean;
     exclude?: RegExp;
-    ignoredConnections?: Array<[string | RegExp, string | RegExp]>;
+    ignoredConnections?: [string | RegExp, string | RegExp][];
     onDetected?(entrypoint: Module, modules: string[], compilation: Compilation): void;
     onIgnored?(entrypoint: Module, modules: string[], compilation: Compilation): void;
     onStart?(compilation: Compilation): void;
@@ -878,7 +878,7 @@ export class Compilation {
     // (undocumented)
     chunkGraph: ChunkGraph;
     // (undocumented)
-    get chunkGroups(): ReadonlyArray<ChunkGroup>;
+    get chunkGroups(): readonly ChunkGroup[];
     // (undocumented)
     get chunks(): ReadonlySet<Chunk>;
     // (undocumented)
@@ -930,7 +930,7 @@ export class Compilation {
     getAssetPath(filename: string, data?: PathData): string;
     // (undocumented)
     getAssetPathWithInfo(filename: string, data?: PathData): binding.PathWithInfo;
-    getAssets(): ReadonlyArray<Asset>;
+    getAssets(): readonly Asset[];
     // (undocumented)
     getCache(name: string): CacheFacade;
     // (undocumented)
@@ -2343,9 +2343,9 @@ export type ExperimentCacheNormalized = boolean | {
     buildDependencies: string[];
     version: string;
     snapshot: {
-        immutablePaths: Array<string | RegExp>;
-        unmanagedPaths: Array<string | RegExp>;
-        managedPaths: Array<string | RegExp>;
+        immutablePaths: (string | RegExp)[];
+        unmanagedPaths: (string | RegExp)[];
+        managedPaths: (string | RegExp)[];
     };
     storage: {
         type: "filesystem";
@@ -2361,9 +2361,9 @@ export type ExperimentCacheOptions = boolean | {
     buildDependencies?: string[];
     version?: string;
     snapshot?: {
-        immutablePaths?: Array<string | RegExp>;
-        unmanagedPaths?: Array<string | RegExp>;
-        managedPaths?: Array<string | RegExp>;
+        immutablePaths?: (string | RegExp)[];
+        unmanagedPaths?: (string | RegExp)[];
+        managedPaths?: (string | RegExp)[];
     };
     storage?: {
         type: "filesystem";
@@ -2938,10 +2938,10 @@ interface HasSpan {
 }
 
 // @public (undocumented)
-type Headers_2 = Array<{
+type Headers_2 = {
     key: string;
     value: string;
-}> | Record<string, string | string[]>;
+}[] | Record<string, string | string[]>;
 
 // @public (undocumented)
 type HistoryApiFallbackOptions = {
@@ -3002,7 +3002,7 @@ export type HotUpdateMainFilename = FilenameTemplate;
 export const HtmlRspackPlugin: typeof HtmlRspackPluginImpl & {
     getHooks: (compilation: Compilation) => HtmlRspackPluginHooks;
     getCompilationHooks: (compilation: Compilation) => HtmlRspackPluginHooks;
-    createHtmlTagObject: (tagName: string, attributes?: Record<string, string | boolean>, innerHTML?: string | undefined) => JsHtmlPluginTag;
+    createHtmlTagObject: (tagName: string, attributes?: Record<string, string | boolean>, innerHTML?: string) => JsHtmlPluginTag;
     version: number;
 };
 
@@ -4842,7 +4842,7 @@ export interface MultiCompilerOptions {
 }
 
 // @public (undocumented)
-export type MultiRspackOptions = ReadonlyArray<RspackOptions> & MultiCompilerOptions;
+export type MultiRspackOptions = readonly RspackOptions[] & MultiCompilerOptions;
 
 // @public (undocumented)
 export class MultiStats {
@@ -5150,7 +5150,7 @@ export type Optimization = {
     moduleIds?: "named" | "natural" | "deterministic";
     chunkIds?: "natural" | "named" | "deterministic" | "size" | "total-size";
     minimize?: boolean;
-    minimizer?: Array<"..." | Plugin_2>;
+    minimizer?: ("..." | Plugin_2)[];
     mergeDuplicateChunks?: boolean;
     splitChunks?: false | OptimizationSplitChunksOptions;
     runtimeChunk?: OptimizationRuntimeChunk;
@@ -5748,7 +5748,7 @@ type ProvidesV1Config = {
 };
 
 // @public (undocumented)
-type ProxyConfigArray = (ProxyConfigArrayItem | ((req?: Request_2 | undefined, res?: Response_2 | undefined, next?: NextFunction | undefined) => ProxyConfigArrayItem))[];
+type ProxyConfigArray = (ProxyConfigArrayItem | ((req?: Request_2, res?: Response_2, next?: NextFunction) => ProxyConfigArrayItem))[];
 
 // @public (undocumented)
 type ProxyConfigArrayItem = {
@@ -5975,7 +5975,7 @@ type RealPathSync = {
 // @public (undocumented)
 type RecursiveArrayOrRecord<T> = {
     [index: string]: RecursiveArrayOrRecord<T>;
-} | Array<RecursiveArrayOrRecord<T>> | T;
+} | RecursiveArrayOrRecord<T>[] | T;
 
 // @public (undocumented)
 interface RegExpLiteral extends Node_4, HasSpan {
@@ -6196,8 +6196,8 @@ const RsdoctorPluginImpl: {
 
 // @public (undocumented)
 type RsdoctorPluginOptions = {
-    moduleGraphFeatures?: boolean | Array<"graph" | "ids" | "sources">;
-    chunkGraphFeatures?: boolean | Array<"graph" | "assets">;
+    moduleGraphFeatures?: boolean | ("graph" | "ids" | "sources")[];
+    chunkGraphFeatures?: boolean | ("graph" | "assets")[];
     sourceMapFeatures?: {
         module?: boolean;
         cheap?: boolean;

packages/rspack/src/Compilation.ts

@@ -441,7 +441,7 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
 		);
 	}
 
-	get chunkGroups(): ReadonlyArray<ChunkGroup> {
+	get chunkGroups(): readonly ChunkGroup[] {
 		return this.#inner.chunkGroups;
 	}
 
@@ -570,8 +570,7 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
 			// properties in the prototype chain
 			const options: Partial<NormalizedStatsOptions> = {};
 			for (const key in optionsOrPreset) {
-				options[key as keyof NormalizedStatsOptions] =
-					optionsOrPreset[key as keyof StatsValue];
+				options[key] = optionsOrPreset[key as keyof StatsValue];
 			}
 			if (options.preset !== undefined) {
 				this.hooks.statsPreset.for(options.preset).call(options, context);
@@ -651,7 +650,7 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
 	/**
 	 * Get an array of Asset
 	 */
-	getAssets(): ReadonlyArray<Asset> {
+	getAssets(): readonly Asset[] {
 		const assets = this.#inner.getAssets();
 
 		return assets.map(asset => {

packages/rspack/src/Diagnostics.ts

@@ -125,7 +125,7 @@ export function createDiagnosticArray(
 				value: RspackError,
 				index: number,
 				array: RspackError[]
-			) => U | ReadonlyArray<U>,
+			) => U | readonly U[],
 			thisArg?: This
 		): U[] {
 			return adm.values().flatMap(callbackfn, thisArg);

packages/rspack/src/ExecuteModulePlugin.ts

@@ -15,7 +15,7 @@ export default class ExecuteModulePlugin {
 					const moduleObject = options.moduleObject;
 					const source = options.codeGenerationResult.get("javascript");
 					if (source === undefined) return;
-					const code = source as string;
+					const code = source;
 
 					try {
 						const fn = vm.runInThisContext(

packages/rspack/src/MultiCompiler.ts

@@ -51,7 +51,7 @@ export interface MultiCompilerOptions {
 	parallelism?: number;
 }
 
-export type MultiRspackOptions = ReadonlyArray<RspackOptions> &
+export type MultiRspackOptions = readonly RspackOptions[] &
 	MultiCompilerOptions;
 
 export class MultiCompiler {

packages/rspack/src/Watching.ts

@@ -320,7 +320,7 @@ export class Watching {
 					});
 					return;
 				}
-				this._done(null, this.compiler._lastCompilation!);
+				this._done(null, this.compiler._lastCompilation);
 			};
 
 			this.compiler.compile(onCompiled);
@@ -425,7 +425,7 @@ export class Watching {
 				}
 			});
 			for (const cb of cbs) cb(null);
-			this.compiler.hooks.afterDone.call(stats!);
+			this.compiler.hooks.afterDone.call(stats);
 		});
 	}
 

packages/rspack/src/builtin-loader/swc/pluginImport.ts

@@ -13,8 +13,8 @@ type RawPluginImportConfig = {
 	style?: RawStyleConfig;
 	camelToDashComponentName?: boolean;
 	transformToDefaultImport?: boolean;
-	ignoreEsComponent?: Array<string>;
-	ignoreStyleComponent?: Array<string>;
+	ignoreEsComponent?: string[];
+	ignoreStyleComponent?: string[];
 };
 
 type PluginImportConfig = {

packages/rspack/src/builtin-plugin/CircularDependencyRspackPlugin.ts

@@ -36,7 +36,7 @@ export type CircularDependencyRspackPluginOptions = {
 	 * module "app/design/components/Button.tsx". When the entry is a RegExp,
 	 * it is tested against the entire identifier.
 	 */
-	ignoredConnections?: Array<[string | RegExp, string | RegExp]>;
+	ignoredConnections?: [string | RegExp, string | RegExp][];
 	/**
 	 * Called once for every detected cycle. Providing this handler overrides the
 	 * default behavior of adding diagnostics to the compilation.

packages/rspack/src/builtin-plugin/DefinePlugin.ts

@@ -69,5 +69,5 @@ type NormalizedCodeValue = RecursiveArrayOrRecord<NormalizedCodeValuePrimitive>;
 
 type RecursiveArrayOrRecord<T> =
 	| { [index: string]: RecursiveArrayOrRecord<T> }
-	| Array<RecursiveArrayOrRecord<T>>
+	| RecursiveArrayOrRecord<T>[]
 	| T;