fix: extend modify event handling to include metadata changes (#11519)

Author: GiveMe-A-Name

crates/rspack_fs/src/watcher/disk_watcher.rs

@@ -40,9 +40,9 @@ impl DiskWatcher {
 
           let kind = match event.kind {
             EventKind::Create(_) => FsEventKind::Create,
-            EventKind::Modify(ModifyKind::Data(_) | ModifyKind::Any | ModifyKind::Name(_)) => {
-              FsEventKind::Change
-            }
+            EventKind::Modify(
+              ModifyKind::Data(_) | ModifyKind::Any | ModifyKind::Name(_) | ModifyKind::Metadata(_),
+            ) => FsEventKind::Change,
             EventKind::Remove(_) => FsEventKind::Remove,
             // TODO: handle this case /path/to/index.js -> /path/to/index.js.map
             // path/to/index.js should be removed, and path/to/index.js.map should be changed

packages/rspack-test-tools/tests/watchCases/change-event/metadata/0/index.js

@@ -0,0 +1 @@
+const a = 1;

packages/rspack-test-tools/tests/watchCases/change-event/metadata/1/_module.js

@@ -0,0 +1 @@
+// should not trigger rebuild

packages/rspack-test-tools/tests/watchCases/change-event/metadata/rspack.config.js

@@ -0,0 +1,40 @@
+const path = require("node:path");
+const fs = require("node:fs");
+
+class ShouldRebuildPlugin {
+	constructor() {
+		this.compileCount = 0;
+	}
+	apply(compiler) {
+		const targetFile = path.resolve(compiler.context, "./index.js");
+
+		compiler.hooks.done.tap(ShouldRebuildPlugin.name, _ => {
+			// After first compilation, touch the file to trigger a rebuild
+			if (this.compileCount === 0) {
+				setTimeout(() => {
+					const now = new Date();
+					fs.utimes(targetFile, now, now, err => {
+						if (err) {
+							console.error("Error updating file timestamps:", err);
+							return;
+						}
+						// Touch file to trigger rebuild
+					});
+				}, 1000);
+			}
+			this.compileCount++;
+		});
+	}
+}
+
+/**
+ * @type {import('@rspack/core').Configuration}
+ */
+const config = {
+	plugins: [new ShouldRebuildPlugin()],
+	watchOptions: {
+		aggregateTimeout: 1000
+	}
+};
+
+module.exports = config;