perf: name_for_condition for Arc<str>

Author: SyMind

crates/rspack_core/src/compilation/make/graph_updater/repair/factorize.rs

@@ -23,7 +23,7 @@ pub struct FactorizeTask {
   pub original_module_identifier: Option<ModuleIdentifier>,
   pub original_module_source: Option<BoxSource>,
   pub original_module_context: Option<Box<Context>>,
-  pub issuer: Option<Box<str>>,
+  pub issuer: Option<Arc<str>>,
   pub issuer_layer: Option<ModuleLayer>,
   pub dependencies: Vec<BoxDependency>,
   pub resolve_options: Option<Arc<Resolve>>,

crates/rspack_core/src/compilation/make/graph_updater/repair/process_dependencies.rs

@@ -101,7 +101,7 @@ impl Task<TaskContext> for ProcessDependenciesTask {
         original_module_source,
         issuer: module
           .as_normal_module()
-          .and_then(|module| module.name_for_condition()),
+          .and_then(|module| module.name_for_condition().cloned()),
         issuer_layer: module.get_layer().cloned(),
         dependencies,
         resolve_options: module.get_resolve_options(),

crates/rspack_core/src/compilation/make/module_executor/execute.rs

@@ -1,4 +1,8 @@
-use std::{collections::VecDeque, iter::once, sync::atomic::AtomicU32};
+use std::{
+  collections::VecDeque,
+  iter::once,
+  sync::{Arc, atomic::AtomicU32},
+};
 
 use itertools::Itertools;
 use rspack_collections::{DatabaseItem, Identifier, IdentifierSet, UkeySet};
@@ -19,7 +23,7 @@ use crate::{
 pub struct ExecutedRuntimeModule {
   pub identifier: Identifier,
   pub name: String,
-  pub name_for_condition: Option<String>,
+  pub name_for_condition: Option<Arc<str>>,
   pub module_type: ModuleType,
   pub size: f64,
   pub cacheable: bool,
@@ -382,7 +386,7 @@ impl Task<ExecutorTaskContext> for ExecuteTask {
         ExecutedRuntimeModule {
           identifier,
           name: runtime_module.name().to_string(),
-          name_for_condition: runtime_module.name_for_condition().map(|n| n.to_string()),
+          name_for_condition: runtime_module.name_for_condition().cloned(),
           module_type: *runtime_module.module_type(),
           cacheable: !(runtime_module.full_hash() || runtime_module.dependent_hash()),
           size: runtime_module_size

crates/rspack_core/src/concatenated_module.rs

@@ -71,7 +71,7 @@ pub struct ConcatenatedModuleHooks {
 pub struct RootModuleContext {
   pub id: ModuleIdentifier,
   pub readable_identifier: String,
-  pub name_for_condition: Option<Box<str>>,
+  pub name_for_condition: Option<Arc<str>>,
   pub lib_indent: Option<String>,
   pub resolve_options: Option<Arc<Resolve>>,
   pub code_generation_dependencies: Option<Vec<BoxModuleDependency>>,
@@ -1600,8 +1600,8 @@ impl Module for ConcatenatedModule {
     Ok(hasher.digest(&compilation.options.output.hash_digest))
   }
 
-  fn name_for_condition(&self) -> Option<Box<str>> {
-    self.root_module_ctxt.name_for_condition.clone()
+  fn name_for_condition(&self) -> Option<&Arc<str>> {
+    self.root_module_ctxt.name_for_condition.as_ref()
   }
 
   fn lib_ident(&self, _options: LibIdentOptions) -> Option<Cow<'_, str>> {

crates/rspack_core/src/module.rs

@@ -314,7 +314,7 @@ pub trait Module:
   ) -> Result<CodeGenerationResult>;
 
   /// Name matched against bundle-splitting conditions.
-  fn name_for_condition(&self) -> Option<Box<str>> {
+  fn name_for_condition(&self) -> Option<&Arc<str>> {
     // Align with https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/Module.js#L852
     None
   }

crates/rspack_core/src/module_factory.rs

@@ -17,7 +17,7 @@ pub struct ModuleFactoryCreateData {
   pub request: String,
   pub context: Context,
   pub dependencies: Vec<BoxDependency>,
-  pub issuer: Option<Box<str>>,
+  pub issuer: Option<Arc<str>>,
   pub issuer_identifier: Option<ModuleIdentifier>,
   pub issuer_layer: Option<ModuleLayer>,
   pub resolver_factory: Arc<ResolverFactory>,

crates/rspack_core/src/normal_module.rs

@@ -148,6 +148,8 @@ pub struct NormalModule {
   build_info: BuildInfo,
   build_meta: BuildMeta,
   parsed: bool,
+
+  name_for_condition: Arc<str>,
 }
 
 static DEBUG_ID: AtomicUsize = AtomicUsize::new(1);
@@ -185,6 +187,16 @@ impl NormalModule {
   ) -> Self {
     let module_type = module_type.into();
     let id = Self::create_id(&module_type, layer.as_ref(), &request);
+
+    // Align with https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/NormalModule.js#L375
+    let resource = resource_data.resource();
+    let idx = resource.find('?');
+    let name_for_condition = if let Some(idx) = idx {
+      Arc::from(resource[..idx].to_string())
+    } else {
+      Arc::from(resource.to_string())
+    };
+
     Self {
       blocks: Vec::new(),
       dependencies: Vec::new(),
@@ -214,6 +226,8 @@ impl NormalModule {
       build_meta: Default::default(),
       parsed: false,
       source_map_kind: SourceMapKind::empty(),
+
+      name_for_condition,
     }
   }
 
@@ -668,15 +682,8 @@ impl Module for NormalModule {
     Ok(hasher.digest(&compilation.options.output.hash_digest))
   }
 
-  fn name_for_condition(&self) -> Option<Box<str>> {
-    // Align with https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/NormalModule.js#L375
-    let resource = self.resource_data.resource();
-    let idx = resource.find('?');
-    if let Some(idx) = idx {
-      Some(resource[..idx].into())
-    } else {
-      Some(resource.into())
-    }
+  fn name_for_condition(&self) -> Option<&Arc<str>> {
+    Some(&self.name_for_condition)
   }
 
   fn lib_ident(&self, options: LibIdentOptions) -> Option<Cow<'_, str>> {

crates/rspack_core/src/options/module.rs

@@ -972,7 +972,7 @@ pub struct FuncUseCtx {
   pub real_resource: Option<String>,
   pub resource_query: Option<String>,
   pub resource_fragment: Option<String>,
-  pub issuer: Option<Box<str>>,
+  pub issuer: Option<Arc<str>>,
   pub issuer_layer: Option<String>,
 }
 

crates/rspack_plugin_css_chunking/src/lib.rs

@@ -1,6 +1,9 @@
 use std::{
   collections::HashSet,
-  sync::atomic::{AtomicBool, Ordering},
+  sync::{
+    Arc,
+    atomic::{AtomicBool, Ordering},
+  },
 };
 
 use rspack_collections::{
@@ -19,7 +22,7 @@ use rspack_regex::RspackRegex;
 const MIN_CSS_CHUNK_SIZE: f64 = 30_f64 * 1024_f64;
 const MAX_CSS_CHUNK_SIZE: f64 = 100_f64 * 1024_f64;
 
-fn is_global_css(name_for_condition: &Option<Box<str>>) -> bool {
+fn is_global_css(name_for_condition: Option<&str>) -> bool {
   name_for_condition.as_ref().is_some_and(|s| {
     !s.ends_with(".module.css") && !s.ends_with(".module.scss") && !s.ends_with(".module.sass")
   })
@@ -145,7 +148,7 @@ async fn optimize_chunks(&self, compilation: &mut Compilation) -> Result<Option<
     chunk_states.insert(*chunk_ukey, chunk_state);
   }
 
-  let module_infos: IdentifierMap<(f64, Option<Box<str>>)> = {
+  let module_infos: IdentifierMap<(f64, Option<Arc<str>>)> = {
     let module_graph = compilation.get_module_graph();
     let mut result = IdentifierMap::default();
     for module_identifier in chunk_states_by_module.keys() {
@@ -154,7 +157,10 @@ async fn optimize_chunks(&self, compilation: &mut Compilation) -> Result<Option<
         .module_by_identifier(module_identifier)
         .unwrap();
       let size = module.size(None, None);
-      result.insert(*module_identifier, (size, module.name_for_condition()));
+      result.insert(
+        *module_identifier,
+        (size, module.name_for_condition().cloned()),
+      );
     }
     result
   };
@@ -221,7 +227,13 @@ async fn optimize_chunks(&self, compilation: &mut Compilation) -> Result<Option<
     remaining_modules.shift_remove(&start_module_identifier);
 
     #[allow(clippy::unwrap_used)]
-    let mut global_css_mode = is_global_css(&module_infos.get(&start_module_identifier).unwrap().1);
+    let mut global_css_mode = is_global_css(
+      module_infos
+        .get(&start_module_identifier)
+        .unwrap()
+        .1
+        .as_deref(),
+    );
 
     // The current position of processing in all selected chunks
     #[allow(clippy::unwrap_used)]
@@ -324,7 +336,13 @@ async fn optimize_chunks(&self, compilation: &mut Compilation) -> Result<Option<
 
         // Global CSS must not leak into unrelated chunks
         #[allow(clippy::unwrap_used)]
-        let is_global = is_global_css(&module_infos.get(&next_module_identifier).unwrap().1);
+        let is_global = is_global_css(
+          module_infos
+            .get(&next_module_identifier)
+            .unwrap()
+            .1
+            .as_deref(),
+        );
         if is_global && global_css_mode && all_chunk_states.len() != next_chunk_states.len() {
           // Fast check: chunk groups need to be identical
           continue;

crates/rspack_plugin_extract_css/src/css_module.rs

@@ -1,4 +1,4 @@
-use std::hash::Hash;
+use std::{hash::Hash, sync::Arc};
 
 use rspack_cacheable::{cacheable, cacheable_dyn};
 use rspack_collections::{Identifiable, Identifier};
@@ -40,6 +40,8 @@ pub(crate) struct CssModule {
   dependencies: Vec<DependencyId>,
 
   identifier__: Identifier,
+
+  name_for_condition: Option<Arc<str>>,
 }
 
 impl CssModule {
@@ -56,6 +58,12 @@ impl CssModule {
     )
     .into();
 
+    let name_for_condition: Option<Arc<str>> = dep
+      .identifier
+      .split('!')
+      .next_back()
+      .map(|resource| resource.split('?').next().unwrap_or(resource).into());
+
     Self {
       identifier: dep.identifier,
       content: dep.content,
@@ -81,6 +89,7 @@ impl CssModule {
       build_meta: Default::default(),
       source_map_kind: rspack_util::source_map::SourceMapKind::empty(),
       identifier__,
+      name_for_condition,
     }
   }
 
@@ -138,12 +147,8 @@ impl Module for CssModule {
     ))
   }
 
-  fn name_for_condition(&self) -> Option<Box<str>> {
-    self
-      .identifier
-      .split('!')
-      .next_back()
-      .map(|resource| resource.split('?').next().unwrap_or(resource).into())
+  fn name_for_condition(&self) -> Option<&Arc<str>> {
+    self.name_for_condition.as_ref()
   }
 
   fn size(&self, _source_type: Option<&SourceType>, _compilation: Option<&Compilation>) -> f64 {