fix: prevent server actions from being removed in production build (#12898)

Author: SyMind

crates/rspack_plugin_rsc/src/server_plugin.rs

@@ -272,6 +272,11 @@ impl RscServerPlugin {
     let included_dependencies: Vec<(DependencyId, RuntimeSpec)> = add_ssr_modules_list
       .iter()
       .map(|injected| (*injected.add_entry.0.id(), injected.runtime.clone()))
+      .chain(
+        add_action_entry_list
+          .iter()
+          .map(|injected| (*injected.add_entry.0.id(), injected.runtime.clone())),
+      )
       .collect();
     let add_include_args: Vec<(BoxDependency, EntryOptions)> = add_ssr_modules_list
       .into_iter()

tests/rspack-test/configCases/rsc-plugin/server-actions-production/rspack.config.js

@@ -0,0 +1,104 @@
+const path = require('node:path');
+const { rspack, experiments } = require('@rspack/core');
+
+const { createPlugins, Layers } = experiments.rsc;
+const { ServerPlugin, ClientPlugin } = createPlugins();
+
+const ssrEntry = path.join(__dirname, 'src/framework/entry.ssr.js');
+const rscEntry = path.join(__dirname, 'src/framework/entry.rsc.js');
+
+const swcLoaderRule = {
+    test: /\.jsx?$/,
+    use: [
+        {
+            loader: 'builtin:swc-loader',
+            options: {
+                jsc: {
+                    parser: {
+                        syntax: 'ecmascript',
+                        jsx: true,
+                    },
+                    transform: {
+                        react: {
+                            runtime: 'automatic',
+                        },
+                    },
+                },
+                rspackExperiments: {
+                    reactServerComponents: true,
+                },
+            },
+        },
+    ],
+};
+
+module.exports = [
+    {
+        mode: 'production',
+        target: 'node',
+        entry: {
+            main: {
+                import: ssrEntry,
+            },
+        },
+        resolve: {
+            extensions: ['...', '.ts', '.tsx', '.jsx'],
+        },
+        module: {
+            rules: [
+                swcLoaderRule,
+                {
+                    resource: ssrEntry,
+                    layer: Layers.ssr,
+                },
+                {
+                    resource: rscEntry,
+                    layer: Layers.rsc,
+                    resolve: {
+                        conditionNames: ['react-server', '...'],
+                    },
+                },
+                {
+                    issuerLayer: Layers.rsc,
+                    resolve: {
+                        conditionNames: ['react-server', '...'],
+                    },
+                },
+            ],
+        },
+        plugins: [
+            new ServerPlugin(),
+            new rspack.DefinePlugin({
+                CLIENT_PATH: JSON.stringify(path.resolve(__dirname, 'src/Client.js')),
+            }),
+        ],
+        optimization: {
+            moduleIds: 'named',
+            concatenateModules: true,
+        },
+        // TODO: enable lazy compilation when it works with RSC
+        lazyCompilation: false,
+    },
+    {
+        mode: 'production',
+        target: 'web',
+        entry: {
+            main: {
+                import: './src/framework/entry.client.js',
+            },
+        },
+        resolve: {
+            extensions: ['...', '.ts', '.tsx', '.jsx'],
+        },
+        module: {
+            rules: [swcLoaderRule],
+        },
+        plugins: [new ClientPlugin()],
+        optimization: {
+            moduleIds: 'named',
+            concatenateModules: true,
+        },
+        // TODO: enable lazy compilation when it works with RSC
+        lazyCompilation: false,
+    },
+];

tests/rspack-test/configCases/rsc-plugin/server-actions-production/src/App.js

@@ -0,0 +1,12 @@
+import { add, del, get, update } from './actions';
+
+export const App = async () => {
+    await add();
+    await del();
+    await get();
+    await update();
+
+    return (
+        <h1>RSC App</h1>
+    );
+};

tests/rspack-test/configCases/rsc-plugin/server-actions-production/src/actions.js

@@ -0,0 +1,9 @@
+'use server';
+
+export async function add() { }
+
+export async function del() { }
+
+export async function get() { }
+
+export async function update() { }

tests/rspack-test/configCases/rsc-plugin/server-actions-production/src/framework/entry.client.js

@@ -0,0 +1,2 @@
+// In a real app this entry would consume the RSC payload and hydrate.
+// This file exists mainly to mirror the typical split of RSC/SSR/client entries.

tests/rspack-test/configCases/rsc-plugin/server-actions-production/src/framework/entry.rsc.js

@@ -0,0 +1,25 @@
+import {
+    loadServerAction,
+    renderToReadableStream,
+} from 'react-server-dom-rspack/server';
+import { App } from '../App';
+
+export const renderRscStream = () => {
+    return renderToReadableStream(<App />);
+};
+
+it('should preserve all server actions in production build', async () => {
+    const manifest = __rspack_rsc_manifest__;
+    expect(manifest).toBeDefined();
+
+    const { serverManifest } = manifest;
+    expect(serverManifest).toBeDefined();
+
+    const actionIds = Object.keys(serverManifest);
+    expect(actionIds).toHaveLength(4);
+
+    // Ensure all collected actions are loadable server actions.
+    actionIds.forEach((actionId) => {
+        expect(loadServerAction(actionId)).toEqual(expect.any(Function));
+    });
+});

tests/rspack-test/configCases/rsc-plugin/server-actions-production/src/framework/entry.ssr.js

@@ -0,0 +1,9 @@
+import { createFromReadableStream } from 'react-server-dom-rspack/client';
+import { renderRscStream } from './entry.rsc';
+
+export const renderHTML = async () => {
+    // In real SSR, the HTML renderer would consume the RSC stream.
+    // For this test case we just ensure the pipeline can be invoked.
+    const rscStream = await renderRscStream();
+    return createFromReadableStream(rscStream);
+};