fix: js api module readable identifier (#10929)

Author: SyMind

crates/rspack_binding_api/src/module.rs

@@ -304,12 +304,11 @@ impl Module {
 impl Module {
   #[napi]
   pub fn readable_identifier(&mut self) -> napi::Result<String> {
-    let (_, module) = self.as_ref()?;
+    let (compilation, module) = self.as_ref()?;
     Ok(
       module
-        .get_context()
-        .map(|ctx| module.readable_identifier(ctx.as_ref()).to_string())
-        .unwrap_or_default(),
+        .readable_identifier(&compilation.options.context)
+        .to_string(),
     )
   }
 

packages/rspack-test-tools/tests/configCases/normal-module/readable-identifier/bar.js

@@ -0,0 +1 @@
+console.log("bar");

packages/rspack-test-tools/tests/configCases/normal-module/readable-identifier/index.js

@@ -0,0 +1,2 @@
+import "foo";
+import "./bar"

packages/rspack-test-tools/tests/configCases/normal-module/readable-identifier/node_modules/foo/index.js

@@ -0,0 +1,25 @@
+const path = require("path");
+
+class Plugin {
+    /**
+     * @param {import("@rspack/core").Compiler} compiler
+     */
+    apply(compiler) {
+        compiler.hooks.finishMake.tap("PLUGIN", compilation => {
+            for (const module of compilation.modules) {
+                if (module.resource === path.join(__dirname, "bar.js")) {
+                    expect(module.readableIdentifier()).toBe("./bar.js");
+                }
+                if (module.resource === path.join(__dirname, "node_modules/foo/index.js")) {
+                    expect(module.readableIdentifier()).toBe("./node_modules/foo/index.js");
+                }
+            }
+        });
+    }
+}
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+    entry: "./index.js",
+    plugins: [new Plugin()]
+};