perf: reduce BuildMeta size (#4027)

Author: underfin

crates/rspack_core/src/module.rs

@@ -1,3 +1,4 @@
+use std::fmt::Display;
 use std::hash::Hash;
 use std::path::PathBuf;
 use std::{any::Any, borrow::Cow, fmt::Debug};
@@ -62,36 +63,52 @@ pub enum BuildMetaDefaultObject {
   RedirectWarn,
 }
 
-#[derive(Debug, Clone, Hash)]
+#[derive(Debug, Default, Clone, Copy, Hash)]
+pub enum ModuleArgument {
+  #[default]
+  Module,
+  WebpackModule,
+}
+
+impl Display for ModuleArgument {
+  fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+    match self {
+      ModuleArgument::Module => write!(f, "module"),
+      ModuleArgument::WebpackModule => write!(f, "__webpack_module__"),
+    }
+  }
+}
+
+#[derive(Debug, Default, Clone, Copy, Hash)]
+pub enum ExportsArgument {
+  #[default]
+  Exports,
+  WebpackExports,
+}
+
+impl Display for ExportsArgument {
+  fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+    match self {
+      ExportsArgument::Exports => write!(f, "exports"),
+      ExportsArgument::WebpackExports => write!(f, "__webpack_exports__"),
+    }
+  }
+}
+
+#[derive(Debug, Default, Clone, Hash)]
 pub struct BuildMeta {
   pub strict: bool,
   pub strict_harmony_module: bool,
   pub is_async: bool,
   pub esm: bool,
   pub exports_type: BuildMetaExportsType,
   pub default_object: BuildMetaDefaultObject,
-  pub module_argument: &'static str,
-  pub exports_argument: &'static str,
+  pub module_argument: ModuleArgument,
+  pub exports_argument: ExportsArgument,
   // TODO: Don't delete this comment, it will be used in near future
   // pub side_effect_free: bool,
 }
 
-impl Default for BuildMeta {
-  fn default() -> Self {
-    Self {
-      strict: Default::default(),
-      strict_harmony_module: Default::default(),
-      is_async: Default::default(),
-      esm: Default::default(),
-      exports_type: Default::default(),
-      default_object: Default::default(),
-      module_argument: "module",
-      exports_argument: "exports",
-      // side_effect_free: false,
-    }
-  }
-}
-
 // webpack build info
 #[derive(Debug, Default, Clone)]
 pub struct BuildResult {

crates/rspack_core/src/module_graph_module.rs

@@ -3,9 +3,9 @@ use rustc_hash::FxHashSet as HashSet;
 
 use crate::{
   is_async_dependency, module_graph::ConnectionId, BuildInfo, BuildMeta, BuildMetaDefaultObject,
-  BuildMetaExportsType, ChunkGraph, ChunkGroupOptions, DependencyId, ExportsInfo, ExportsType,
-  FactoryMeta, ModuleGraph, ModuleGraphConnection, ModuleIdentifier, ModuleIssuer, ModuleProfile,
-  ModuleSyntax, ModuleType,
+  BuildMetaExportsType, ChunkGraph, ChunkGroupOptions, DependencyId, ExportsArgument, ExportsInfo,
+  ExportsType, FactoryMeta, ModuleArgument, ModuleGraph, ModuleGraphConnection, ModuleIdentifier,
+  ModuleIssuer, ModuleProfile, ModuleSyntax, ModuleType,
 };
 
 #[derive(Debug)]
@@ -196,20 +196,20 @@ impl ModuleGraphModule {
     &self.issuer
   }
 
-  pub fn get_exports_argument(&self) -> &str {
+  pub fn get_exports_argument(&self) -> ExportsArgument {
     self
       .build_meta
       .as_ref()
       .map(|m| m.exports_argument)
-      .unwrap_or("exports")
+      .unwrap_or_default()
   }
 
-  pub fn get_module_argument(&self) -> &str {
+  pub fn get_module_argument(&self) -> ModuleArgument {
     self
       .build_meta
       .as_ref()
       .map(|m| m.module_argument)
-      .unwrap_or("module")
+      .unwrap_or_default()
   }
 
   pub fn get_exports_type(&self, strict: bool) -> ExportsType {

crates/rspack_plugin_javascript/src/dependency/module_argument_dependency.rs

@@ -42,7 +42,7 @@ impl DependencyTemplate for ModuleArgumentDependency {
         None,
       );
     } else {
-      source.replace(self.start, self.end, module_argument, None);
+      source.replace(self.start, self.end, &format!("{module_argument}"), None);
     }
   }
 }

crates/rspack_plugin_javascript/src/visitors/dependency/harmony_detection_scanner.rs

@@ -1,4 +1,7 @@
-use rspack_core::{BuildInfo, BuildMeta, BuildMetaExportsType, DependencyTemplate, ModuleType};
+use rspack_core::{
+  BuildInfo, BuildMeta, BuildMetaExportsType, DependencyTemplate, ExportsArgument, ModuleArgument,
+  ModuleType,
+};
 use swc_core::ecma::ast::{ModuleItem, Program};
 use swc_core::ecma::visit::{noop_visit_type, Visit};
 
@@ -43,12 +46,12 @@ impl Visit for HarmonyDetectionScanner<'_> {
       self.build_meta.esm = true;
       self.build_meta.exports_type = BuildMetaExportsType::Namespace;
       self.build_info.strict = true;
-      self.build_meta.exports_argument = "__webpack_exports__";
+      self.build_meta.exports_argument = ExportsArgument::WebpackExports;
     }
 
     if strict_harmony_module {
       self.build_meta.strict_harmony_module = true;
-      self.build_meta.module_argument = "__webpack_module__";
+      self.build_meta.module_argument = ModuleArgument::WebpackModule;
     }
   }
 }