feat: split chunks overall filename (#9243)

Author: ahabhgk

crates/node_binding/binding.d.ts

@@ -2213,6 +2213,7 @@ export interface RawSplitChunkSizes {
 export interface RawSplitChunksOptions {
   fallbackCacheGroup?: RawFallbackCacheGroupOptions
   name?: string | false | Function
+  filename?: JsFilename
   cacheGroups?: Array<RawCacheGroupOptions>
   /** What kind of chunks should be selected. */
   chunks?: RegExp | 'async' | 'initial' | 'all' | Function

crates/rspack_binding_values/src/raw_options/raw_split_chunks/mod.rs

@@ -33,6 +33,7 @@ pub struct RawSplitChunksOptions {
   #[napi(ts_type = "string | false | Function")]
   #[debug(skip)]
   pub name: Option<RawChunkOptionName>,
+  pub filename: Option<JsFilename>,
   pub cache_groups: Option<Vec<RawCacheGroupOptions>>,
   /// What kind of chunks should be selected.
   #[napi(ts_type = "RegExp | 'async' | 'initial' | 'all' | Function")]
@@ -107,6 +108,8 @@ impl From<RawSplitChunksOptions> for rspack_plugin_split_chunks::PluginOptions {
 
     let mut cache_groups = vec![];
 
+    let overall_filename = raw_opts.filename.map(Filename::from);
+
     let overall_chunk_filter = raw_opts.chunks.map(create_chunks_filter);
 
     let overall_min_chunks = raw_opts.min_chunks.unwrap_or(1);
@@ -214,7 +217,10 @@ impl From<RawSplitChunksOptions> for rspack_plugin_split_chunks::PluginOptions {
             automatic_name_delimiter: v
               .automatic_name_delimiter
               .unwrap_or(overall_automatic_name_delimiter.clone()),
-            filename: v.filename.map(Filename::from),
+            filename: v
+              .filename
+              .map(Filename::from)
+              .or_else(|| overall_filename.clone()),
             reuse_existing_chunk: v.reuse_existing_chunk.unwrap_or(false),
             max_async_requests: v.max_async_requests.unwrap_or(f64::INFINITY),
             max_initial_requests: v.max_initial_requests.unwrap_or(f64::INFINITY),

packages/rspack-test-tools/tests/configCases/split-chunks/custom-filename-overall/a.js

@@ -0,0 +1,26 @@
+import "./shared1";
+import "./common1";
+
+it("should be able to load the split chunk on demand (shared)", () => {
+	return import(/* webpackChunkName: "theName" */ "./shared2");
+});
+
+it("should be able to load the split chunk on demand (common)", () => {
+	return Promise.all([
+		import(/* webpackChunkName: "otherName1" */ "./common2"),
+		import(/* webpackChunkName: "otherName2" */ "./common3")
+	]);
+});
+
+it("should have files", async () => {
+	const fs = require("fs");
+	const path = require("path");
+	const files = await fs.promises.readdir(__dirname);
+	expect(files).toContain("shared-shared-shared1_js.js");
+	expect(files).toContain("shared-shared-shared2_js.js");
+	expect(files).toContain("splitted-chunks");
+	const innerFiles = await fs.promises.readdir(path.resolve(__dirname, "splitted-chunks"));
+	expect(innerFiles).toContain("common-common1_js.js");
+	expect(innerFiles).toContain("common-common2_js.js");
+	expect(innerFiles).toContain("common-common3_js.js");
+});

packages/rspack-test-tools/tests/configCases/split-chunks/custom-filename-overall/b.js

@@ -0,0 +1,5 @@
+import "./shared1";
+import "./shared2";
+import "./common1";
+import "./common2";
+import "./common3";

packages/rspack-test-tools/tests/configCases/split-chunks/custom-filename-overall/common1.js

@@ -0,0 +1,31 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	mode: "development",
+	entry: {
+		a: "./a",
+		b: "./b"
+	},
+	output: {
+		filename: "[name].js",
+		libraryTarget: "commonjs2"
+	},
+	optimization: {
+		chunkIds: "named",
+		splitChunks: {
+			filename: "splitted-chunks/[name].js",
+			cacheGroups: {
+				shared: {
+					chunks: "all",
+					test: /shared/,
+					filename: "shared-[name].js",
+					enforce: true
+				},
+				common: {
+					chunks: "all",
+					test: /common/,
+					enforce: true
+				}
+			}
+		}
+	}
+};