chore: enable redundant_clone rule

Author: hardfist

crates/rspack/src/builder/mod.rs

@@ -1001,14 +1001,12 @@ impl CompilerOptionsBuilder {
         filename: (!inline).then_some(output.source_map_filename.as_str().to_string()),
         module_filename_template: output_builder
           .devtool_module_filename_template
-          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string()))
-          .clone(),
+          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string())),
         append: hidden.then_some(rspack_plugin_devtool::Append::Disabled),
         columns: !cheap,
         fallback_module_filename_template: output_builder
           .devtool_fallback_module_filename_template
-          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string()))
-          .clone(),
+          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string())),
         module: if module_maps { true } else { !cheap },
         namespace: output_builder.devtool_namespace.clone(),
         no_sources,
@@ -1035,8 +1033,7 @@ impl CompilerOptionsBuilder {
       let options = rspack_plugin_devtool::EvalDevToolModulePluginOptions {
         module_filename_template: output_builder
           .devtool_module_filename_template
-          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string()))
-          .clone(),
+          .map(|t| rspack_plugin_devtool::ModuleFilenameTemplate::String(t.as_str().to_string())),
         namespace: output_builder.devtool_namespace.clone(),
         source_url_comment: None,
       };
@@ -1752,7 +1749,7 @@ impl ModuleOptionsBuilder {
         named_exports: Some(true),
         url: Some(true),
       });
-      parser.insert("css".to_string(), css_parser_options.clone());
+      parser.insert("css".to_string(), css_parser_options);
 
       let css_auto_parser_options = ParserOptions::CssAuto(CssAutoParserOptions {
         named_exports: Some(true),

crates/rspack_browser/src/oneshot.rs

@@ -24,9 +24,7 @@ pub fn channel<T>() -> (Sender<T>, Receiver<T>) {
     inner: inner.clone(),
   };
 
-  let rx = Receiver {
-    inner: inner.clone(),
-  };
+  let rx = Receiver { inner };
 
   (tx, rx)
 }

crates/rspack_core/src/chunk_graph/mod.rs

@@ -101,7 +101,7 @@ impl ChunkGraph {
         .map(|chunk_name| format!("    <tr><td>{chunk_name}</td></tr>"))
         .join("\n");
 
-      let table_body = requests.clone();
+      let table_body = requests;
 
       format!(
         r#"

crates/rspack_core/src/compilation/build_module_graph/module_executor/mod.rs

@@ -71,7 +71,7 @@ impl ModuleExecutor {
     };
     let (event_sender, event_receiver) = unbounded_channel();
     let (stop_sender, stop_receiver) = oneshot::channel();
-    self.event_sender = Some(event_sender.clone());
+    self.event_sender = Some(event_sender);
     self.stop_receiver = Some(stop_receiver);
     // avoid coop budget consumed to zero cause hang risk
     // related to https://tokio.rs/blog/2020-04-preemption

crates/rspack_core/src/concatenated_module.rs

@@ -2447,7 +2447,7 @@ impl ConcatenatedModule {
       module_graph,
       module_graph_cache,
       info,
-      export_name.clone(),
+      export_name,
       module_to_info_map,
       runtime,
       as_call,
@@ -2939,7 +2939,7 @@ impl ConcatenatedModule {
                 mg_cache,
                 &ref_info.id(),
                 if let Some(reexport_export) = reexport.export {
-                  [reexport_export.clone(), export_name[1..].to_vec()].concat()
+                  [reexport_export, export_name[1..].to_vec()].concat()
                 } else {
                   export_name[1..].to_vec()
                 },

crates/rspack_core/src/external_module.rs

@@ -567,15 +567,15 @@ impl ExternalModule {
 
                 concatenation_scope.register_namespace_import(
                   request.primary().to_string(),
-                  attributes.clone(),
+                  attributes,
                   format!("__rspack_external_{id}").into(),
                 );
                 concatenation_scope.register_namespace_export(&namespace_export_with_name);
               }
               UsedExports::UsedNamespace(false) => {
                 concatenation_scope.register_import(
                   request.primary().to_string(),
-                  attributes.clone(),
+                  attributes,
                   None,
                 );
               }
@@ -587,7 +587,7 @@ impl ExternalModule {
                         "import * as __rspack_external_{} from {}{};\n",
                         id.clone(),
                         json_stringify(request.primary()),
-                        attributes.clone().unwrap_or_default()
+                        attributes.unwrap_or_default()
                       ),
                       InitFragmentStage::StageESMImports,
                       module_graph

crates/rspack_loader_swc/src/rsc_transforms/server_actions.rs

@@ -394,7 +394,7 @@ impl<'a, C: Comments> ServerActions<'a, C> {
     }
 
     let action_name = self.gen_action_ident();
-    let action_ident = Ident::new(action_name.clone(), arrow.span, self.private_ctxt);
+    let action_ident = Ident::new(action_name, arrow.span, self.private_ctxt);
     let action_id = self.generate_server_reference_id(
       &ModuleExportName::Ident(action_ident.clone()),
       Some(&new_params),
@@ -524,17 +524,17 @@ impl<'a, C: Comments> ServerActions<'a, C> {
       })));
 
     if ids_from_closure.is_empty() {
-      Expr::Ident(action_ident.clone())
+      Expr::Ident(action_ident)
     } else {
       self.has_server_reference_with_bound_args = true;
       bind_args_to_ident(
-        action_ident.clone(),
+        action_ident,
         ids_from_closure
           .iter()
           .cloned()
           .map(|id| Some(id.as_arg()))
           .collect(),
-        action_id.clone(),
+        action_id,
       )
     }
   }
@@ -559,7 +559,7 @@ impl<'a, C: Comments> ServerActions<'a, C> {
     new_params.append(&mut function.params);
 
     let action_name: Atom = self.gen_action_ident();
-    let mut action_ident = Ident::new(action_name.clone(), function.span, self.private_ctxt);
+    let mut action_ident = Ident::new(action_name, function.span, self.private_ctxt);
     if action_ident.span.lo == self.start_pos {
       action_ident.span = Span::dummy_with_cmt();
     }
@@ -668,17 +668,17 @@ impl<'a, C: Comments> ServerActions<'a, C> {
       })));
 
     if ids_from_closure.is_empty() {
-      Expr::Ident(action_ident.clone())
+      Expr::Ident(action_ident)
     } else {
       self.has_server_reference_with_bound_args = true;
       bind_args_to_ident(
-        action_ident.clone(),
+        action_ident,
         ids_from_closure
           .iter()
           .cloned()
           .map(|id| Some(id.as_arg()))
           .collect(),
-        action_id.clone(),
+        action_id,
       )
     }
   }
@@ -716,7 +716,7 @@ impl<'a, C: Comments> ServerActions<'a, C> {
       self.server_reference_exports.push(ServerReferenceExport {
         ident: fn_name.clone(),
         export_name: export_name.clone(),
-        reference_id: reference_id.clone(),
+        reference_id,
       });
     } else if self.is_default_export() {
       let action_ident = Ident::new(self.gen_action_ident(), span, self.private_ctxt);
@@ -730,7 +730,7 @@ impl<'a, C: Comments> ServerActions<'a, C> {
       self.server_reference_exports.push(ServerReferenceExport {
         ident: action_ident.clone(),
         export_name: export_name.clone(),
-        reference_id: reference_id.clone(),
+        reference_id,
       });
 
       // For the server layer, also hoist the function and rewrite the default export.
@@ -825,8 +825,8 @@ impl<'a, C: Comments> VisitMut for ServerActions<'a, C> {
 
       self.server_reference_exports.push(ServerReferenceExport {
         ident: action_ident.clone(),
-        export_name: export_name.clone(),
-        reference_id: action_id.clone(),
+        export_name,
+        reference_id: action_id,
       });
 
       self
@@ -1146,7 +1146,7 @@ impl<'a, C: Comments> VisitMut for ServerActions<'a, C> {
         self.rewrite_expr_to_proxy_expr = None;
         self.current_export_name = None;
         n.visit_mut_children_with(self);
-        self.current_export_name = old_current_export_name.clone();
+        self.current_export_name = old_current_export_name;
         self.this_status = old_this_status;
 
         if let Some(expr) = self.rewrite_expr_to_proxy_expr.take() {
@@ -2072,7 +2072,7 @@ fn annotate_ident_as_server_reference(ident: Ident, action_id: Atom, original_sp
       },
       ExprOrSpread {
         spread: None,
-        expr: Box::new(action_id.clone().into()),
+        expr: Box::new(action_id.into()),
       },
       ExprOrSpread {
         spread: None,

crates/rspack_macros_test/tests/merge.rs

@@ -30,7 +30,7 @@ mod enum_fields {
       two: "2".to_string(),
       three: "3".to_string(),
     };
-    let t5 = MergeFrom::merge_from(t1.clone(), &t4);
+    let t5 = MergeFrom::merge_from(t1, &t4);
     assert!(matches!(t5, Test::A { one, two, three } if one == "1" && two == "2" && three == "3"));
   }
 }
@@ -58,7 +58,7 @@ mod enum_base {
       three: "three".to_string(),
     };
     let t2 = Test::C;
-    let t3 = MergeFrom::merge_from(t1.clone(), &t2);
+    let t3 = MergeFrom::merge_from(t1, &t2);
     assert!(
       matches!(t3, Test::A { one, two, three } if one == "one" && two == "two" && three == "three")
     );

crates/rspack_plugin_asset/src/lib.rs

@@ -911,7 +911,7 @@ impl Plugin for AssetPlugin {
           .and_then(|x| x.emit);
 
         Box::new(AssetParserAndGenerator::with_auto(
-          data_url_condition.clone(),
+          data_url_condition,
           emit.unwrap_or(true),
         ))
       }),

crates/rspack_plugin_copy/src/lib.rs

@@ -205,11 +205,7 @@ impl CopyRspackPlugin {
         }
       };
 
-      to.clone()
-        .as_path()
-        .normalize()
-        .to_string_lossy()
-        .to_string()
+      to.as_path().normalize().to_string_lossy().to_string()
     } else {
       String::new()
     };