fix: get resolve in externals should return query (#11276)

Author: SyMind

packages/rspack-test-tools/tests/configCases/externals/resolve-with-query/index.js

@@ -0,0 +1,23 @@
+const path = require("path");
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+    externals: [
+        async ({ context, getResolve }) => {
+            const resolve = getResolve();
+            expect(await resolve(context, "./index.js?foo=1#bar=1")).toBe(path.join(__dirname, "./index.js") + "?foo=1#bar=1");
+            expect(
+                await new Promise((promiseResolve, promiseReject) => {
+                    resolve(context, "./index.js?foo=1#bar=1", (err, result) => {
+                        if (err) {
+                            promiseReject(err);
+                            return;
+                        }
+                        promiseResolve(result);
+                    })
+                })
+            ).toBe(path.join(__dirname, "./index.js") + "?foo=1#bar=1");
+            return false;
+        }
+    ]
+};

packages/rspack-test-tools/tests/configCases/externals/resolve-with-query/rspack.config.js

@@ -48,6 +48,17 @@ export class ExternalsPlugin extends RspackBuiltinPlugin {
 		return Object.assign({}, resolveRequest);
 	};
 
+	// Reference: webpack/enhanced-resolve#255
+	// Handle fragment escaping in resolve results:
+	// - `#` can be escaped as `\0#` to prevent fragment parsing
+	// - enhanced-resolve resolves `#` ambiguously as both path and fragment
+	// - Example: `./some#thing` could resolve to `.../some.js#thing` or `.../some#thing.js`
+	// - When `#` is part of the path, it gets escaped as `\0#` in the result
+	// - We replace `\0#` with zero-width space + `#` (\u200b#) for compatibility
+	#processRequest(req: ResolveRequest): string {
+		return `${req.path.replace(/#/g, "\u200b#")}${req.query.replace(/#/g, "\u200b#")}${req.fragment}`;
+	}
+
 	#getRawExternalItem = (item: ExternalItem | undefined): RawExternalItem => {
 		if (typeof item === "string" || item instanceof RegExp) {
 			return item;
@@ -68,7 +79,7 @@ export class ExternalsPlugin extends RspackBuiltinPlugin {
 								issuer: data.contextInfo.issuer,
 								issuerLayer: data.contextInfo.issuerLayer ?? null
 							},
-							getResolve(options) {
+							getResolve: options => {
 								const rawResolve = options ? getRawResolve(options) : undefined;
 								const resolve = ctx.getResolve(rawResolve);
 
@@ -83,7 +94,11 @@ export class ExternalsPlugin extends RspackBuiltinPlugin {
 												callback(error);
 											} else {
 												const req = processResolveResult(text);
-												callback(null, req?.path ?? false, req);
+												callback(
+													null,
+													req ? this.#processRequest(req) : false,
+													req
+												);
 											}
 										});
 									} else {
@@ -93,7 +108,9 @@ export class ExternalsPlugin extends RspackBuiltinPlugin {
 													promiseReject(error);
 												} else {
 													const req = processResolveResult(text);
-													promiseResolve(req?.path);
+													promiseResolve(
+														req ? this.#processRequest(req) : undefined
+													);
 												}
 											});
 										});